r101475 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101474‎ | r101475 | r101476 >
Date:14:04, 1 November 2011
Author:petrb
Status:deferred (Comments)
Tags:
Comment:
there is no need to hold the class data in variable
Modified paths:
  • /trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OnlineStatusBar/OnlineStatusBar.body.php
@@ -145,13 +145,11 @@
146146 if ( $old_user === false || $old_user == null ) {
147147 return false;
148148 }
149 -
 149+ // purge both pages now
150150 if ( $old_user->getOption('OnlineStatusBar_active', false) ) {
151151 if ( $old_user->getOption('OnlineStatusBar_autoupdate', false) == true ) {
152 - $tp = WikiPage::factory( $old_user->getTalkPage() );
153 - $up = WikiPage::factory( $old_user->getUserPage() );
154 - $tp->doPurge();
155 - $up->doPurge();
 152+ WikiPage::factory( $old_user->getUserPage() )->doPurge();
 153+ WikiPage::factory( $old_user->getTalkPage() )->doPurge();
156154 }
157155 }
158156 return true;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101402fixed purge, thank's to guys who explaned me how is_string and is_a can be us...petrb20:21, 31 October 2011
r101471fixed the purgepetrb13:17, 1 November 2011
r101474improved purgepetrb13:57, 1 November 2011

Comments

#Comment by Petrb (talk | contribs)   15:10, 1 November 2011

could someone do a review of changes I made since last release, thanks

Status & tagging log