r102533 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102532‎ | r102533 | r102534 >
Date:17:04, 9 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_18/phase3 (modified) (history)
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/includes (modified) (history)
  • /branches/REL1_18/phase3/includes/HTMLForm.php (modified) (history)
  • /branches/REL1_18/phase3/includes/OutputPage.php (modified) (history)
  • /branches/REL1_18/phase3/includes/api (modified) (history)
  • /branches/REL1_18/phase3/includes/api/ApiQueryWatchlist.php (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/Installer.i18n.php (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/REL1_18/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php (modified) (history)
  • /branches/REL1_18/phase3/includes/specials (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialMostlinkedtemplates.php (modified) (history)
  • /branches/REL1_18/phase3/maintenance/update.php (modified) (history)
  • /branches/REL1_18/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)
  • /branches/REL1_18/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/maintenance/update.php
@@ -43,7 +43,7 @@
4444 $this->addOption( 'quick', 'Skip 5 second countdown before starting' );
4545 $this->addOption( 'doshared', 'Also update shared tables' );
4646 $this->addOption( 'nopurge', 'Do not purge the objectcache table after updates' );
47 - $this->addOption( 'iknowwhatimdoing', 'Override when $wgMiserMode disables this script' );
 47+ $this->addOption( 'force', 'Override when $wgMiserMode disables this script' );
4848 }
4949
5050 function getDbType() {
@@ -78,10 +78,10 @@
7979 function execute() {
8080 global $wgVersion, $wgTitle, $wgLang, $wgMiserMode;
8181
82 - if( $wgMiserMode && !$this->hasOption( 'iknowwhatimdoing' ) ) {
 82+ if( $wgMiserMode && !$this->hasOption( 'force' ) ) {
8383 $this->error( "Do not run update.php on this wiki. If you're seeing this you should\n"
8484 . "probably ask for some help in performing your schema updates.\n\n"
85 - . "If you know what you are doing, you can continue with --iknowwhatimdoing", true );
 85+ . "If you know what you are doing, you can continue with --force", true );
8686 }
8787
8888 $wgLang = Language::factory( 'en' );
Index: branches/REL1_18/phase3/skins/common/shared.css
@@ -18,12 +18,6 @@
1919 /* @noflip */textarea[dir="ltr"], input[dir="ltr"] { direction: ltr; }
2020 /* @noflip */textarea[dir="rtl"], input[dir="rtl"] { direction: rtl; }
2121
22 -/* The scripts of these languages are very hard to read with underlines */
23 -[lang="ar"] a, [lang="ckb"] a, [lang="fa"] a, [lang="kk-arab"] a,
24 -[lang="mzn"] a, [lang="ps"] a, [lang="ur"] a {
25 - text-decoration: none;
26 -}
27 -
2822 /* Default style for semantic tags */
2923 abbr, acronym, .explain {
3024 border-bottom: 1px dotted black;
Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
@@ -673,6 +673,8 @@
674674 * (bug 30817) Restored linktrail for kk (Kazakh)
675675 * (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces
676676 * (bug 30846) New LanguageOs class
 677+* (bug 31913) Special:MostLinkedTemplates had an incorrect GROUP BY clause
 678+ under Microsoft SQL.
677679
678680 === Other changes in 1.18 ===
679681 * Removed legacy wgAjaxWatch javascript global object, no longer in use.
Property changes on: branches/REL1_18/phase3/RELEASE-NOTES-1.18
___________________________________________________________________
Modified: svn:mergeinfo
680682 Merged /trunk/phase3/RELEASE-NOTES-1.18:r101470,101476
Index: branches/REL1_18/phase3/includes/HTMLForm.php
@@ -1319,7 +1319,10 @@
13201320 }
13211321
13221322 // GetCheck won't work like we want for checks.
1323 - if ( $request->getCheck( 'wpEditToken' ) || $this->mParent->getMethod() != 'post' ) {
 1323+ // Fetch the value in either one of the two following case:
 1324+ // - we have a valid token (form got posted or GET forged by the user)
 1325+ // - checkbox name has a value (false or true), ie is not null
 1326+ if ( $request->getCheck( 'wpEditToken' ) || $request->getVal( $this->mName )!== null ) {
13241327 // XOR has the following truth table, which is what we want
13251328 // INVERT VALUE | OUTPUT
13261329 // true true | false
Index: branches/REL1_18/phase3/includes/OutputPage.php
@@ -1596,7 +1596,7 @@
15971597 $this->mVaryHeader[$header] = $option;
15981598 }
15991599 }
1600 - $this->mVaryHeader[$header] = array_unique( $this->mVaryHeader[$header] );
 1600+ $this->mVaryHeader[$header] = array_unique( (array)$this->mVaryHeader[$header] );
16011601 }
16021602
16031603 /**
Property changes on: branches/REL1_18/phase3/includes/OutputPage.php
___________________________________________________________________
Modified: svn:mergeinfo
16041604 Merged /trunk/phase3/includes/OutputPage.php:r101376,101417,101420,101445
Index: branches/REL1_18/phase3/includes/installer/Installer.php
@@ -972,7 +972,10 @@
973973 protected function envCheckSuhosinMaxValueLength() {
974974 $maxValueLength = ini_get( 'suhosin.get.max_value_length' );
975975 if ( $maxValueLength > 0 ) {
976 - $this->showMessage( 'config-suhosin-max-value-length', $maxValueLength );
 976+ if( $maxValueLength < 1024 ) {
 977+ # Only warn if the value is below the sane 1024
 978+ $this->showMessage( 'config-suhosin-max-value-length', $maxValueLength );
 979+ }
977980 } else {
978981 $maxValueLength = -1;
979982 }
Index: branches/REL1_18/phase3/includes/installer/Installer.i18n.php
@@ -623,6 +623,7 @@
624624 'config-admin-password' => '{{Identical|Password}}',
625625 'config-admin-email' => '{{Identical|E-mail address}}',
626626 'config-subscribe' => 'Used as label for the installer checkbox',
 627+ 'config-suhosin-max-value-length' => 'Message shown when PHP parameter suhosin.get.max_value_length is between 0 and 1023 (that max value is hard set in MediaWiki software',
627628 'config-profile-help' => 'Messages referenced:
628629 * {{msg-mw|config-profile-wiki}}
629630 * {{msg-mw|config-profile-no-anon}}
Index: branches/REL1_18/phase3/includes/api/ApiQueryWatchlist.php
@@ -409,7 +409,7 @@
410410 ' parsedcomment - Adds parsed comment of the edit',
411411 ' timestamp - Adds timestamp of the edit',
412412 ' patrol - Tags edits that are patrolled',
413 - ' size - Adds the old and new lengths of the page',
 413+ ' sizes - Adds the old and new lengths of the page',
414414 ' notificationtimestamp - Adds timestamp of when the user was last notified about the edit',
415415 ' loginfo - Adds log information where appropriate',
416416 ),
Property changes on: branches/REL1_18/phase3/includes/api
___________________________________________________________________
Modified: svn:mergeinfo
417417 Merged /trunk/phase3/includes/api:r101314,101370,101376,101417,101420,101445
Index: branches/REL1_18/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php
@@ -93,7 +93,11 @@
9494 $rules = array();
9595 if ( $options['underline'] < 2 ) {
9696 $rules[] = "a { text-decoration: " .
97 - ( $options['underline'] ? 'underline !important' : 'none' ) . "; }";
 97+ ( $options['underline'] ? 'underline' : 'none' ) . "; }";
 98+ } else {
 99+ # The scripts of these languages are very hard to read with underlines
 100+ $rules[] = 'a:lang(ar), a:lang(ckb), a:lang(fa),a:lang(kk-arab), ' .
 101+ 'a:lang(mzn), a:lang(ps), a:lang(ur) { text-decoration: none; }';
98102 }
99103 if ( $options['highlightbroken'] ) {
100104 $rules[] = "a.new, #quickbar a.new { color: #ba0000; }\n";
Index: branches/REL1_18/phase3/includes/specials/SpecialMostlinkedtemplates.php
@@ -68,7 +68,7 @@
6969 'tl_title AS title',
7070 'COUNT(*) AS value' ),
7171 'conds' => array ( 'tl_namespace' => NS_TEMPLATE ),
72 - 'options' => array( 'GROUP BY' => 'namespace, title' )
 72+ 'options' => array( 'GROUP BY' => 'tl_namespace, tl_title' )
7373 );
7474 }
7575
Property changes on: branches/REL1_18/phase3/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
7676 Merged /trunk/phase3/includes/specials:r101470,101476
Property changes on: branches/REL1_18/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
7777 Merged /trunk/phase3/includes:r101314,101370,101376,101417,101420,101445,101464,101470,101476
Index: branches/REL1_18/phase3/resources/jquery/jquery.tablesorter.js
@@ -229,7 +229,7 @@
230230 * @param $table jQuery object for a <table>
231231 */
232232 function emulateTHeadAndFoot( $table ) {
233 - var $rows = $table.find( 'tr' );
 233+ var $rows = $table.find( '> tbody > tr' );
234234 if( !$table.get(0).tHead ) {
235235 var $thead = $( '<thead>' );
236236 $rows.each( function() {
@@ -269,7 +269,7 @@
270270 });
271271 $tableHeaders = $( longest );
272272 }
273 - $tableHeaders = $tableHeaders.find( 'th' ).each( function( index ) {
 273+ $tableHeaders = $tableHeaders.children( 'th' ).each( function( index ) {
274274 this.column = realCellIndex;
275275
276276 var colspan = this.colspan;
@@ -441,13 +441,13 @@
442442
443443 function explodeRowspans( $table ) {
444444 // Split multi row cells into multiple cells with the same content
445 - $table.find( 'tbody [rowspan]' ).each(function() {
 445+ $table.find( '> tbody > tr > [rowspan]' ).each(function() {
446446 var rowSpan = this.rowSpan;
447447 this.rowSpan = 1;
448448 var cell = $( this );
449449 var next = cell.parent().nextAll();
450450 for ( var i = 0; i < rowSpan - 1; i++ ) {
451 - var td = next.eq( i ).find( 'td' );
 451+ var td = next.eq( i ).children( 'td' );
452452 if ( !td.length ) {
453453 next.eq( i ).append( cell.clone() );
454454 } else if ( this.cellIndex === 0 ) {
@@ -598,10 +598,10 @@
599599 // Legacy fix of .sortbottoms
600600 // Wrap them inside inside a tfoot (because that's what they actually want to be) &
601601 // and put the <tfoot> at the end of the <table>
602 - var $sortbottoms = $table.find( 'tr.sortbottom' );
 602+ var $sortbottoms = $table.find( '> tbody > tr.sortbottom' );
603603 if ( $sortbottoms.length ) {
604 - var $tfoot = $table.find( 'tfoot' );
605 - if( $tfoot.length ) {
 604+ var $tfoot = $table.children( 'tfoot' );
 605+ if ( $tfoot.length ) {
606606 $tfoot.eq(0).prepend( $sortbottoms );
607607 } else {
608608 $table.append( $( '<tfoot>' ).append( $sortbottoms ) )
Property changes on: branches/REL1_18/phase3
___________________________________________________________________
Modified: svn:mergeinfo
609609 Merged /trunk/phase3:r101314,101370,101376,101417,101420,101445,101464,101470,101476

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101314(bug 32051) Fix description for wlprop=sizescatrope21:02, 30 October 2011
r101370Renamed annoying --iknowwhatimdoing param to --force (bug 32073)aaron17:30, 31 October 2011
r101376Prevent notice in OutputPage by casting to an array. This already exists on t...catrope18:27, 31 October 2011
r101417jquery.tablesorter: Selector fixes...krinkle22:12, 31 October 2011
r101420jquery.tablesorter: More selector fixes...krinkle22:20, 31 October 2011
r101445Follow-up r96261: remove the !important again, and then do the script default...robin00:17, 1 November 2011
r101464checkbox could not be checked through URL parameter...hashar09:28, 1 November 2011
r101470Fix GROUP BY clause in Special:MostLinkedTemplates...hashar13:14, 1 November 2011
r101476bug 32100 installer complains about suhosin GET limit...hashar14:05, 1 November 2011

Status & tagging log