r101376 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101375‎ | r101376 | r101377 >
Date:18:27, 31 October 2011
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Prevent notice in OutputPage by casting to an array. This already exists on the WMF cluster as a live hack
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1640,7 +1640,7 @@
16411641 $this->mVaryHeader[$header] = $option;
16421642 }
16431643 }
1644 - $this->mVaryHeader[$header] = array_unique( $this->mVaryHeader[$header] );
 1644+ $this->mVaryHeader[$header] = array_unique( (array)$this->mVaryHeader[$header] );
16451645 }
16461646
16471647 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r1013781.18wmf1: MFT r101376catrope18:28, 31 October 2011
r102533REL1_18: MFT r101314, r101370, r101376, r101417, r101420, r101445, r101464, r...reedy17:04, 9 November 2011

Comments

#Comment by G.Hagedorn (talk | contribs)   10:09, 1 November 2011

was applied to 1.18wmf1, please consider tagging for 1.18

Status & tagging log