r101470 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101469‎ | r101470 | r101471 >
Date:13:14, 1 November 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
Fix GROUP BY clause in Special:MostLinkedTemplates

This only cause a trouble for Microsoft SQL which require the column to be
referenced by their input name, not the output one (AS alias). Might trigger
on Oracle database.

This is part of bug 31913: 'GROUP BY clauses incorrect in SQL generated
for special pages'

Need backport in REL1_18
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMostlinkedtemplates.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.18
@@ -656,6 +656,8 @@
657657 * (bug 30817) Restored linktrail for kk (Kazakh)
658658 * (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespaces
659659 * (bug 30846) New LanguageOs class
 660+* (bug 31913) Special:MostLinkedTemplates had an incorrect GROUP BY clause
 661+ under Microsoft SQL.
660662
661663 === Other changes in 1.18 ===
662664 * Removed legacy wgAjaxWatch javascript global object, no longer in use.
Index: trunk/phase3/includes/specials/SpecialMostlinkedtemplates.php
@@ -68,7 +68,7 @@
6969 'tl_title AS title',
7070 'COUNT(*) AS value' ),
7171 'conds' => array ( 'tl_namespace' => NS_TEMPLATE ),
72 - 'options' => array( 'GROUP BY' => 'namespace, title' )
 72+ 'options' => array( 'GROUP BY' => 'tl_namespace, tl_title' )
7373 );
7474 }
7575

Follow-up revisions

RevisionCommit summaryAuthorDate
r102533REL1_18: MFT r101314, r101370, r101376, r101417, r101420, r101445, r101464, r...reedy17:04, 9 November 2011

Comments

#Comment by Hashar (talk | contribs)   13:17, 1 November 2011

Bug fix for 1.18. Not really needed in 1.18wmf1 since WMF does not use Microsoft SQL.

Status & tagging log