r101477 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101476‎ | r101477 | r101478 >
Date:14:10, 1 November 2011
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
Table for message group states
Internationalization/#173
Modified paths:
  • /trunk/extensions/Translate/TranslateHooks.php (modified) (history)
  • /trunk/extensions/Translate/sql/translate_groupreviews.sql (added) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateHooks.php
——@@ -184,6 +184,7 @@
185185 $updater->addExtensionUpdate( array( 'addIndex', 'translate_sections', 'trs_page_order', "$dir/translate_sections-indexchange.sql", true ) );
186186 $updater->addExtensionUpdate( array( 'dropIndex', 'translate_sections', 'trs_page', "$dir/translate_sections-indexchange2.sql", true ) );
187187 $updater->addExtensionUpdate( array( 'addTable', 'translate_reviews', "$dir/translate_reviews.sql", true ) );
 188+ $updater->addExtensionUpdate( array( 'addTable', 'translate_groupreviews', "$dir/translate_groupreviews.sql", true ) );
188189
189190 return true;
190191 }
Index: trunk/extensions/Translate/sql/translate_groupreviews.sql
——@@ -0,0 +1,13 @@
 2+-- Message group workflow states
 3+CREATE TABLE /*$wgDBprefix*/translate_groupreviews (
 4+ -- The length we need to accommodate "page-" + the full pagename including
 5+ -- prefix. That could be 255 + prefix (length not limited), but page
 6+ -- translation section pages limit that to shorter, because it needs to
 7+ -- accommodate /sectionname/languagecode suffix to the page name.
 8+ tgr_group varchar(200) binary NOT NULL,
 9+
 10+ -- Any of user configured values from $wgTranslateWorkflowStates
 11+ tgr_state varbinary(32) not null,
 12+
 13+ PRIMARY KEY (tgr_group, tgr_state)
 14+) /*$wgDBTableOptions*/;
\ No newline at end of file
Property changes on: trunk/extensions/Translate/sql/translate_groupreviews.sql
___________________________________________________________________
Added: svn:eol-style
115 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r101607Followup r101477 - we obviously need also language codenikerabbit10:16, 2 November 2011
r101801Per comments in r101477, changed all (not) null to (NOT) NULL for consistency.nikerabbit09:27, 3 November 2011

Comments

#Comment by Amire80 (talk | contribs)   21:48, 2 November 2011

If i understand the the coding standards correctly, it should be "NOT NULL", in uppercase.

#Comment by Nikerabbit (talk | contribs)   09:24, 3 November 2011

That seems to be the case yes: 

    83 not null
     1 Not null
  3222 NOT NULL

Status & tagging log