r101370 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101369‎ | r101370 | r101371 >
Date:17:30, 31 October 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Renamed annoying --iknowwhatimdoing param to --force (bug 32073)
Modified paths:
  • /trunk/phase3/maintenance/update.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/update.php
@@ -43,7 +43,7 @@
4444 $this->addOption( 'quick', 'Skip 5 second countdown before starting' );
4545 $this->addOption( 'doshared', 'Also update shared tables' );
4646 $this->addOption( 'nopurge', 'Do not purge the objectcache table after updates' );
47 - $this->addOption( 'iknowwhatimdoing', 'Override when $wgMiserMode disables this script' );
 47+ $this->addOption( 'force', 'Override when $wgMiserMode disables this script' );
4848 }
4949
5050 function getDbType() {
@@ -78,10 +78,10 @@
7979 function execute() {
8080 global $wgVersion, $wgTitle, $wgLang, $wgMiserMode;
8181
82 - if( $wgMiserMode && !$this->hasOption( 'iknowwhatimdoing' ) ) {
 82+ if( $wgMiserMode && !$this->hasOption( 'force' ) ) {
8383 $this->error( "Do not run update.php on this wiki. If you're seeing this you should\n"
8484 . "probably ask for some help in performing your schema updates.\n\n"
85 - . "If you know what you are doing, you can continue with --iknowwhatimdoing", true );
 85+ . "If you know what you are doing, you can continue with --force", true );
8686 }
8787
8888 $wgLang = Language::factory( 'en' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r102533REL1_18: MFT r101314, r101370, r101376, r101417, r101420, r101445, r101464, r...reedy17:04, 9 November 2011

Comments

#Comment by Hashar (talk | contribs)   15:33, 1 November 2011

Thanks Aaron !

#Comment by Aaron Schulz (talk | contribs)   18:21, 9 November 2011

Did this really need a backport? Ah well.

Status & tagging log