r101420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r101419‎ | r101420 | r101421 >
Date:22:20, 31 October 2011
Author:krinkle
Status:ok
Tags:
Comment:
jquery.tablesorter: More selector fixes
* Limit to rowSpans (td or th) within tableRows that are a direct child of this table's tBody
* Follows-up r99092, r101417
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
——@@ -442,7 +442,7 @@
443443
444444 function explodeRowspans( $table ) {
445445 // Split multi row cells into multiple cells with the same content
446 - $table.find( '> tbody [rowspan]' ).each(function() {
 446+ $table.find( '> tbody > tr > [rowspan]' ).each(function() {
447447 var rowSpan = this.rowSpan;
448448 this.rowSpan = 1;
449449 var cell = $( this );

Follow-up revisions

RevisionCommit summaryAuthorDate
r102533REL1_18: MFT r101314, r101370, r101376, r101417, r101420, r101445, r101464, r...reedy17:04, 9 November 2011
r1025931.18wmf1 MFT r101417, r101420, r101540reedy23:05, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99092(bug 31420) Fix weird tablesorter bug where headers spanning multiple rows wo...catrope12:52, 6 October 2011
r101417jquery.tablesorter: Selector fixes...krinkle22:12, 31 October 2011

Status & tagging log