r99092 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99091‎ | r99092 | r99093 >
Date:12:52, 6 October 2011
Author:catrope
Status:ok (Comments)
Tags:needs-js-test 
Comment:
(bug 31420) Fix weird tablesorter bug where headers spanning multiple rows would get screwed up. Thanks to TheDJ for essentially telling me exactly how to fix this, he was spot on.
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
——@@ -442,7 +442,7 @@
443443
444444 function explodeRowspans( $table ) {
445445 // Split multi row cells into multiple cells with the same content
446 - $table.find( '[rowspan]' ).each(function() {
 446+ $table.find( 'tbody [rowspan]' ).each(function() {
447447 var rowSpan = this.rowSpan;
448448 this.rowSpan = 1;
449449 var cell = $( this );

Follow-up revisions

RevisionCommit summaryAuthorDate
r990941.18wmf1: MFT r98235, r98411, r98665, r98676, r98678, r98773, r98812, r99082,...catrope13:01, 6 October 2011
r101420jquery.tablesorter: More selector fixes...krinkle22:20, 31 October 2011
r102516REL1_18 MFT r99092, r99477reedy14:44, 9 November 2011

Comments

#Comment by Krinkle (talk | contribs)   00:08, 8 October 2011

I haven't tested this but something tells me we should also use a direct child selector and any remaining tag names in this path to avoid selecting stuff from other nested tables.

#Comment by Catrope (talk | contribs)   15:11, 8 October 2011

That sounds like a good idea. Go for it.

#Comment by Krinkle (talk | contribs)   22:20, 31 October 2011

Done in r101420.

#Comment by G.Hagedorn (talk | contribs)   22:52, 7 November 2011

I think we may have this bug. It is applied to 1.18wmf1, but left out of 1.18 beta release (because of follow-up?). Please submit either this or the follow-up r101420.

#Comment by Krinkle (talk | contribs)   22:56, 7 November 2011

It is already tagged as 1.18, it is scheduled to be applied to 1.18. It apparently didn't get into the first beta but unless a different decision is made this revision will make it into the second beta or eventually the stable release.

Status & tagging log