r101540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r101539‎ | r101540 | r101541 >
Date:22:08, 1 November 2011
Author:brion
Status:ok (Comments)
Tags:
Comment:
Bug 31933: fix 1.18 regression in Monobook sidebar: huge spacing between portlets on IE 7 and IE 8/9 in compatibility view.

Followup r74966: drop some lines ported from MonoBook's old rtl.css. The floats don't seem to be needed and were breaking IE 7. Also contained some IE-Mac-related code that seems unnecessary since we no longer support that ancient browser. :)

Tested in:
* Firefox 7 LTR <- no regression
* Firefox 7 RTL <- no regression
* IE 6 LTR <- no regression
* IE 6 RTL <- no regression
* IE 7 LTR <- fixes regression
* IE 7 RTL <- no regression
* IE 8 regular LTR <- no regression
* IE 8 regular LTR <- no regression
* IE 8 regular RTL <- no regression
* IE 8 compatibility LTR <- fixes regression
* IE 8 compatibility RTL <- no regression
* IE 9 regular LTR <- no regression
* IE 9 regular RTL <- no regression
* IE 9 compatibility mode LTR <- fixes regression
* IE 9 compatibility mode RTL <- no regression
Modified paths:
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -241,15 +241,6 @@
242242 width: 11.6em;
243243 overflow: hidden;
244244 }
245 -html > body .portlet {
246 - float: left;
247 - clear: left;
248 -}
249 -/* recover IEMac (might be fine with the float, but usually it's close to IE */
250 -*>body .portlet {
251 - float: none;
252 - clear: none;
253 -}
254245 .portlet h4 {
255246 font-size: 95%;
256247 font-weight: normal;

Follow-up revisions

RevisionCommit summaryAuthorDate
r102534REL1_18 r101540, r101666, r101860, r101990reedy17:10, 9 November 2011
r1025931.18wmf1 MFT r101417, r101420, r101540reedy23:05, 9 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74966First shot at porting Monobook to Vector. The only non-straightforward part i...catrope20:35, 18 October 2010

Comments

#Comment by Brion VIBBER (talk | contribs)   22:10, 1 November 2011

Marking for 1.18 merge & deploy -- fixes regression on Monobook skin in IE 7 (and IE 8 and 9 if stuck in compatibility view).

#Comment by Brion VIBBER (talk | contribs)   22:11, 1 November 2011

bug 31993, not 31933. :P

Status & tagging log