r102593 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r102592‎ | r102593 | r102594 >
Date:23:05, 9 November 2011
Author:reedy
Status:ok
Tags:
Comment:
1.18wmf1 MFT r101417, r101420, r101540
Modified paths:
  • /branches/wmf/1.18wmf1 (modified) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/jquery.tablesorter.js (modified) (history)
  • /branches/wmf/1.18wmf1/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/resources/jquery/jquery.tablesorter.js
@@ -229,7 +229,7 @@
230230 * @param $table jQuery object for a <table>
231231 */
232232 function emulateTHeadAndFoot( $table ) {
233 - var $rows = $table.find( 'tr' );
 233+ var $rows = $table.find( '> tbody > tr' );
234234 if( !$table.get(0).tHead ) {
235235 var $thead = $( '<thead>' );
236236 $rows.each( function() {
@@ -269,7 +269,7 @@
270270 });
271271 $tableHeaders = $( longest );
272272 }
273 - $tableHeaders = $tableHeaders.find( 'th' ).each( function( index ) {
 273+ $tableHeaders = $tableHeaders.children( 'th' ).each( function( index ) {
274274 this.column = realCellIndex;
275275
276276 var colspan = this.colspan;
@@ -441,13 +441,13 @@
442442
443443 function explodeRowspans( $table ) {
444444 // Split multi row cells into multiple cells with the same content
445 - $table.find( 'tbody [rowspan]' ).each(function() {
 445+ $table.find( '> tbody > tr > [rowspan]' ).each(function() {
446446 var rowSpan = this.rowSpan;
447447 this.rowSpan = 1;
448448 var cell = $( this );
449449 var next = cell.parent().nextAll();
450450 for ( var i = 0; i < rowSpan - 1; i++ ) {
451 - var td = next.eq( i ).find( 'td' );
 451+ var td = next.eq( i ).children( 'td' );
452452 if ( !td.length ) {
453453 next.eq( i ).append( cell.clone() );
454454 } else if ( this.cellIndex === 0 ) {
@@ -598,10 +598,10 @@
599599 // Legacy fix of .sortbottoms
600600 // Wrap them inside inside a tfoot (because that's what they actually want to be) &
601601 // and put the <tfoot> at the end of the <table>
602 - var $sortbottoms = $table.find( 'tr.sortbottom' );
 602+ var $sortbottoms = $table.find( '> tbody > tr.sortbottom' );
603603 if ( $sortbottoms.length ) {
604 - var $tfoot = $table.find( 'tfoot' );
605 - if( $tfoot.length ) {
 604+ var $tfoot = $table.children( 'tfoot' );
 605+ if ( $tfoot.length ) {
606606 $tfoot.eq(0).prepend( $sortbottoms );
607607 } else {
608608 $table.append( $( '<tfoot>' ).append( $sortbottoms ) )
Index: branches/wmf/1.18wmf1/skins/monobook/main.css
@@ -572,15 +572,6 @@
573573 width: 11.6em;
574574 overflow: hidden;
575575 }
576 -html > body .portlet {
577 - float: left;
578 - clear: left;
579 -}
580 -/* recover IEMac (might be fine with the float, but usually it's close to IE */
581 -*>body .portlet {
582 - float: none;
583 - clear: none;
584 -}
585576 .portlet h4 {
586577 font-size: 95%;
587578 font-weight: normal;
Property changes on: branches/wmf/1.18wmf1
___________________________________________________________________
Modified: svn:mergeinfo
588579 Merged /trunk/phase3:r101417,101420,101540

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r101417jquery.tablesorter: Selector fixes...krinkle22:12, 31 October 2011
r101420jquery.tablesorter: More selector fixes...krinkle22:20, 31 October 2011
r101540Bug 31933: fix 1.18 regression in Monobook sidebar: huge spacing between port...brion22:08, 1 November 2011

Status & tagging log