r98607 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98606‎ | r98607 | r98608 >
Date:05:25, 1 October 2011
Author:aaron
Status:ok
Tags:
Comment:
Fixed loadParameters() to allow for no input IP
Modified paths:
  • /trunk/extensions/GlobalBlocking/SpecialGlobalBlockList.php (modified) (history)

Diff [purge]

Index: trunk/extensions/GlobalBlocking/SpecialGlobalBlockList.php
@@ -105,7 +105,10 @@
106106 }
107107
108108 function loadParameters( $ip ) {
109 - $this->mSearchIP = Block::normaliseRange( trim( $ip ) );
 109+ $ip = trim( $ip );
 110+ $this->mSearchIP = ( $ip !== '' )
 111+ ? Block::normaliseRange( $ip )
 112+ : '';
110113 }
111114 }
112115

Follow-up revisions

RevisionCommit summaryAuthorDate
r98608MFT r98607aaron05:26, 1 October 2011
r100842REL1_18 MFT r98607, r99897, r100092reedy18:56, 26 October 2011

Status & tagging log