r99371 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99370‎ | r99371 | r99372 >
Date:19:54, 9 October 2011
Author:dantman
Status:ok
Tags:
Comment:
Followup r98212; Ensure that true is passed to all uses of SkinTemplateToolboxEnd where we use getToolbox while they haven't been migrated to use getSidebar.
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -305,7 +305,7 @@
306306 <?php
307307 endforeach;
308308 if ( $hook !== null ) {
309 - wfRunHooks( $hook, array( &$this ) );
 309+ wfRunHooks( $hook, array( &$this, true ) );
310310 }
311311 ?>
312312 </ul>
Index: trunk/phase3/skins/MonoBook.php
@@ -242,7 +242,7 @@
243243 <?php
244244 }
245245 wfRunHooks( 'MonoBookTemplateToolboxEnd', array( &$this ) );
246 - wfRunHooks( 'SkinTemplateToolboxEnd', array( &$this ) );
 246+ wfRunHooks( 'SkinTemplateToolboxEnd', array( &$this, true ) );
247247 ?>
248248 </ul>
249249 </div>

Sign-offs

UserFlagDate
Nikerabbitinspected17:12, 11 October 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r100840REL1_18: MFT r98426, r99371, r99632, r99897, r99910, r99914, r999952reedy18:47, 26 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98212Followup r98210; Add an ugly hack to support old extensions using the SkinTem...dantman07:58, 27 September 2011

Status & tagging log