r100842 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r100841‎ | r100842 | r100843 >
Date:18:56, 26 October 2011
Author:reedy
Status:ok
Tags:
Comment:
REL1_18 MFT r98607, r99897, r100092
Modified paths:
  • /branches/REL1_18/extensions (modified) (history)
  • /branches/REL1_18/extensions/CodeReview (modified) (history)
  • /branches/REL1_18/extensions/CodeReview/modules/ext.codereview.js (modified) (history)
  • /branches/REL1_18/extensions/GlobalBlocking/GlobalBlocking.i18n.php (modified) (history)
  • /branches/REL1_18/extensions/GlobalBlocking/SpecialGlobalBlock.php (modified) (history)
  • /branches/REL1_18/extensions/GlobalBlocking/SpecialGlobalBlockList.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/extensions/GlobalBlocking/SpecialGlobalBlock.php
@@ -181,7 +181,7 @@
182182 $fields = array ();
183183
184184 // Who to block
185 - $fields['ipaddress'] =
 185+ $fields['globalblocking-ipaddress'] =
186186 Xml::input( 'wpAddress',
187187 45,
188188 $this->mAddress,
@@ -246,7 +246,7 @@
247247 // Block all users, or just anonymous ones
248248 $fields['globalblocking-block-options'] =
249249 Xml::checkLabel(
250 - wfMsg( 'ipbanononly' ),
 250+ wfMsg( 'globalblocking-ipbanononly' ),
251251 'wpAnonOnly',
252252 'mw-globalblock-anon-only',
253253 $this->mAnonOnly
Index: branches/REL1_18/extensions/GlobalBlocking/GlobalBlocking.i18n.php
@@ -30,6 +30,8 @@
3131 'globalblocking-block-expiry-otherfield' => 'Other time:',
3232 'globalblocking-block-legend' => 'Block an IP address globally',
3333 'globalblocking-block-options' => 'Options:',
 34+ 'globalblocking-ipaddress' => 'IP address:',
 35+ 'globalblocking-ipbanononly' => 'Block anonymous users only',
3436 'globalblocking-block-errors' => "Your block was unsuccessful, for the following {{PLURAL:$1|reason|reasons}}:",
3537 'globalblocking-block-ipinvalid' => 'The IP address ($1) you entered is invalid.
3638 Please note that you cannot enter a user name!',
Index: branches/REL1_18/extensions/GlobalBlocking/SpecialGlobalBlockList.php
@@ -105,7 +105,10 @@
106106 }
107107
108108 function loadParameters( $ip ) {
109 - $this->mSearchIP = Block::normaliseRange( trim( $ip ) );
 109+ $ip = trim( $ip );
 110+ $this->mSearchIP = ( $ip !== '' )
 111+ ? Block::normaliseRange( $ip )
 112+ : '';
110113 }
111114 }
112115
Index: branches/REL1_18/extensions/CodeReview/modules/ext.codereview.js
@@ -26,7 +26,7 @@
2727 good = false;
2828 }
2929 }
30 - if( good && tags[i].indexOf( lastTag ) != -1 ){
 30+ if( good && ('' + tags[i]).indexOf( lastTag ) != -1 ){
3131 suggestions.push( doneTags + tags[i] );
3232 }
3333 }
Property changes on: branches/REL1_18/extensions/CodeReview
___________________________________________________________________
Modified: svn:mergeinfo
3434 Merged /trunk/extensions/CodeReview:r100092
Property changes on: branches/REL1_18/extensions
___________________________________________________________________
Modified: svn:mergeinfo
3535 Merged /trunk/extensions:r98607,99897,100092

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98607Fixed loadParameters() to allow for no input IPaaron05:25, 1 October 2011
r99897(bug 31361) broken messages on Special:GlobalBlock.happy-melon17:59, 15 October 2011
r100092ext.codereview.js: Fix bug 31785...krinkle22:35, 17 October 2011

Status & tagging log