r100092 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r100091‎ \| r100092 \| r100093 >
Date:	22:35, 17 October 2011
Author:	krinkle
Status:	ok
Tags:
Comment:	ext.codereview.js: Fix bug 31785 * indexOf prototype does not exist on the Number object. Convert to string before calling indexOf. * (bug 31785) ext.codereview.js should ensure type string before calling indexOf (Uncaught TypeError)
Modified paths:	/trunk/extensions/CodeReview/modules/ext.codereview.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/modules/ext.codereview.js
—	—	@@ -26,7 +26,7 @@
27	27	good = false;
28	28	}
29	29	}
30		~~- if( good && tags[i].indexOf( lastTag ) != -1 ){~~
	30	+ if( good && ('' + tags[i]).indexOf( lastTag ) != -1 ){
31	31	suggestions.push( doneTags + tags[i] );
32	32	}
33	33	}

Revision	Commit summary	Author	Date
r100760	1.18wmf1 MFT r100092, r100419, r100686, r100692	reedy	23:08, 25 October 2011
r100842	REL1_18 MFT r98607, r99897, r100092	reedy	18:56, 26 October 2011

18:55, 26 October 2011 Reedy (talk | contribs) changed the tags for r100092 [removed: 1.18]
23:10, 25 October 2011 Reedy (talk | contribs) changed the tags for r100092 []
23:08, 25 October 2011 Reedy (talk | contribs) changed the tags for r100092 [removed: 1.18wmf1]
22:58, 25 October 2011 Reedy (talk | contribs) changed the status of r100092 [removed: new added: ok]
22:40, 17 October 2011 Krinkle (talk | contribs) changed the tags for r100092 [added: 1.18,1.18wmf1]