r85354 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85353‎ | r85354 | r85355 >
Date:18:25, 4 April 2011
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Modified paths:
  • /branches/REL1_17/phase3 (modified) (history)
  • /branches/REL1_17/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_17/phase3/docs/distributors.txt (modified) (history)
  • /branches/REL1_17/phase3/includes/DefaultSettings.php (modified) (history)
  • /branches/REL1_17/phase3/includes/ImageGallery.php (modified) (history)
  • /branches/REL1_17/phase3/includes/Linker.php (modified) (history)
  • /branches/REL1_17/phase3/includes/OutputPage.php (modified) (history)
  • /branches/REL1_17/phase3/includes/PrefixSearch.php (modified) (history)
  • /branches/REL1_17/phase3/includes/Title.php (modified) (history)
  • /branches/REL1_17/phase3/includes/Wiki.php (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiEmailUser.php (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiQueryAllpages.php (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiQueryBase.php (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiQueryCategoryMembers.php (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiQueryFilearchive.php (modified) (history)
  • /branches/REL1_17/phase3/includes/api/ApiQueryUsers.php (modified) (history)
  • /branches/REL1_17/phase3/includes/filerepo/File.php (modified) (history)
  • /branches/REL1_17/phase3/includes/filerepo/ForeignDBFile.php (modified) (history)
  • /branches/REL1_17/phase3/includes/filerepo/LocalFile.php (modified) (history)
  • /branches/REL1_17/phase3/includes/media/Generic.php (modified) (history)
  • /branches/REL1_17/phase3/includes/media/SVGMetadataExtractor.php (modified) (history)
  • /branches/REL1_17/phase3/includes/parser/Parser.php (modified) (history)
  • /branches/REL1_17/phase3/includes/parser/ParserCache.php (modified) (history)
  • /branches/REL1_17/phase3/includes/specials/SpecialEmailuser.php (modified) (history)
  • /branches/REL1_17/phase3/includes/specials/SpecialIpblocklist.php (modified) (history)
  • /branches/REL1_17/phase3/includes/specials/SpecialProtectedpages.php (modified) (history)
  • /branches/REL1_17/phase3/languages/LanguageConverter.php (modified) (history)
  • /branches/REL1_17/phase3/languages/classes/LanguageFi.php (modified) (history)
  • /branches/REL1_17/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /branches/REL1_17/phase3/languages/messages/MessagesPt.php (modified) (history)
  • /branches/REL1_17/phase3/languages/messages/MessagesSh.php (modified) (history)
  • /branches/REL1_17/phase3/languages/messages/MessagesSl.php (modified) (history)
  • /branches/REL1_17/phase3/maintenance/oracle/archives/patch_16_17_schema_changes.sql (modified) (history)
  • /branches/REL1_17/phase3/maintenance/oracle/tables.sql (modified) (history)
  • /branches/REL1_17/phase3/resources/jquery.tipsy/images/tipsy.png (modified) (history)
  • /branches/REL1_17/phase3/resources/jquery.tipsy/jquery.tipsy.css (modified) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-disabled-blue.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-disabled-green.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-disabled-red.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-down-blue.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-down-green.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-down-red.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-off-blue.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-off-green.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-off-red.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-over-blue.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-over-green.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/images/button-over-red.png (added) (history)
  • /branches/REL1_17/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css (modified) (history)
  • /branches/REL1_17/phase3/resources/jquery/jquery.placeholder.js (modified) (history)
  • /branches/REL1_17/phase3/resources/jquery/jquery.textSelection.js (modified) (history)
  • /branches/REL1_17/phase3/resources/mediawiki.util/mediawiki.util.js (modified) (history)
  • /branches/REL1_17/phase3/resources/mediawiki/mediawiki.js (modified) (history)
  • /branches/REL1_17/phase3/skins/common/commonPrint.css (modified) (history)
  • /branches/REL1_17/phase3/skins/common/shared.css (modified) (history)
  • /branches/REL1_17/phase3/skins/common/wikibits.js (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r85399Follow-up r85354: back out part of r81524 which somehow got caught up in the ...happy-melon23:53, 4 April 2011
r85433Followup r85354: fix RELEASE-NOTESdemon13:11, 5 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82518(bug 27468) Move private styles out to their own section, so they override ev...catrope17:24, 20 February 2011
r82530(bug 27355) Guard against context being null, this happens when wikiEditor di...catrope19:27, 20 February 2011
r82538Gallery's perrow was overwriting the original style= attribute.hartman21:31, 20 February 2011
r82547Add basic linktrail to SH and SLreedy13:33, 21 February 2011
r82550Rewrote LanguageConverter::autoConvert() to make it use preg_match() with an ...tstarling14:17, 21 February 2011
r82565Per Hashar on r82547, u modifier needed on regexesreedy19:02, 21 February 2011
r82572Follow-up r73270. Moving the attribute check down to the point where it's for...krinkle20:36, 21 February 2011
r82608* (bug 27633) Add characters to linkTrail for Potuguese (pt and pt-br)...reedy15:33, 22 February 2011
r82696(Bug #27634) TOC title appears in wrong language...mah20:32, 23 February 2011
r82748Removed white-background from ul.gallery; Updated commonPrint gallery styles...krinkle21:16, 24 February 2011
r82836Fix bug that caused "Non-string key given" exception....nikerabbit08:19, 26 February 2011
r82853(bug 27700) The upload protection can now also be set for files that do not e...btongminh13:51, 26 February 2011
r82858Follow-up r82853: Filter out create restriction from SpecialProtectedPages an...btongminh16:29, 26 February 2011
r82871Updated distributors docs....platonides22:53, 26 February 2011
r82938Consisten wording as requested by Der Umherirrende, see:...purodha16:35, 28 February 2011
r83005* fixed INDEX change (i missed that one)freakolowsky07:40, 1 March 2011
r83015ActiveAbstracts needs translate (used in abstracts production for xml dumps, ...ariel13:36, 1 March 2011
r83046* (bug 27761) Fix regression: pages with Esperanto titles containing converti...brion21:20, 1 March 2011
r83114Revert r69907, r69908, r70264, r70296: introduces bug 27477....btongminh21:06, 2 March 2011
r83153Merge r83152 from 1.17wmf1 to trunkcatrope18:04, 3 March 2011
r83173Optionally disable including mediawiki.legacy (wikibits.js) module.happy-melon21:40, 3 March 2011
r83270(bug 27862; follow-up r77714) Make emailuser api module not freak out when Sp...bawolff03:35, 5 March 2011
r83284Fixed (bug 27848) Escape '-' in $.escapeRE()krinkle14:46, 5 March 2011
r83374(bug 27508) SVGMetadataExtractor takes too much resources on huge svg's. Chan...bawolff08:15, 6 March 2011
r83390* (bug 27897) list=allusers and list=users list hidden users...reedy17:59, 6 March 2011
r83392Followup r83390, change cache modesreedy18:16, 6 March 2011
r83402Fix where ipb_deleted from r83390reedy20:38, 6 March 2011
r83403Followup r83390...reedy20:51, 6 March 2011
r83410Breaking change: remove faminsize/famaxsize because they lead to an unindexed...btongminh22:03, 6 March 2011
r83411Kill filtering by hash because the query is unindexed. We need a condition on...btongminh22:16, 6 March 2011
r83420Fix for IE7, jQuery magic doesn't help here, it needs to be valid html, short...krinkle23:25, 6 March 2011
r83461(bug 27722) list=filearchive now supports revdel...btongminh17:07, 7 March 2011
r83463Follow-up r83461, replace deleted with hidden and reverse the word, e.g. dele...btongminh17:17, 7 March 2011
r83476Merge corrected r81741 and resolve the TODO....platonides19:13, 7 March 2011
r83489Fix r83390, need to do where ipb_deleted IS NULL as we're left joining in the...reedy22:58, 7 March 2011
r83496* Increased the size of the tipsy callout, removed the shadow and made the ba...tparscal02:02, 8 March 2011
r83586(bug 27944) Search placeholder was inserted even when the search box was alre...catrope13:54, 9 March 2011
r83587Fix r83586 (drag and drop support for placeholder plugin) to work in IE, whos...catrope14:27, 9 March 2011
r83798(bug 28017) Unblocking a user with a space in their name does not work. This...happy-melon23:54, 12 March 2011
r83814(bug 27965) Paging in list=categorymembers was completely broken. It was pagi...catrope10:39, 13 March 2011
r83876Revert r67661 (change Title::makeTitle(NS_SPECIAL, $foo) to SpecialPage::getT...catrope10:03, 14 March 2011

Comments

#Comment by Bryan (talk | contribs)   08:25, 5 April 2011
+* ([https://bugzilla.wikimedia.org/show_bug.cgi?id=27018 bug 27018]) Added action=filerevert to revert files to an old version

Is not in 1.17.

#Comment by 😂 (talk | contribs)   12:31, 5 April 2011

Do you mean it should be and I missed it, or that I botched the REL-NOTES merge?

#Comment by Bryan (talk | contribs)   12:53, 5 April 2011

You botched RELEASE-NOTES.

Status & tagging log