r83489 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r83488‎ | r83489 | r83490 >
Date:22:58, 7 March 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix r83390, need to do where ipb_deleted IS NULL as we're left joining in the table, so it can be null

Duh
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBase.php
——@@ -491,7 +491,7 @@
492492
493493 // Don't show hidden names
494494 if ( !$userCanViewHiddenUsers ) {
495 - $this->addWhereFld( 'ipb_deleted', 0 );
 495+ $this->addWhere( 'ipb_deleted = 0 OR ipb_deleted IS NULL' );
496496 }
497497 }
498498 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r83490MFT r83489reedy23:02, 7 March 2011
r85354MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, r...demon18:25, 4 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r83390* (bug 27897) list=allusers and list=users list hidden users...reedy17:59, 6 March 2011

Status & tagging log