r85399 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85398‎ | r85399 | r85400 >
Date:23:53, 4 April 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Follow-up r85354: back out part of r81524 which somehow got caught up in the merge and caused fatals on every page view.
Modified paths:
  • /branches/REL1_17/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/includes/OutputPage.php
@@ -2376,15 +2376,6 @@
23772377 $resourceLoader = $this->getResourceLoader();
23782378 foreach ( (array) $modules as $name ) {
23792379 $module = $resourceLoader->getModule( $name );
2380 - # Check that we're allowed to include this module on this page
2381 - if ( ( $module->getOrigin() > $this->getAllowedModules( ResourceLoaderModule::TYPE_SCRIPTS )
2382 - && $only == ResourceLoaderModule::TYPE_SCRIPTS )
2383 - || ( $module->getOrigin() > $this->getAllowedModules( ResourceLoaderModule::TYPE_STYLES )
2384 - && $only == ResourceLoaderModule::TYPE_STYLES )
2385 - )
2386 - {
2387 - continue;
2388 - }
23892380
23902381 $group = $module->getGroup();
23912382 if ( !isset( $groups[$group] ) ) {
@@ -2728,8 +2719,8 @@
27292720 // 'private' at present only contains user.options, so put that before 'user'
27302721 // Any future private modules will likely have a similar user-specific character
27312722 foreach ( array( 'site', 'private', 'user' ) as $group ) {
2732 - $ret .= $this->makeResourceLoaderLink( $sk, $styles[$group],
2733 - ResourceLoaderModule::TYPE_STYLES
 2723+ $ret .= $this->makeResourceLoaderLink(
 2724+ $sk, array_merge( $styles['site'], $styles['user'] ), 'styles'
27342725 );
27352726 }
27362727 return $ret;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r81524Follow-up r64670 (bug22929): cleaner implementation of security for script (a...happy-melon16:39, 4 February 2011
r85354MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, r...demon18:25, 4 April 2011

Status & tagging log