r82836 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82835‎ | r82836 | r82837 >
Date:08:19, 26 February 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Fix bug that caused "Non-string key given" exception.
Broken since introducsed in r10810 almost six years ago.
This proves that the exception in message caches is valid and covers errors.
Tested that exception is no longer thrown.
Modified paths:
  • /trunk/phase3/languages/classes/LanguageFi.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/classes/LanguageFi.php
——@@ -118,7 +118,7 @@
119119 if ( !is_numeric( $item ) ) {
120120 if ( count ( explode( '-', $item ) ) == 3 && strlen( $item ) == 10 ) {
121121 list( $yyyy, $mm, $dd ) = explode( '-', $item );
122 - $final .= ' ' . $this->date( "{$yyyy}{$mm}{$dd}00000000" );
 122+ $final .= ' ' . $this->date( "{$yyyy}{$mm}{$dd}000000" );
123123 continue;
124124 }
125125 if ( isset( $weekds[$item] ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r831541.17wmf1: MFT r82836, r82853, r82858, r83114catrope18:19, 3 March 2011
r85354MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, r...demon18:25, 4 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r10810+* Experimental feature to allow translation of block expiry timesnikerabbit16:35, 27 August 2005

Comments

#Comment by Nikerabbit (talk | contribs)   11:23, 26 February 2011

Oh my, so many typos in the commit message.

Status & tagging log