r83284 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83283‎ | r83284 | r83285 >
Date:14:46, 5 March 2011
Author:krinkle
Status:ok
Tags:
Comment:
Fixed (bug 27848) Escape '-' in $.escapeRE()
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -14,7 +14,7 @@
1515 return str.substr( 0, 1 ).toUpperCase() + str.substr( 1, str.length );
1616 },
1717 escapeRE : function( str ) {
18 - return str.replace ( /([\\{}()|.?*+^$\[\]])/g, "\\$1" );
 18+ return str.replace ( /([\\{}()\|.?*+-^$\[\]])/g, "\\$1" );
1919 },
2020 // $.isDomElement( document.getElementById('content') ) === true
2121 // $.isDomElement( document.getElementsByClassName('portal') ) === false (array)

Follow-up revisions

RevisionCommit summaryAuthorDate
r83287Follow-up r83284. Fixing JSLint warnings: No need to escape a pipe (|) but a ...krinkle14:56, 5 March 2011
r834871.17wmf1: MFT r82696, r83270, r83284, r83374, r83390, r83392, r83402, r83403,...catrope21:44, 7 March 2011
r83610Escape minus in $.escapeRE...krinkle21:50, 9 March 2011
r85354MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, r...demon18:25, 4 April 2011

Status & tagging log