r82547 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82546‎ | r82547 | r82548 >
Date:13:33, 21 February 2011
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Add basic linktrail to SH and SL
Modified paths:
  • /trunk/phase3/languages/messages/MessagesSh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSl.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesSh.php
——@@ -26,6 +26,8 @@
2727 NS_CATEGORY_TALK => 'Razgovor_o_kategoriji',
2828 );
2929
 30+$linkTrail = '/^([a-zčćđžš]+)(.*)$/sD';
 31+
3032 $messages = array(
3133 # User preference toggles
3234 'tog-underline' => 'Podvuci linkove:',
Index: trunk/phase3/languages/messages/MessagesSl.php
——@@ -152,6 +152,8 @@
153153 'url_query' => array( '0', 'POIZVEDBA', 'QUERY' ),
154154 );
155155
 156+$linkTrail = '/^([a-zčćđžš]+)(.*)$/sD';
 157+
156158 $datePreferences = array(
157159 'default',
158160 'dmy short',

Follow-up revisions

RevisionCommit summaryAuthorDate
r82565Per Hashar on r82547, u modifier needed on regexesreedy19:02, 21 February 2011
r825761.17wmf1: MFT r82475, r82480, r82538, r82547, r82550, r82552, r82554, r82555,...catrope21:37, 21 February 2011
r82608* (bug 27633) Add characters to linkTrail for Potuguese (pt and pt-br)...reedy15:33, 22 February 2011
r85354MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, r...demon18:25, 4 April 2011

Comments

#Comment by Hashar (talk | contribs)   18:23, 21 February 2011

Others linktrails also have the 'u' PCRE modifier:

This modifier turns on additional functionality of PCRE that is incompatible with Perl. Pattern strings are treated as UTF-8. This modifier is available from PHP 4.1.0 or greater on Unix and from PHP 4.2.3 on win32. UTF-8 validity of the pattern is checked since PHP 4.3.5.

It is probably needed there.

#Comment by Reedy (talk | contribs)   18:25, 21 February 2011

I obviously copied it from one that doesn't. I'll fix that one up aswell and check the others.

I think it may have been from en, which I suppose doesnt need it...

#Comment by Reedy (talk | contribs)   18:58, 21 February 2011 
$linkTrail = '/^([a-z]+)(.*)$/sD';

is the en one. I think that's what I copied...

Status & tagging log