r82538 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82537‎ | r82538 | r82539 >
Date:21:31, 20 February 2011
Author:hartman
Status:ok
Tags:
Comment:
Gallery's perrow was overwriting the original style= attribute.
Modified paths:
  • /trunk/phase3/includes/ImageGallery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImageGallery.php
@@ -227,7 +227,8 @@
228228
229229 if ( $this->mPerRow > 0 ) {
230230 $maxwidth = $this->mPerRow * ( $this->mWidths + 50 );
231 - $this->mAttribs['style'] = "max-width: {$maxwidth}px;_width: {$maxwidth}px;";
 231+ $oldStyle = isset( $this->mAttribs['style'] ) ? $this->mAttribs['style'] : "";
 232+ $this->mAttribs['style'] = "max-width: {$maxwidth}px;_width: {$maxwidth}px;" . $oldStyle;
232233 }
233234
234235 $attribs = Sanitizer::mergeAttributes(

Follow-up revisions

RevisionCommit summaryAuthorDate
r825761.17wmf1: MFT r82475, r82480, r82538, r82547, r82550, r82552, r82554, r82555,...catrope21:37, 21 February 2011
r85354MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, r...demon18:25, 4 April 2011

Status & tagging log