r83496 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83495‎ | r83496 | r83497 >
Date:02:02, 8 March 2011
Author:tparscal
Status:ok
Tags:
Comment:
* Increased the size of the tipsy callout, removed the shadow and made the background of tips white to try and improve the visibility of tips.
* Added ui-button-green, ui-button-blue, ui-button-red classes to the Vector jquery ui theme
Modified paths:
  • /trunk/phase3/resources/jquery.tipsy/images/tipsy.png (modified) (history)
  • /trunk/phase3/resources/jquery.tipsy/jquery.tipsy.css (modified) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-blue.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-green.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-red.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-blue.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-green.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-red.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-blue.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-green.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-red.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-blue.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-green.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-red.png (added) (history)
  • /trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery.tipsy/images/tipsy.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: trunk/phase3/resources/jquery.tipsy/jquery.tipsy.css
@@ -6,31 +6,34 @@
77 }
88 .tipsy-inner {
99 padding: 5px 8px 4px 8px;
10 - background-color: #e8f2f8;
 10+ /*background-color: #e8f2f8;*/
 11+ background-color: #ffffff;
1112 border: solid 1px #a7d7f9;
1213 color: black;
1314 max-width: 15em;
1415 text-align: left;
15 - border-radius: 3px;
16 - -moz-border-radius: 3px;
17 - -webkit-border-radius: 3px;
 16+ border-radius: 4px;
 17+ -moz-border-radius: 4px;
 18+ -webkit-border-radius: 4px;
 19+ /*
1820 -moz-box-shadow: 0px 2px 8px #cccccc;
1921 -webkit-box-shadow: 0px 2px 8px #cccccc;
2022 box-shadow: 0px 2px 8px #cccccc;
2123 -ms-filter: "progid:DXImageTransform.Microsoft.DropShadow(OffX=0, OffY=2, Strength=6, Direction=90, Color='#cccccc')";
2224 filter: progid:DXImageTransform.Microsoft.DropShadow(OffX=0, OffY=2, Strength=6, Direction=90, Color='#cccccc');
 25+ */
2326 }
2427 .tipsy-arrow {
2528 position: absolute;
2629 /* @embed */
2730 background: url('images/tipsy.png') no-repeat top left;
28 - width: 9px;
29 - height: 5px;
 31+ width: 11px;
 32+ height: 6px;
3033 }
3134 .tipsy-n .tipsy-arrow {
32 - top: 1px;
 35+ top: 0px;
3336 left: 50%;
34 - margin-left: -4px;
 37+ margin-left: -5px;
3538 }
3639 .tipsy-nw .tipsy-arrow {
3740 top: 1px;
@@ -41,33 +44,33 @@
4245 right: 10px;
4346 }
4447 .tipsy-s .tipsy-arrow {
45 - bottom: 1px;
 48+ bottom: 0px;
4649 left: 50%;
47 - margin-left: -4px;
 50+ margin-left: -5px;
4851 background-position: bottom left;
4952 }
5053 .tipsy-sw .tipsy-arrow {
51 - bottom: 1px;
 54+ bottom: 0px;
5255 left: 10px;
5356 background-position: bottom left;
5457 }
5558 .tipsy-se .tipsy-arrow {
56 - bottom: 1px;
 59+ bottom: 0px;
5760 right: 10px;
5861 background-position: bottom left;
5962 }
6063 .tipsy-e .tipsy-arrow {
6164 top: 50%;
62 - margin-top: -4px;
 65+ margin-top: -5px;
6366 right: 1px;
6467 width: 5px;
65 - height: 9px;
 68+ height: 11px;
6669 background-position: top right;
6770 }
6871 .tipsy-w .tipsy-arrow {
6972 top: 50%;
70 - margin-top: -4px;
71 - left: 1px;
72 - width: 5px;
73 - height: 9px;
 73+ margin-top: -5px;
 74+ left: 0px;
 75+ width: 6px;
 76+ height: 11px;
7477 }
\ No newline at end of file
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-red.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-red.png
___________________________________________________________________
Added: svn:mime-type
7578 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-blue.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-blue.png
___________________________________________________________________
Added: svn:mime-type
7679 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-green.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-green.png
___________________________________________________________________
Added: svn:mime-type
7780 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-green.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-green.png
___________________________________________________________________
Added: svn:mime-type
7881 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-red.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-red.png
___________________________________________________________________
Added: svn:mime-type
7982 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-red.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-red.png
___________________________________________________________________
Added: svn:mime-type
8083 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-blue.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-blue.png
___________________________________________________________________
Added: svn:mime-type
8184 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-blue.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-blue.png
___________________________________________________________________
Added: svn:mime-type
8285 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-blue.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-over-blue.png
___________________________________________________________________
Added: svn:mime-type
8386 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-green.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-down-green.png
___________________________________________________________________
Added: svn:mime-type
8487 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-green.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-off-green.png
___________________________________________________________________
Added: svn:mime-type
8588 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-red.png
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Property changes on: trunk/phase3/resources/jquery.ui/themes/vector/images/button-disabled-red.png
___________________________________________________________________
Added: svn:mime-type
8689 + application/octet-stream
Index: trunk/phase3/resources/jquery.ui/themes/vector/jquery.ui.button.css
@@ -65,3 +65,79 @@
6666 border: 0;
6767 }
6868
 69+/* Green buttons */
 70+
 71+body button.ui-button.ui-button-green {
 72+ color: white;
 73+ border-color: #97af7e !important;
 74+ /* @embed */
 75+ background: #85c940 url(images/button-off-green.png) repeat-x scroll 50% 100% !important;
 76+}
 77+body button.ui-button.ui-button-green:hover {
 78+ border-color: #778e61;
 79+ /* @embed */
 80+ background: #77ad40 url(images/button-over-green.png) repeat-x scroll 50% 100% !important;
 81+}
 82+body button.ui-button.ui-button-green:active,
 83+body button.ui-button.ui-button-green:focus {
 84+ border-color: #61b000;
 85+ /* @embed */
 86+ background: #54a800 url(images/button-down-green.png) repeat-x scroll 50% 100% !important;
 87+}
 88+body button.ui-button.ui-button-green.disabled {
 89+ color: #7f7f7f;
 90+ border-color: #b8d29f;
 91+ /* @embed */
 92+ background: #c9cfc3 url(images/button-disabled-green.png) repeat-x scroll 50% 100% !important;
 93+}
 94+
 95+/* Blue buttons */
 96+
 97+body button.ui-button.ui-button-blue {
 98+ color: white;
 99+ border-color: #407ec9 !important;
 100+ /* @embed */
 101+ background: #407ec9 url(images/button-off-blue.png) repeat-x scroll 50% 100% !important;
 102+}
 103+body button.ui-button.ui-button-blue:hover {
 104+ border-color: #245289;
 105+ /* @embed */
 106+ background: #4071ad url(images/button-over-blue.png) repeat-x scroll 50% 100% !important;
 107+}
 108+body button.ui-button.ui-button-blue:active,
 109+body button.ui-button.ui-button-blue:focus {
 110+ border-color: #003980;
 111+ /* @embed */
 112+ background: #004daa url(images/button-down-blue.png) repeat-x scroll 50% 100% !important;
 113+}
 114+body button.ui-button.ui-button-blue.disabled {
 115+ border-color: #9eafc6;
 116+ /* @embed */
 117+ background: #c3c8cf url(images/button-disabled-blue.png) repeat-x scroll 50% 100% !important;
 118+}
 119+
 120+/* Red buttons */
 121+
 122+body button.ui-button.ui-button-red {
 123+ color: white;
 124+ border-color: #af977e !important;
 125+ /* @embed */
 126+ background: #c9404c url(images/button-off-red.png) repeat-x scroll 50% 100% !important;
 127+}
 128+body button.ui-button.ui-button-red:hover {
 129+ border-color: #8e7761;
 130+ /* @embed */
 131+ background: #ad404a url(images/button-over-red.png) repeat-x scroll 50% 100% !important;
 132+}
 133+body button.ui-button.ui-button-red:active,
 134+body button.ui-button.ui-button-red:focus {
 135+ border-color: #b06100;
 136+ /* @embed */
 137+ background: #aa000f url(images/button-down-red.png) repeat-x scroll 50% 100% !important;
 138+}
 139+body button.ui-button.ui-button-red.disabled {
 140+ color: #7f7f7f;
 141+ border-color: #c3acae;
 142+ /* @embed */
 143+ background: #cfc3c4 url(images/button-disabled-red.png) repeat-x scroll 50% 100% !important;
 144+}

Sign-offs

UserFlagDate
Krinkleinspected17:30, 9 March 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r839491.17wmf1: MFT r83496catrope19:18, 14 March 2011
r85354MFT r82518, r82530, r82538, r82547, r82550, r82565, r82572, r82608, r82696, r...demon18:25, 4 April 2011

Status & tagging log