r82413 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82412‎ | r82413 | r82414 >
Date:18:56, 18 February 2011
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
Remove named entities again

Repeat of r67090 to remove named entities that snuck back in since then,
using the same find/sed command as I gave in that commit summary. This
should be merged to 1.17 and the deployment branch to preserve
well-formedness, although the problems mostly seem to be in extensions
that people are unlikely to be accessing by AJAX anyway (except maybe
FlaggedRevs).

Reminder: as a general rule, since r68803, using any named entity other
than > < & " will cause XML well-formedness errors if
$wgHtml5 = true (the default). Either use the literal UTF-8 character,
or use a numeric entity (  works instead of  ). For  ,
in most cases you really don't need it at all -- stuff like
<td>&nbsp;</td> is pointless, just use <td></td> or <td> </td>.
Likewise, if you want spacing between two elements, you can use CSS
margins.
Modified paths:
  • /trunk/extensions/ContributionReporting/FundraiserStatistics_body.php (modified) (history)
  • /trunk/extensions/DSMW/DSMW.php (modified) (history)
  • /trunk/extensions/DSMW/files/utils.php (modified) (history)
  • /trunk/extensions/DSMW/specials/ArticleAdminPage.php (modified) (history)
  • /trunk/extensions/DSMW/tests/p2pTest3.php (modified) (history)
  • /trunk/extensions/Deployment/specials/SpecialInstall.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php (modified) (history)
  • /trunk/extensions/EmailPage/EmailPage_body.php (modified) (history)
  • /trunk/extensions/EmailPage/PHPMailer_v5.1/language/phpmailer.lang-fi.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /trunk/extensions/FolkTagCloud/FolkTagCloud.php (modified) (history)
  • /trunk/extensions/OpenStackManager/aws-sdk/_compatibility_test/sdk_compatibility_test.php (modified) (history)
  • /trunk/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)
  • /trunk/extensions/QrCode/phpqrcode/index.php (modified) (history)
  • /trunk/extensions/QrCode/phpqrcode/phpqrcode.php (modified) (history)
  • /trunk/extensions/QrCode/phpqrcode/qrspec.php (modified) (history)
  • /trunk/extensions/RDFIO/specials/SpecialSPARQLEndpoint_body.php (modified) (history)
  • /trunk/extensions/skins/p2wiki/P2wiki.skin.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Deployment/specials/SpecialInstall.php
@@ -138,11 +138,11 @@
139139 "<option value='tag'$tagSelected>" . htmlspecialchars( wfMsg( 'search-tag' ) ) . '</option>'
140140 );
141141
142 - $searchHtml .= '&nbsp;&nbsp;';
 142+ $searchHtml .= '&#160;&#160;';
143143
144144 $searchHtml .= Html::input( 'filtervalue', $value );
145145
146 - $searchHtml .= '&nbsp;&nbsp;';
 146+ $searchHtml .= '&#160;&#160;';
147147
148148 $searchHtml .= Html::input(
149149 '',
Index: trunk/extensions/OpenStackManager/aws-sdk/_compatibility_test/sdk_compatibility_test.php
@@ -346,7 +346,7 @@
347347 </div>
348348 <?php else: ?>
349349 <div class="chunk important error">
350 - <h3>Bottom Line: We're sorry&hellip;</h3>
 350+ <h3>Bottom Line: We're sorry…</h3>
351351 <p>Your PHP environment does not support the minimum requirements for the <strong>AWS SDK for PHP</strong>.</p>
352352 </div>
353353 <div class="chunk">
@@ -398,7 +398,7 @@
399399 <?php endif; ?>
400400
401401 <?php if (!$curl_ok): ?>
402 - <li><strong>cURL:</strong> The <a href="http://php.net/curl">cURL</a> extension is not available. Without cURL, the SDK cannot connect to &mdash; or authenticate with &mdash; Amazon's services.</li>
 402+ <li><strong>cURL:</strong> The <a href="http://php.net/curl">cURL</a> extension is not available. Without cURL, the SDK cannot connect to ― or authenticate with ― Amazon's services.</li>
403403 <?php endif; ?>
404404
405405 <?php if (!$simplexml_ok): ?>
@@ -425,7 +425,7 @@
426426 </div>
427427
428428 <div class="chunk">
429 - <p class="footnote"><strong>NOTE</strong>: Passing this test does not guarantee that the AWS SDK for PHP will run on your web server &mdash; it only ensures that the requirements have been addressed.</p>
 429+ <p class="footnote"><strong>NOTE</strong>: Passing this test does not guarantee that the AWS SDK for PHP will run on your web server ― it only ensures that the requirements have been addressed.</p>
430430 </div>
431431 </div>
432432
Index: trunk/extensions/RDFIO/specials/SpecialSPARQLEndpoint_body.php
@@ -897,9 +897,9 @@
898898 <input type="text" name="filtervocaburl" size="48" />
899899 </td></tr>
900900 <tr>
901 - <td>&nbsp;</td>
902 - <td>&nbsp;</td>
903 - <td>&nbsp;</td>
 901+ <td>&#160;</td>
 902+ <td>&#160;</td>
 903+ <td>&#160;</td>
904904 <td>
905905 <span style="font-family: arial, helvetica, sans-serif; font-size: 10px; color: #777">Example: http://xmlns.com/foaf/spec/index.rdf</span>
906906 </td></tr>
Index: trunk/extensions/ProofreadPage/ProofreadPage_body.php
@@ -1541,7 +1541,7 @@
15421542 $qe = $ne * 100 / $n;
15431543 $void_cell = $ne ? "<td align=center style='border-style:dotted;border-width:1px;' width=\"{$qe}\"></td>" : '';
15441544 $output = "<table class=\"pr_quality\" style=\"line-height:40%;\" border=0 cellpadding=0 cellspacing=0 ><tr>
1545 -<td align=center >&nbsp;</td>
 1545+<td align=center >&#160;</td>
15461546 <td align=center class='quality4' width=\"$q4\"></td>
15471547 <td align=center class='quality3' width=\"$q3\"></td>
15481548 <td align=center class='quality2' width=\"$q2\"></td>
Index: trunk/extensions/DSMW/DSMW.php
@@ -102,15 +102,15 @@
103103
104104 $wgExtensionCredits[defined( 'SEMANTIC_EXTENSION_TYPE' ) ? 'semantic' : 'other'][] = array(
105105 'path' => __FILE__,
106 - 'name' => 'Distributed&nbsp;Semantic&nbsp;MediaWiki',
 106+ 'name' => 'Distributed&#160;Semantic&#160;MediaWiki',
107107 'version' => DSMW_VERSION,
108108 'author' => array(
109 - '[http://www.loria.fr/~mullejea Jean&ndash;Philippe&nbsp;Muller]',
110 - '[http://www.loria.fr/~molli Pascal&nbsp;Molli]',
111 - '[http://www.loria.fr/~skaf Hala&nbsp;Skaf&ndash;Molli]',
112 - '[http://www.loria.fr/~canals Gérôme&nbsp;Canals]',
113 - '[http://www.loria.fr/~rahalcha Charbel&nbsp;Rahal]',
114 - '[http://www.loria.fr/~weiss Stéphane&nbsp;Weiss]',
 109+ '[http://www.loria.fr/~mullejea Jean–Philippe&#160;Muller]',
 110+ '[http://www.loria.fr/~molli Pascal&#160;Molli]',
 111+ '[http://www.loria.fr/~skaf Hala&#160;Skaf–Molli]',
 112+ '[http://www.loria.fr/~canals Gérôme&#160;Canals]',
 113+ '[http://www.loria.fr/~rahalcha Charbel&#160;Rahal]',
 114+ '[http://www.loria.fr/~weiss Stéphane&#160;Weiss]',
115115 '[http://m3p.gforge.inria.fr/pmwiki/pmwiki.php?n=Site.Team others]'
116116 ),
117117 'url' => 'http://www.dsmw.org',
Index: trunk/extensions/DSMW/tests/p2pTest3.php
@@ -154,7 +154,7 @@
155155 | valign='top' | <span style='color: red;'><em><del>line deleted</del></em></span>
156156 | valign='top' | <span style='c/home/mullejea/Bureau/www/mediawiki-1.14.0/extensions/DSMW/tests/p2pTest3.php:258olor: red;'><em><del>line deleted</del></em></span>
157157 | valign='top' | <span style='color: red;'><em><del>line deleted</del></em></span>
158 -| valign='top' | <ul><li>DSMW server1 and server2 delete the &ldquo;initial_line&rdquo;
 158+| valign='top' | <ul><li>DSMW server1 and server2 delete the “initial_line”
159159 </li></ul>
160160 |}
161161
Index: trunk/extensions/DSMW/files/utils.php
@@ -844,7 +844,7 @@
845845 foreach ( $props as $property ) {
846846
847847 if ( $property->isUserDefined() ) { // user defined property
848 - $property->setCaption( preg_replace( '/[ ]/u', '&nbsp;', $property->getWikiValue(), 2 ) );
 848+ $property->setCaption( preg_replace( '/[ ]/u', '&#160;', $property->getWikiValue(), 2 ) );
849849
850850 if ( $property->getWikiPageValue() != null ) {
851851 $obj = $property->getWikiPageValue();
Index: trunk/extensions/DSMW/specials/ArticleAdminPage.php
@@ -309,11 +309,11 @@
310310 </table>
311311 </FORM>
312312 <div id="pullstatus" style="display: none; width: 100%; clear: both;" >
313 -<a name="PULL_Progress_:" id="PULL_Progress_:"></a><h2> <span class="mw-headline"> PULL Progress&nbsp;: </span></h2>
 313+<a name="PULL_Progress_:" id="PULL_Progress_:"></a><h2> <span class="mw-headline"> PULL Progress&#160;: </span></h2>
314314 <div id="statepull" ></div><br />
315315 </div>
316316 <div id="pushstatus" style="display: none; width: 100%; clear: both;" >
317 -<a name="PUSH_Progress_:" id="PUSH_Progress_:"></a><h2> <span class="mw-headline"> PUSH Progress&nbsp;: </span></h2>
 317+<a name="PUSH_Progress_:" id="PUSH_Progress_:"></a><h2> <span class="mw-headline"> PUSH Progress&#160;: </span></h2>
318318 <div id="statepush" ></div><br />
319319 </div>
320320 ';
Index: trunk/extensions/FolkTagCloud/FolkTagCloud.php
@@ -251,7 +251,7 @@
252252 }
253253 # appending tag
254254 $currentRow = "<a style=\"{$style}\" {$url}>" . $label . $append .
255 - "</a>&nbsp; ";
 255+ "</a>&#160; ";
256256 $htmlOut = $htmlOut . $currentRow;
257257 }
258258 }
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php
@@ -250,9 +250,9 @@
251251 $form .= '<td>' .
252252 '<p style="border: 1px solid rgb(187, 187, 187); float: left; -moz-border-radius: 5px 5px 5px 5px; margin: 0 8px 0 0; padding: 5px 5px 5px 3px; white-space: nowrap;">'.
253253 Xml::radio( 'card', 'cc1', $this->form_data['card'] == 'cc1', array( 'id' => 'cc1radio', 'onclick' => 'switchToCreditCard()' ) ) . '<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-visa.png" ) ). '</label>' .
254 - '&nbsp;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-mastercard.png" ) ). '</label>' .
255 - '&nbsp;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-amex.png" ) ). '</label>' .
256 - '&nbsp;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-discover.png" ) ). '</label>' .
 254+ '&#160;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-mastercard.png" ) ). '</label>' .
 255+ '&#160;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-amex.png" ) ). '</label>' .
 256+ '&#160;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-discover.png" ) ). '</label>' .
257257 '</p>'.
258258 '<p style="border: 1px solid transparent; float: left; -moz-border-radius: 5px 5px 5px 5px; margin: 0; padding: 5px 5px 5px 3px; white-space: nowrap;">'.
259259 Xml::radio( 'card', 'pp', $this->form_data['card'] == 'pp', array( 'id' => 'ppradio', 'onclick' => 'switchToPayPal()' ) ) . '<label for="ppradio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-paypal.png" ) ) . '</label>' .
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php
@@ -118,7 +118,7 @@
119119 $form .= Html::hidden( 'PaypalRedirect', 0 );
120120 $form .= Xml::tags( 'div',
121121 array(),
122 - Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos2.gif" ) ) . '&nbsp;&nbsp;&nbsp;<a href="#" onclick="document.payment.PaypalRedirect.value=1;document.payment.submit();"><img src="' . $scriptPath . '/donate_with_paypal.gif"/></a>'
 122+ Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos2.gif" ) ) . '&#160;&#160;&#160;<a href="#" onclick="document.payment.PaypalRedirect.value=1;document.payment.submit();"><img src="' . $scriptPath . '/donate_with_paypal.gif"/></a>'
123123 );
124124 $form .= '</td>';
125125 $form .= '</tr>';
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php
@@ -173,7 +173,7 @@
174174 // submit button
175175 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
176176 // $form .= Xml::submitButton( wfMsg( 'payflowpro_gateway-submit-button' ));
177 - $form .= '&nbsp;<br/>' . Xml::element( 'input', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/submit-donation-button.png", 'alt' => 'Submit donation', 'type' => 'image' ) );
 177+ $form .= '&#160;<br/>' . Xml::element( 'input', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/submit-donation-button.png", 'alt' => 'Submit donation', 'type' => 'image' ) );
178178 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
179179 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
180180 Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/padlock.gif", 'style' => 'vertical-align:baseline;margin-right:4px;' ) ) . 'Your credit / debit card will be securely processed.';
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php
@@ -280,7 +280,7 @@
281281 // card logos
282282 $form .= '<tr>';
283283 $form .= '<td />';
284 - $form .= '<td>&nbsp;<br/>' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" ) ) . '</td>';
 284+ $form .= '<td>&#160;<br/>' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" ) ) . '</td>';
285285 $form .= '</tr>';
286286
287287 // card number
Index: trunk/extensions/QrCode/phpqrcode/qrspec.php
@@ -490,7 +490,7 @@
491491 if ($binary_mode) {
492492
493493 foreach ($frame as &$frameLine) {
494 - $frameLine = join('<span class="m">&nbsp;&nbsp;</span>', explode('0', $frameLine));
 494+ $frameLine = join('<span class="m">&#160;&#160;</span>', explode('0', $frameLine));
495495 $frameLine = join('&#9608;&#9608;', explode('1', $frameLine));
496496 }
497497
@@ -499,23 +499,23 @@
500500 .m { background-color: white; }
501501 </style>
502502 <?php
503 - echo '<pre><tt><br/ ><br/ ><br/ >&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;';
504 - echo join("<br/ >&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;", $frame);
 503+ echo '<pre><tt><br/ ><br/ ><br/ >&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;';
 504+ echo join("<br/ >&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;", $frame);
505505 echo '</tt></pre><br/ ><br/ ><br/ ><br/ ><br/ ><br/ >';
506506
507507 } else {
508508
509509 foreach ($frame as &$frameLine) {
510 - $frameLine = join('<span class="m">&nbsp;</span>', explode("\xc0", $frameLine));
 510+ $frameLine = join('<span class="m">&#160;</span>', explode("\xc0", $frameLine));
511511 $frameLine = join('<span class="m">&#9618;</span>', explode("\xc1", $frameLine));
512 - $frameLine = join('<span class="p">&nbsp;</span>', explode("\xa0", $frameLine));
 512+ $frameLine = join('<span class="p">&#160;</span>', explode("\xa0", $frameLine));
513513 $frameLine = join('<span class="p">&#9618;</span>', explode("\xa1", $frameLine));
514514 $frameLine = join('<span class="s">&#9671;</span>', explode("\x84", $frameLine)); //format 0
515515 $frameLine = join('<span class="s">&#9670;</span>', explode("\x85", $frameLine)); //format 1
516516 $frameLine = join('<span class="x">&#9762;</span>', explode("\x81", $frameLine)); //special bit
517 - $frameLine = join('<span class="c">&nbsp;</span>', explode("\x90", $frameLine)); //clock 0
 517+ $frameLine = join('<span class="c">&#160;</span>', explode("\x90", $frameLine)); //clock 0
518518 $frameLine = join('<span class="c">&#9719;</span>', explode("\x91", $frameLine)); //clock 1
519 - $frameLine = join('<span class="f">&nbsp;</span>', explode("\x88", $frameLine)); //version
 519+ $frameLine = join('<span class="f">&#160;</span>', explode("\x88", $frameLine)); //version
520520 $frameLine = join('<span class="f">&#9618;</span>', explode("\x89", $frameLine)); //version
521521 $frameLine = join('&#9830;', explode("\x01", $frameLine));
522522 $frameLine = join('&#8901;', explode("\0", $frameLine));
Index: trunk/extensions/QrCode/phpqrcode/index.php
@@ -73,19 +73,19 @@
7474
7575 //config form
7676 echo '<form action="index.php" method="post">
77 - Data:&nbsp;<input name="data" value="'.(isset($_REQUEST['data'])?htmlspecialchars($_REQUEST['data']):'PHP QR Code :)').'" />&nbsp;
78 - ECC:&nbsp;<select name="level">
 77+ Data:&#160;<input name="data" value="'.(isset($_REQUEST['data'])?htmlspecialchars($_REQUEST['data']):'PHP QR Code :)').'" />&#160;
 78+ ECC:&#160;<select name="level">
7979 <option value="L"'.(($errorCorrectionLevel=='L')?' selected':'').'>L - smallest</option>
8080 <option value="M"'.(($errorCorrectionLevel=='M')?' selected':'').'>M</option>
8181 <option value="Q"'.(($errorCorrectionLevel=='Q')?' selected':'').'>Q</option>
8282 <option value="H"'.(($errorCorrectionLevel=='H')?' selected':'').'>H - best</option>
83 - </select>&nbsp;
84 - Size:&nbsp;<select name="size">';
 83+ </select>&#160;
 84+ Size:&#160;<select name="size">';
8585
8686 for($i=1;$i<=10;$i++)
8787 echo '<option value="'.$i.'"'.(($matrixPointSize==$i)?' selected':'').'>'.$i.'</option>';
8888
89 - echo '</select>&nbsp;
 89+ echo '</select>&#160;
9090 <input type="submit" value="GENERATE"></form><hr/>';
9191
9292 // benchmark
Index: trunk/extensions/QrCode/phpqrcode/phpqrcode.php
@@ -802,7 +802,7 @@
803803 if ($binary_mode) {
804804
805805 foreach ($frame as &$frameLine) {
806 - $frameLine = join('<span class="m">&nbsp;&nbsp;</span>', explode('0', $frameLine));
 806+ $frameLine = join('<span class="m">&#160;&#160;</span>', explode('0', $frameLine));
807807 $frameLine = join('&#9608;&#9608;', explode('1', $frameLine));
808808 }
809809
@@ -811,23 +811,23 @@
812812 .m { background-color: white; }
813813 </style>
814814 <?php
815 - echo '<pre><tt><br/ ><br/ ><br/ >&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;';
816 - echo join("<br/ >&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;", $frame);
 815+ echo '<pre><tt><br/ ><br/ ><br/ >&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;';
 816+ echo join("<br/ >&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;", $frame);
817817 echo '</tt></pre><br/ ><br/ ><br/ ><br/ ><br/ ><br/ >';
818818
819819 } else {
820820
821821 foreach ($frame as &$frameLine) {
822 - $frameLine = join('<span class="m">&nbsp;</span>', explode("\xc0", $frameLine));
 822+ $frameLine = join('<span class="m">&#160;</span>', explode("\xc0", $frameLine));
823823 $frameLine = join('<span class="m">&#9618;</span>', explode("\xc1", $frameLine));
824 - $frameLine = join('<span class="p">&nbsp;</span>', explode("\xa0", $frameLine));
 824+ $frameLine = join('<span class="p">&#160;</span>', explode("\xa0", $frameLine));
825825 $frameLine = join('<span class="p">&#9618;</span>', explode("\xa1", $frameLine));
826826 $frameLine = join('<span class="s">&#9671;</span>', explode("\x84", $frameLine)); //format 0
827827 $frameLine = join('<span class="s">&#9670;</span>', explode("\x85", $frameLine)); //format 1
828828 $frameLine = join('<span class="x">&#9762;</span>', explode("\x81", $frameLine)); //special bit
829 - $frameLine = join('<span class="c">&nbsp;</span>', explode("\x90", $frameLine)); //clock 0
 829+ $frameLine = join('<span class="c">&#160;</span>', explode("\x90", $frameLine)); //clock 0
830830 $frameLine = join('<span class="c">&#9719;</span>', explode("\x91", $frameLine)); //clock 1
831 - $frameLine = join('<span class="f">&nbsp;</span>', explode("\x88", $frameLine)); //version
 831+ $frameLine = join('<span class="f">&#160;</span>', explode("\x88", $frameLine)); //version
832832 $frameLine = join('<span class="f">&#9618;</span>', explode("\x89", $frameLine)); //version
833833 $frameLine = join('&#9830;', explode("\x01", $frameLine));
834834 $frameLine = join('&#8901;', explode("\0", $frameLine));
Index: trunk/extensions/EmailPage/EmailPage_body.php
@@ -160,7 +160,7 @@
161161 $wgOut->addHTML( "<tr><td colspan=\"2\" align=\"right\">" );
162162 $wgOut->addHTML( Xml::element( 'input', array( 'type' => 'hidden', 'name' => 'ea-title', 'value' => $this->title ) ) );
163163 $wgOut->addHTML( Xml::element( 'input', array( 'id' => 'ea-show', 'type' => 'submit', 'name' => 'ea-show', 'value' => wfMsg( 'ea-show' ) ) ) );
164 - $wgOut->addHTML( "&nbsp;&nbsp;" );
 164+ $wgOut->addHTML( "&#160;&#160;" );
165165 $wgOut->addHTML( Xml::element( 'input', array( 'type' => 'submit', 'name' => 'ea-send', 'value' => wfMsg( 'ea-send' ) ) ) . '&#160;' );
166166 $wgOut->addHTML( "</td></tr>" );
167167
Index: trunk/extensions/EmailPage/PHPMailer_v5.1/language/phpmailer.lang-fi.php
@@ -17,7 +17,7 @@
1818 $PHPMAILER_LANG['instantiate'] = 'mail-funktion luonti epäonnistui.';
1919 //$PHPMAILER_LANG['invalid_email'] = 'Not sending, email address is invalid: ';
2020 $PHPMAILER_LANG['mailer_not_supported'] = 'postivälitintyyppiä ei tueta.';
21 -$PHPMAILER_LANG['provide_address'] = 'Aseta vähintään yksi vastaanottajan sähk&ouml;postiosoite.';
 21+$PHPMAILER_LANG['provide_address'] = 'Aseta vähintään yksi vastaanottajan sähköpostiosoite.';
2222 $PHPMAILER_LANG['recipients_failed'] = 'SMTP-virhe: seuraava vastaanottaja osoite on virheellinen.';
2323 $PHPMAILER_LANG['encoding'] = 'Tuntematon koodaustyyppi: ';
2424 //$PHPMAILER_LANG['signing'] = 'Signing Error: ';
Index: trunk/extensions/ContributionReporting/FundraiserStatistics_body.php
@@ -205,7 +205,7 @@
206206 $wgOut->addHTML( Xml::openElement( 'div', array( 'id' => 'configholder' ) ) );
207207 $wgOut->addHTML( $years );
208208 $wgOut->addHTML( wfMsg( 'fundraiserstats-time-zone' ).'<br/>' );
209 - $wgOut->addHTML( '&nbsp;'.Xml::listDropDown( 'timezone', $this->dropDownList( range ( -12, 14, 1 ) ), '', $this->timezone, '', 1 ).' '.wfMsg( 'fundraiserstats-utc' ) );
 209+ $wgOut->addHTML( '&#160;'.Xml::listDropDown( 'timezone', $this->dropDownList( range ( -12, 14, 1 ) ), '', $this->timezone, '', 1 ).' '.wfMsg( 'fundraiserstats-utc' ) );
210210 $wgOut->addHTML( Xml::closeElement( 'div' ) );
211211
212212 $wgOut->addHTML( Xml::closeElement( 'form' ) );
Index: trunk/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -1782,7 +1782,7 @@
17831783 $labelMsg = wfMsgExt( 'revreview-check-flag-u', 'parseinline' );
17841784 }
17851785 $label = Xml::element( 'label', $attribs, $labelMsg );
1786 - $checkboxes['reviewed'] = $checkbox . '&nbsp;' . $label;
 1786+ $checkboxes['reviewed'] = $checkbox . '&#160;' . $label;
17871787 }
17881788 return true;
17891789 }
Index: trunk/extensions/skins/p2wiki/P2wiki.skin.php
@@ -278,7 +278,7 @@
279279 <!-- /dataAfterContent -->
280280 <?php endif; ?>
281281 </div>
282 - <div class="bottom_of_entry">&nbsp;</div>
 282+ <div class="bottom_of_entry">&#160;</div>
283283 <div class="visualClear"></div>
284284 </div>
285285

Follow-up revisions

RevisionCommit summaryAuthorDate
r824541.17wmf1: MFT r82315, r82386, r82411, r82412, r82413catrope14:35, 19 February 2011
r865471.17: MFT r82413, r83529, r83545, r83874, r85544, r86065, r86346, r86477catrope20:24, 20 April 2011
r102697MFT r45856, r71558, r71962, r73304, r73309, r75671, r75680, r75726, r76542, r...awjrichards22:02, 10 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67090Remove most named character references from output...simetrical17:33, 30 May 2010
r68803Use <!DOCTYPE html> unconditionally...simetrical23:08, 30 June 2010

Comments

#Comment by Simetrical (talk | contribs)   18:57, 18 February 2011

Background: bug 27478. (Forgot to mention in my commit summary.)

#Comment by 😂 (talk | contribs)   14:10, 5 April 2011

I couldn't get this to merge cleanly to REL1_17.

#Comment by Simetrical (talk | contribs)   20:15, 5 April 2011

Unsurprising. It's probably not a big deal, it can be left out unless we get complaints. The changes are only going to even potentially affect bots that try to screen-scrape these extensions' pages using an XML parser, which is a pretty niche issue.

Status & tagging log