r82411 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82410‎ | r82411 | r82412 >
Date:18:35, 18 February 2011
Author:raymond
Status:ok
Tags:
Comment:
Fix invalid HTML introduced in r68096: Xml::buildForm() adds <table></table> too
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListfiles.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListfiles.php
@@ -211,10 +211,8 @@
212212 ) );
213213 $s = Html::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'id' => 'mw-listfiles-form' ) ) .
214214 Xml::fieldset( wfMsg( 'listfiles' ) ) .
215 - Html::openElement( 'table', array( 'id' => 'mw-listfiles-table' ) ) .
216215 Xml::buildForm( $inputForm, 'table_pager_limit_submit' ) .
217216 $this->getHiddenFields( array( 'limit', 'ilsearch', 'user' ) ) .
218 - Html::closeElement( 'table' ) .
219217 Html::closeElement( 'fieldset' ) .
220218 Html::closeElement( 'form' ) . "\n";
221219 return $s;

Follow-up revisions

RevisionCommit summaryAuthorDate
r824541.17wmf1: MFT r82315, r82386, r82411, r82412, r82413catrope14:35, 19 February 2011
r85211MFT: r82297, r82307, r82309, r82312, r82315, r82337, r82391, r82392, r82403, ...demon21:01, 2 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68096Follow-up r65013: Add an input field for the username. Use the nice Xml::buil...raymond18:16, 15 June 2010

Status & tagging log