r86547 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r86546‎ | r86547 | r86548 >
Date:20:24, 20 April 2011
Author:catrope
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/REL1_17/extensions/CodeReview/backend/Subversion.php (modified) (history)
  • /branches/REL1_17/extensions/DSMW/DSMW.php (modified) (history)
  • /branches/REL1_17/extensions/DSMW/files/utils.php (modified) (history)
  • /branches/REL1_17/extensions/DSMW/specials/ArticleAdminPage.php (modified) (history)
  • /branches/REL1_17/extensions/DSMW/tests/p2pTest3.php (modified) (history)
  • /branches/REL1_17/extensions/Deployment/specials/SpecialInstall.php (modified) (history)
  • /branches/REL1_17/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php (modified) (history)
  • /branches/REL1_17/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (modified) (history)
  • /branches/REL1_17/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php (modified) (history)
  • /branches/REL1_17/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php (modified) (history)
  • /branches/REL1_17/extensions/EmailPage/EmailPage_body.php (modified) (history)
  • /branches/REL1_17/extensions/EmailPage/PHPMailer_v5.1/language/phpmailer.lang-fi.php (modified) (history)
  • /branches/REL1_17/extensions/FlaggedRevs/FlaggedArticleView.php (modified) (history)
  • /branches/REL1_17/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)
  • /branches/REL1_17/extensions/LdapAuthentication/LdapAutoAuthentication.php (modified) (history)
  • /branches/REL1_17/extensions/ProofreadPage/ProofreadPage_body.php (modified) (history)
  • /branches/REL1_17/extensions/QrCode/phpqrcode/index.php (modified) (history)
  • /branches/REL1_17/extensions/QrCode/phpqrcode/phpqrcode.php (modified) (history)
  • /branches/REL1_17/extensions/QrCode/phpqrcode/qrspec.php (modified) (history)
  • /branches/REL1_17/extensions/RDFIO/specials/SpecialSPARQLEndpoint_body.php (modified) (history)
  • /branches/REL1_17/extensions/skins/p2wiki/P2wiki.skin.php (modified) (history)
  • /branches/REL1_17/phase3/includes/SpecialPage.php (modified) (history)
  • /branches/REL1_17/phase3/includes/db/LoadBalancer.php (modified) (history)
  • /branches/REL1_17/phase3/maintenance/updateCollation.php (modified) (history)

Diff [purge]

Index: branches/REL1_17/extensions/Deployment/specials/SpecialInstall.php
@@ -138,11 +138,11 @@
139139 "<option value='tag'$tagSelected>" . htmlspecialchars( wfMsg( 'search-tag' ) ) . '</option>'
140140 );
141141
142 - $searchHtml .= '&nbsp;&nbsp;';
 142+ $searchHtml .= '&#160;&#160;';
143143
144144 $searchHtml .= Html::input( 'filtervalue', $value );
145145
146 - $searchHtml .= '&nbsp;&nbsp;';
 146+ $searchHtml .= '&#160;&#160;';
147147
148148 $searchHtml .= Html::input(
149149 '',
Index: branches/REL1_17/extensions/CodeReview/backend/Subversion.php
@@ -161,7 +161,7 @@
162162 $formats = array(
163163 'rev' => '/^r(\d+)$/',
164164 'author' => '/^(.*)$/',
165 - 'date' => '/^(.*?) \(.*\)$/',
 165+ 'date' => '/^(?:(.*?) )?\(.*\)$/', // account for '(no date)'
166166 'lines' => '/^(\d+) lines?$/',
167167 );
168168 $state = "start";
Index: branches/REL1_17/extensions/RDFIO/specials/SpecialSPARQLEndpoint_body.php
@@ -897,9 +897,9 @@
898898 <input type="text" name="filtervocaburl" size="48" />
899899 </td></tr>
900900 <tr>
901 - <td>&nbsp;</td>
902 - <td>&nbsp;</td>
903 - <td>&nbsp;</td>
 901+ <td>&#160;</td>
 902+ <td>&#160;</td>
 903+ <td>&#160;</td>
904904 <td>
905905 <span style="font-family: arial, helvetica, sans-serif; font-size: 10px; color: #777">Example: http://xmlns.com/foaf/spec/index.rdf</span>
906906 </td></tr>
Index: branches/REL1_17/extensions/ProofreadPage/ProofreadPage_body.php
@@ -1529,7 +1529,7 @@
15301530 $qe = $ne * 100 / $n;
15311531 $void_cell = $ne ? "<td align=center style='border-style:dotted;border-width:1px;' width=\"{$qe}\"></td>" : '';
15321532 $output = "<table class=\"pr_quality\" style=\"line-height:40%;\" border=0 cellpadding=0 cellspacing=0 ><tr>
1533 -<td align=center >&nbsp;</td>
 1533+<td align=center >&#160;</td>
15341534 <td align=center class='quality4' width=\"$q4\"></td>
15351535 <td align=center class='quality3' width=\"$q3\"></td>
15361536 <td align=center class='quality2' width=\"$q2\"></td>
Index: branches/REL1_17/extensions/DSMW/DSMW.php
@@ -103,15 +103,15 @@
104104
105105 $wgExtensionCredits[defined( 'SEMANTIC_EXTENSION_TYPE' ) ? 'semantic' : 'other'][] = array(
106106 'path' => __FILE__,
107 - 'name' => 'Distributed&nbsp;Semantic&nbsp;MediaWiki',
 107+ 'name' => 'Distributed&#160;Semantic&#160;MediaWiki',
108108 'version' => DSMW_VERSION,
109109 'author' => array(
110 - '[http://www.loria.fr/~mullejea Jean&ndash;Philippe&nbsp;Muller]',
111 - '[http://www.loria.fr/~molli Pascal&nbsp;Molli]',
112 - '[http://www.loria.fr/~skaf Hala&nbsp;Skaf&ndash;Molli]',
113 - '[http://www.loria.fr/~canals Gérôme&nbsp;Canals]',
114 - '[http://www.loria.fr/~rahalcha Charbel&nbsp;Rahal]',
115 - '[http://www.loria.fr/~weiss Stéphane&nbsp;Weiss]',
 110+ '[http://www.loria.fr/~mullejea Jean–Philippe&#160;Muller]',
 111+ '[http://www.loria.fr/~molli Pascal&#160;Molli]',
 112+ '[http://www.loria.fr/~skaf Hala&#160;Skaf–Molli]',
 113+ '[http://www.loria.fr/~canals Gérôme&#160;Canals]',
 114+ '[http://www.loria.fr/~rahalcha Charbel&#160;Rahal]',
 115+ '[http://www.loria.fr/~weiss Stéphane&#160;Weiss]',
116116 '[http://m3p.gforge.inria.fr/pmwiki/pmwiki.php?n=Site.Team others]'
117117 ),
118118 'url' => 'http://www.dsmw.org',
Index: branches/REL1_17/extensions/DSMW/tests/p2pTest3.php
@@ -154,7 +154,7 @@
155155 | valign='top' | <span style='color: red;'><em><del>line deleted</del></em></span>
156156 | valign='top' | <span style='c/home/mullejea/Bureau/www/mediawiki-1.14.0/extensions/DSMW/tests/p2pTest3.php:258olor: red;'><em><del>line deleted</del></em></span>
157157 | valign='top' | <span style='color: red;'><em><del>line deleted</del></em></span>
158 -| valign='top' | <ul><li>DSMW server1 and server2 delete the &ldquo;initial_line&rdquo;
 158+| valign='top' | <ul><li>DSMW server1 and server2 delete the “initial_line”
159159 </li></ul>
160160 |}
161161
Index: branches/REL1_17/extensions/DSMW/files/utils.php
@@ -844,7 +844,7 @@
845845 foreach ( $props as $property ) {
846846
847847 if ( $property->isUserDefined() ) { // user defined property
848 - $property->setCaption( preg_replace( '/[ ]/u', '&nbsp;', $property->getWikiValue(), 2 ) );
 848+ $property->setCaption( preg_replace( '/[ ]/u', '&#160;', $property->getWikiValue(), 2 ) );
849849
850850 if ( $property->getWikiPageValue() != null ) {
851851 $obj = $property->getWikiPageValue();
Index: branches/REL1_17/extensions/DSMW/specials/ArticleAdminPage.php
@@ -309,11 +309,11 @@
310310 </table>
311311 </FORM>
312312 <div id="pullstatus" style="display: none; width: 100%; clear: both;" >
313 -<a name="PULL_Progress_:" id="PULL_Progress_:"></a><h2> <span class="mw-headline"> PULL Progress&nbsp;: </span></h2>
 313+<a name="PULL_Progress_:" id="PULL_Progress_:"></a><h2> <span class="mw-headline"> PULL Progress&#160;: </span></h2>
314314 <div id="statepull" ></div><br />
315315 </div>
316316 <div id="pushstatus" style="display: none; width: 100%; clear: both;" >
317 -<a name="PUSH_Progress_:" id="PUSH_Progress_:"></a><h2> <span class="mw-headline"> PUSH Progress&nbsp;: </span></h2>
 317+<a name="PUSH_Progress_:" id="PUSH_Progress_:"></a><h2> <span class="mw-headline"> PUSH Progress&#160;: </span></h2>
318318 <div id="statepush" ></div><br />
319319 </div>
320320 ';
Index: branches/REL1_17/extensions/LdapAuthentication/LdapAutoAuthentication.php
@@ -112,7 +112,7 @@
113113 global $wgAuth;
114114 $wgAuth->printDebug( "Entering NoLogout.", NONSENSITIVE );
115115
116 - $personal_urls['logout'] = null;
 116+ unset( $personal_urls['logout'] );
117117
118118 return true;
119119 }
Index: branches/REL1_17/extensions/LdapAuthentication/LdapAuthentication.php
@@ -88,7 +88,7 @@
8989 $wgLDAPUniqueBlockLogin = array(); //Currently unused
9090 $wgLDAPUniqueRenameUser = array(); //Currently unused
9191
92 -define( "LDAPAUTHVERSION", "1.2d" );
 92+define( "LDAPAUTHVERSION", "1.2e" );
9393
9494 /**
9595 * Add extension information to Special:Version
Index: branches/REL1_17/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php
@@ -250,9 +250,9 @@
251251 $form .= '<td>' .
252252 '<p style="border: 1px solid rgb(187, 187, 187); float: left; -moz-border-radius: 5px 5px 5px 5px; margin: 0 8px 0 0; padding: 5px 5px 5px 3px; white-space: nowrap;">'.
253253 Xml::radio( 'card', 'cc1', $this->form_data['card'] == 'cc1', array( 'id' => 'cc1radio', 'onclick' => 'switchToCreditCard()' ) ) . '<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-visa.png" ) ). '</label>' .
254 - '&nbsp;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-mastercard.png" ) ). '</label>' .
255 - '&nbsp;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-amex.png" ) ). '</label>' .
256 - '&nbsp;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-discover.png" ) ). '</label>' .
 254+ '&#160;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-mastercard.png" ) ). '</label>' .
 255+ '&#160;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-amex.png" ) ). '</label>' .
 256+ '&#160;<label for="cc1radio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-discover.png" ) ). '</label>' .
257257 '</p>'.
258258 '<p style="border: 1px solid transparent; float: left; -moz-border-radius: 5px 5px 5px 5px; margin: 0; padding: 5px 5px 5px 3px; white-space: nowrap;">'.
259259 Xml::radio( 'card', 'pp', $this->form_data['card'] == 'pp', array( 'id' => 'ppradio', 'onclick' => 'switchToPayPal()' ) ) . '<label for="ppradio">' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/card-paypal.png" ) ) . '</label>' .
Index: branches/REL1_17/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php
@@ -118,7 +118,7 @@
119119 $form .= Html::hidden( 'PaypalRedirect', 0 );
120120 $form .= Xml::tags( 'div',
121121 array(),
122 - Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos2.gif" ) ) . '&nbsp;&nbsp;&nbsp;<a href="#" onclick="document.payment.PaypalRedirect.value=1;document.payment.submit();"><img src="' . $scriptPath . '/donate_with_paypal.gif"/></a>'
 122+ Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos2.gif" ) ) . '&#160;&#160;&#160;<a href="#" onclick="document.payment.PaypalRedirect.value=1;document.payment.submit();"><img src="' . $scriptPath . '/donate_with_paypal.gif"/></a>'
123123 );
124124 $form .= '</td>';
125125 $form .= '</tr>';
Index: branches/REL1_17/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php
@@ -168,7 +168,7 @@
169169 // submit button
170170 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ) );
171171 // $form .= Xml::submitButton( wfMsg( 'payflowpro_gateway-submit-button' ));
172 - $form .= '&nbsp;<br/>' . Xml::element( 'input', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/submit-donation-button.png", 'alt' => 'Submit donation', 'type' => 'image' ) );
 172+ $form .= '&#160;<br/>' . Xml::element( 'input', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/submit-donation-button.png", 'alt' => 'Submit donation', 'type' => 'image' ) );
173173 $form .= Xml::closeElement( 'div' ); // close div#mw-donate-submit-button
174174 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
175175 Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/padlock.gif", 'style' => 'vertical-align:baseline;margin-right:4px;' ) ) . 'Your credit / debit card will be securely processed.';
Index: branches/REL1_17/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php
@@ -280,7 +280,7 @@
281281 // card logos
282282 $form .= '<tr>';
283283 $form .= '<td />';
284 - $form .= '<td>&nbsp;<br/>' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" ) ) . '</td>';
 284+ $form .= '<td>&#160;<br/>' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" ) ) . '</td>';
285285 $form .= '</tr>';
286286
287287 // card number
Index: branches/REL1_17/extensions/QrCode/phpqrcode/qrspec.php
@@ -490,7 +490,7 @@
491491 if ($binary_mode) {
492492
493493 foreach ($frame as &$frameLine) {
494 - $frameLine = join('<span class="m">&nbsp;&nbsp;</span>', explode('0', $frameLine));
 494+ $frameLine = join('<span class="m">&#160;&#160;</span>', explode('0', $frameLine));
495495 $frameLine = join('&#9608;&#9608;', explode('1', $frameLine));
496496 }
497497
@@ -499,23 +499,23 @@
500500 .m { background-color: white; }
501501 </style>
502502 <?php
503 - echo '<pre><tt><br/ ><br/ ><br/ >&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;';
504 - echo join("<br/ >&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;", $frame);
 503+ echo '<pre><tt><br/ ><br/ ><br/ >&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;';
 504+ echo join("<br/ >&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;", $frame);
505505 echo '</tt></pre><br/ ><br/ ><br/ ><br/ ><br/ ><br/ >';
506506
507507 } else {
508508
509509 foreach ($frame as &$frameLine) {
510 - $frameLine = join('<span class="m">&nbsp;</span>', explode("\xc0", $frameLine));
 510+ $frameLine = join('<span class="m">&#160;</span>', explode("\xc0", $frameLine));
511511 $frameLine = join('<span class="m">&#9618;</span>', explode("\xc1", $frameLine));
512 - $frameLine = join('<span class="p">&nbsp;</span>', explode("\xa0", $frameLine));
 512+ $frameLine = join('<span class="p">&#160;</span>', explode("\xa0", $frameLine));
513513 $frameLine = join('<span class="p">&#9618;</span>', explode("\xa1", $frameLine));
514514 $frameLine = join('<span class="s">&#9671;</span>', explode("\x84", $frameLine)); //format 0
515515 $frameLine = join('<span class="s">&#9670;</span>', explode("\x85", $frameLine)); //format 1
516516 $frameLine = join('<span class="x">&#9762;</span>', explode("\x81", $frameLine)); //special bit
517 - $frameLine = join('<span class="c">&nbsp;</span>', explode("\x90", $frameLine)); //clock 0
 517+ $frameLine = join('<span class="c">&#160;</span>', explode("\x90", $frameLine)); //clock 0
518518 $frameLine = join('<span class="c">&#9719;</span>', explode("\x91", $frameLine)); //clock 1
519 - $frameLine = join('<span class="f">&nbsp;</span>', explode("\x88", $frameLine)); //version
 519+ $frameLine = join('<span class="f">&#160;</span>', explode("\x88", $frameLine)); //version
520520 $frameLine = join('<span class="f">&#9618;</span>', explode("\x89", $frameLine)); //version
521521 $frameLine = join('&#9830;', explode("\x01", $frameLine));
522522 $frameLine = join('&#8901;', explode("\0", $frameLine));
Index: branches/REL1_17/extensions/QrCode/phpqrcode/index.php
@@ -73,19 +73,19 @@
7474
7575 //config form
7676 echo '<form action="index.php" method="post">
77 - Data:&nbsp;<input name="data" value="'.(isset($_REQUEST['data'])?htmlspecialchars($_REQUEST['data']):'PHP QR Code :)').'" />&nbsp;
78 - ECC:&nbsp;<select name="level">
 77+ Data:&#160;<input name="data" value="'.(isset($_REQUEST['data'])?htmlspecialchars($_REQUEST['data']):'PHP QR Code :)').'" />&#160;
 78+ ECC:&#160;<select name="level">
7979 <option value="L"'.(($errorCorrectionLevel=='L')?' selected':'').'>L - smallest</option>
8080 <option value="M"'.(($errorCorrectionLevel=='M')?' selected':'').'>M</option>
8181 <option value="Q"'.(($errorCorrectionLevel=='Q')?' selected':'').'>Q</option>
8282 <option value="H"'.(($errorCorrectionLevel=='H')?' selected':'').'>H - best</option>
83 - </select>&nbsp;
84 - Size:&nbsp;<select name="size">';
 83+ </select>&#160;
 84+ Size:&#160;<select name="size">';
8585
8686 for($i=1;$i<=10;$i++)
8787 echo '<option value="'.$i.'"'.(($matrixPointSize==$i)?' selected':'').'>'.$i.'</option>';
8888
89 - echo '</select>&nbsp;
 89+ echo '</select>&#160;
9090 <input type="submit" value="GENERATE"></form><hr/>';
9191
9292 // benchmark
Index: branches/REL1_17/extensions/QrCode/phpqrcode/phpqrcode.php
@@ -802,7 +802,7 @@
803803 if ($binary_mode) {
804804
805805 foreach ($frame as &$frameLine) {
806 - $frameLine = join('<span class="m">&nbsp;&nbsp;</span>', explode('0', $frameLine));
 806+ $frameLine = join('<span class="m">&#160;&#160;</span>', explode('0', $frameLine));
807807 $frameLine = join('&#9608;&#9608;', explode('1', $frameLine));
808808 }
809809
@@ -811,23 +811,23 @@
812812 .m { background-color: white; }
813813 </style>
814814 <?php
815 - echo '<pre><tt><br/ ><br/ ><br/ >&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;';
816 - echo join("<br/ >&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;", $frame);
 815+ echo '<pre><tt><br/ ><br/ ><br/ >&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;';
 816+ echo join("<br/ >&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;", $frame);
817817 echo '</tt></pre><br/ ><br/ ><br/ ><br/ ><br/ ><br/ >';
818818
819819 } else {
820820
821821 foreach ($frame as &$frameLine) {
822 - $frameLine = join('<span class="m">&nbsp;</span>', explode("\xc0", $frameLine));
 822+ $frameLine = join('<span class="m">&#160;</span>', explode("\xc0", $frameLine));
823823 $frameLine = join('<span class="m">&#9618;</span>', explode("\xc1", $frameLine));
824 - $frameLine = join('<span class="p">&nbsp;</span>', explode("\xa0", $frameLine));
 824+ $frameLine = join('<span class="p">&#160;</span>', explode("\xa0", $frameLine));
825825 $frameLine = join('<span class="p">&#9618;</span>', explode("\xa1", $frameLine));
826826 $frameLine = join('<span class="s">&#9671;</span>', explode("\x84", $frameLine)); //format 0
827827 $frameLine = join('<span class="s">&#9670;</span>', explode("\x85", $frameLine)); //format 1
828828 $frameLine = join('<span class="x">&#9762;</span>', explode("\x81", $frameLine)); //special bit
829 - $frameLine = join('<span class="c">&nbsp;</span>', explode("\x90", $frameLine)); //clock 0
 829+ $frameLine = join('<span class="c">&#160;</span>', explode("\x90", $frameLine)); //clock 0
830830 $frameLine = join('<span class="c">&#9719;</span>', explode("\x91", $frameLine)); //clock 1
831 - $frameLine = join('<span class="f">&nbsp;</span>', explode("\x88", $frameLine)); //version
 831+ $frameLine = join('<span class="f">&#160;</span>', explode("\x88", $frameLine)); //version
832832 $frameLine = join('<span class="f">&#9618;</span>', explode("\x89", $frameLine)); //version
833833 $frameLine = join('&#9830;', explode("\x01", $frameLine));
834834 $frameLine = join('&#8901;', explode("\0", $frameLine));
Index: branches/REL1_17/extensions/EmailPage/EmailPage_body.php
@@ -160,7 +160,7 @@
161161 $wgOut->addHTML( "<tr><td colspan=\"2\" align=\"right\">" );
162162 $wgOut->addHTML( Xml::element( 'input', array( 'type' => 'hidden', 'name' => 'ea-title', 'value' => $this->title ) ) );
163163 $wgOut->addHTML( Xml::element( 'input', array( 'id' => 'ea-show', 'type' => 'submit', 'name' => 'ea-show', 'value' => wfMsg( 'ea-show' ) ) ) );
164 - $wgOut->addHTML( "&nbsp;&nbsp;" );
 164+ $wgOut->addHTML( "&#160;&#160;" );
165165 $wgOut->addHTML( Xml::element( 'input', array( 'type' => 'submit', 'name' => 'ea-send', 'value' => wfMsg( 'ea-send' ) ) ) . '&#160;' );
166166 $wgOut->addHTML( "</td></tr>" );
167167
Index: branches/REL1_17/extensions/EmailPage/PHPMailer_v5.1/language/phpmailer.lang-fi.php
@@ -17,7 +17,7 @@
1818 $PHPMAILER_LANG['instantiate'] = 'mail-funktion luonti epäonnistui.';
1919 //$PHPMAILER_LANG['invalid_email'] = 'Not sending, email address is invalid: ';
2020 $PHPMAILER_LANG['mailer_not_supported'] = 'postivälitintyyppiä ei tueta.';
21 -$PHPMAILER_LANG['provide_address'] = 'Aseta vähintään yksi vastaanottajan sähk&ouml;postiosoite.';
 21+$PHPMAILER_LANG['provide_address'] = 'Aseta vähintään yksi vastaanottajan sähköpostiosoite.';
2222 $PHPMAILER_LANG['recipients_failed'] = 'SMTP-virhe: seuraava vastaanottaja osoite on virheellinen.';
2323 $PHPMAILER_LANG['encoding'] = 'Tuntematon koodaustyyppi: ';
2424 //$PHPMAILER_LANG['signing'] = 'Signing Error: ';
Index: branches/REL1_17/extensions/FlaggedRevs/FlaggedArticleView.php
@@ -1744,7 +1744,7 @@
17451745 $labelMsg = wfMsgExt( 'revreview-check-flag-u', 'parseinline' );
17461746 }
17471747 $label = Xml::element( 'label', $attribs, $labelMsg );
1748 - $checkboxes['reviewed'] = $checkbox . '&nbsp;' . $label;
 1748+ $checkboxes['reviewed'] = $checkbox . '&#160;' . $label;
17491749 }
17501750 return true;
17511751 }
Index: branches/REL1_17/extensions/skins/p2wiki/P2wiki.skin.php
@@ -317,7 +317,7 @@
318318 <!-- /dataAfterContent -->
319319 <?php endif; ?>
320320 </div>
321 - <div class="bottom_of_entry">&nbsp;</div>
 321+ <div class="bottom_of_entry">&#160;</div>
322322 <div class="visualClear"></div>
323323 </div>
324324
Index: branches/REL1_17/phase3/maintenance/updateCollation.php
@@ -10,7 +10,7 @@
1111 require_once( dirname( __FILE__ ) . '/Maintenance.php' );
1212
1313 class UpdateCollation extends Maintenance {
14 - const BATCH_SIZE = 1000;
 14+ const BATCH_SIZE = 50;
1515
1616 public function __construct() {
1717 parent::__construct();
@@ -26,9 +26,20 @@
2727 $this->addOption( 'force', 'Run on all rows, even if the collation is ' .
2828 'supposed to be up-to-date.' );
2929 }
 30+
 31+ public function syncDBs() {
 32+ $lb = wfGetLB();
 33+ // bug 27975 - Don't try to wait for slaves if there are none
 34+ // Prevents permission error when getting master position
 35+ if ( $lb->getServerCount() > 1 ) {
 36+ $dbw = $lb->getConnection( DB_MASTER );
 37+ $pos = $dbw->getMasterPos();
 38+ $lb->waitForAll( $pos );
 39+ }
 40+ }
3041
3142 public function execute() {
32 - global $wgCategoryCollation;
 43+ global $wgCategoryCollation, $wgMiserMode;
3344
3445 $dbw = wfGetDB( DB_MASTER );
3546 $force = $this->getOption( 'force' );
@@ -36,30 +47,33 @@
3748 $options = array( 'LIMIT' => self::BATCH_SIZE );
3849
3950 if ( $force ) {
 51+ $options['ORDER BY'] = 'cl_from, cl_to';
4052 $collationConds = array();
41 - $options['ORDER BY'] = 'cl_from, cl_to';
4253 } else {
4354 $collationConds = array( 0 =>
4455 'cl_collation != ' . $dbw->addQuotes( $wgCategoryCollation ) );
4556
46 - $count = $dbw->selectField(
47 - 'categorylinks',
48 - 'COUNT(*)',
49 - $collationConds,
50 - __METHOD__
51 - );
 57+ if ( !$wgMiserMode ) {
 58+ $count = $dbw->selectField(
 59+ 'categorylinks',
 60+ 'COUNT(*)',
 61+ $collationConds,
 62+ __METHOD__
 63+ );
5264
53 - if ( $count == 0 ) {
54 - $this->output( "Collations up-to-date.\n" );
55 - return;
 65+ if ( $count == 0 ) {
 66+ $this->output( "Collations up-to-date.\n" );
 67+ return;
 68+ }
 69+ $this->output( "Fixing collation for $count rows.\n" );
5670 }
57 - $this->output( "Fixing collation for $count rows.\n" );
5871 }
5972
6073 $count = 0;
6174 $row = false;
6275 $batchConds = array();
6376 do {
 77+ $this->output( 'Processing next ' . self::BATCH_SIZE . ' rows... ');
6478 $res = $dbw->select(
6579 array( 'categorylinks', 'page' ),
6680 array( 'cl_from', 'cl_to', 'cl_sortkey_prefix', 'cl_collation',
@@ -121,6 +135,8 @@
122136
123137 $count += $res->numRows();
124138 $this->output( "$count done.\n" );
 139+
 140+ $this->syncDBs();
125141 } while ( $res->numRows() == self::BATCH_SIZE );
126142 }
127143 }
Index: branches/REL1_17/phase3/includes/db/LoadBalancer.php
@@ -338,6 +338,18 @@
339339 }
340340 wfProfileOut( __METHOD__ );
341341 }
 342+
 343+ /**
 344+ * Set the master wait position and wait for ALL slaves to catch up to it
 345+ */
 346+ public function waitForAll( $pos ) {
 347+ wfProfileIn( __METHOD__ );
 348+ $this->mWaitForPos = $pos;
 349+ for ( $i = 1; $i < count( $this->mServers ); $i++ ) {
 350+ $this->doWait( $i );
 351+ }
 352+ wfProfileOut( __METHOD__ );
 353+ }
342354
343355 /**
344356 * Get any open connection to a given server index, local or foreign
Property changes on: branches/REL1_17/phase3/includes/db/LoadBalancer.php
___________________________________________________________________
Modified: svn:mergeinfo
345357 Merged /trunk/phase3/includes/db/LoadBalancer.php:r82413,82699,83529,83545,83874,85544,85598,86049,86065,86346,86477-86479
Index: branches/REL1_17/phase3/includes/SpecialPage.php
@@ -834,7 +834,7 @@
835835 * Default execute method
836836 * Checks user permissions, calls the function given in mFunction
837837 *
838 - * This may be overridden by subclasses.
 838+ * This must be overridden by subclasses; it will be made abstract in a future version
839839 */
840840 function execute( $par ) {
841841 global $wgUser;
Property changes on: branches/REL1_17/phase3/includes/SpecialPage.php
___________________________________________________________________
Modified: svn:mergeinfo
842842 Merged /trunk/phase3/includes/SpecialPage.php:r82413,82699,83529,83545,83874,85544,85598,86049,86346,86477-86479

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82413Remove named entities again...simetrical18:56, 18 February 2011
r83529Make updateCollation.php a bit less murderous for WMF databases:...catrope16:47, 8 March 2011
r83545Change collationUpdate batch size from 1000 to 50...simetrical21:21, 8 March 2011
r83874(bug 27975) Fix r83529 (slave catchup in updateCollation.php) to not try to w...catrope09:30, 14 March 2011
r85544* (bug 28377) Notice: Undefined index: text in /w/skins/Vector.php on line 763...reedy15:51, 6 April 2011
r86065Ensure $collationConds is defined on all pathsreedy18:46, 14 April 2011
r86346Warn that SpecialPage::execute() will be made abstract at some point in the f...happy-melon21:07, 18 April 2011
r86477CodeReview: Make svnImport.php not die with an exception when it encounters c...catrope14:55, 20 April 2011

Status & tagging log