r85544 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r85543‎ | r85544 | r85545 >
Date:15:51, 6 April 2011
Author:reedy
Status:ok (Comments)
Tags:
Comment:
* (bug 28377) Notice: Undefined index: text in /w/skins/Vector.php on line 763

Apply Roans fix (as a patch by Solitarius) to Ldap Plugin

Bump version 1.2e
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)
  • /trunk/extensions/LdapAuthentication/LdapAutoAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAutoAuthentication.php
@@ -95,7 +95,7 @@
9696 global $wgAuth;
9797 $wgAuth->printDebug( "Entering NoLogout.", NONSENSITIVE );
9898
99 - $personal_urls['logout'] = null;
 99+ unset( $personal_urls['logout'] );
100100
101101 return true;
102102 }
Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -88,7 +88,7 @@
8989 $wgLDAPUniqueBlockLogin = array(); //Currently unused
9090 $wgLDAPUniqueRenameUser = array(); //Currently unused
9191
92 -define( "LDAPAUTHVERSION", "1.2d" );
 92+define( "LDAPAUTHVERSION", "1.2e" );
9393
9494 /**
9595 * Add extension information to Special:Version

Follow-up revisions

RevisionCommit summaryAuthorDate
r865471.17: MFT r82413, r83529, r83545, r83874, r85544, r86065, r86346, r86477catrope20:24, 20 April 2011

Comments

#Comment by Solitarius (talk | contribs)   06:13, 16 April 2011

It's been running on my system for a week with error reporting turned On without any issues. I think it can safely be tagged ok.

Status & tagging log