r83545 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r83544‎ | r83545 | r83546 >
Date:21:21, 8 March 2011
Author:simetrical
Status:ok
Tags:
Comment:
Change collationUpdate batch size from 1000 to 50

It selects that many rows, then does PHP processing and an individual
update query for each one. This is not a good idea when each batch is
done in a single transaction: 1000 MySQL updates interspersed with PHP
processing might take a second or more while locks are held.
Modified paths:
  • /trunk/phase3/maintenance/updateCollation.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/updateCollation.php
@@ -29,7 +29,7 @@
3030 require_once( dirname( __FILE__ ) . '/Maintenance.php' );
3131
3232 class UpdateCollation extends Maintenance {
33 - const BATCH_SIZE = 1000;
 33+ const BATCH_SIZE = 50;
3434
3535 public function __construct() {
3636 parent::__construct();

Follow-up revisions

RevisionCommit summaryAuthorDate
r835591.17wmf1: MFT r83544, r83545. Were already deployed on WMFcatrope00:27, 9 March 2011
r865471.17: MFT r82413, r83529, r83545, r83874, r85544, r86065, r86346, r86477catrope20:24, 20 April 2011

Status & tagging log