r86346 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86345‎ | r86346 | r86347 >
Date:21:07, 18 April 2011
Author:happy-melon
Status:ok
Tags:
Comment:
Warn that SpecialPage::execute() will be made abstract at some point in the future, which is the endpoint of getting rid of the define-special-pages-by-global-functions structure. Committing this separate to the other changes because it should be backported to 1.17.
Modified paths:
  • /trunk/phase3/includes/SpecialPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialPage.php
——@@ -466,7 +466,7 @@
467467 * Default execute method
468468 * Checks user permissions, calls the function given in mFunction
469469 *
470 - * This may be overridden by subclasses.
 470+ * This must be overridden by subclasses; it will be made abstract in a future version
471471 */
472472 function execute( $par ) {
473473 $this->setHeaders();

Follow-up revisions

RevisionCommit summaryAuthorDate
r865471.17: MFT r82413, r83529, r83545, r83874, r85544, r86065, r86346, r86477catrope20:24, 20 April 2011

Status & tagging log