r82386 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r82385‎ | r82386 | r82387 >
Date:09:55, 18 February 2011
Author:raymond
Status:ok
Tags:
Comment:
Bug 27430 - Special:CentralAuth shouldn't use always minutes:
Fixes regression from r64872: formatNum() was applied too early
Modified paths:
  • /trunk/extensions/CentralAuth/SpecialCentralAuth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralAuth/SpecialCentralAuth.php
@@ -260,9 +260,9 @@
261261 if ( $span < 2 * $chunk ) {
262262 return wfMsgExt( "centralauth-$unit-ago", 'parsemag', $wgLang->formatNum( $span ) );
263263 }
264 - $span = $wgLang->formatNum( intval( $span / $chunk ) );
 264+ $span = intval( $span / $chunk );
265265 }
266 - return wfMsgExt( "centralauth-$unit-ago", 'parsemag', $span );
 266+ return wfMsgExt( "centralauth-$unit-ago", 'parsemag', $wgLang->formatNum( $span ) );
267267 }
268268
269269 function showInfo() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r824541.17wmf1: MFT r82315, r82386, r82411, r82412, r82413catrope14:35, 19 February 2011
r85027MFT various extension fixes: r81713, r81742, r81743, r81908, r81966, r81969, ...demon18:23, 30 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r64872* Add formatNum for proper localisation...raymond12:16, 10 April 2010

Status & tagging log