r86477 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r86476‎ | r86477 | r86478 >
Date:14:55, 20 April 2011
Author:catrope
Status:ok
Tags:
Comment:
CodeReview: Make svnImport.php not die with an exception when it encounters censored revisions in the log where the date field is set to '(no date)' . These revisions are now imported sort-of sanely with '(no author)' as author and the timestamp of the import.
Modified paths:
  • /trunk/extensions/CodeReview/backend/Subversion.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/Subversion.php
——@@ -188,7 +188,7 @@
189189 $formats = array(
190190 'rev' => '/^r(\d+)$/',
191191 'author' => '/^(.*)$/',
192 - 'date' => '/^(.*?) \(.*\)$/',
 192+ 'date' => '/^(?:(.*?) )?\(.*\)$/', // account for '(no date)'
193193 'lines' => '/^(\d+) lines?$/',
194194 );
195195 $state = "start";

Follow-up revisions

RevisionCommit summaryAuthorDate
r865471.17: MFT r82413, r83529, r83545, r83874, r85544, r86065, r86346, r86477catrope20:24, 20 April 2011
r87090MFT a few minor CR fixes (r86477, r86478, r86479, r87012)demon18:11, 28 April 2011

Status & tagging log