r79129 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r79128‎ \| r79129 \| r79130 >
Date:	19:58, 28 December 2010
Author:	platonides
Status:	ok (Comments)
Tags:
Comment:	MFT r78011 r78014 r78015 r78016 r78099 r78117 r78161 r78170 r78172 r78199 r78393 r78506 r78507 r78510 r78511 r78536 r78544 r78565 r78660 r78679 r78774 r78808 r78887 r78926 r78943 r79013 r78393 r79018 r79019 r79034 r79072 r79115 r78015 skins/monobook/external-rtl.png target changed to external.png due to r74966 backout in r78175
Modified paths:	/branches/REL1_17/phase3/RELEASE-NOTES (modified) (history) /branches/REL1_17/phase3/includes/Article.php (modified) (history) /branches/REL1_17/phase3/includes/Block.php (modified) (history) /branches/REL1_17/phase3/includes/DefaultSettings.php (modified) (history) /branches/REL1_17/phase3/includes/GlobalFunctions.php (modified) (history) /branches/REL1_17/phase3/includes/ImportXMLReader.php (modified) (history) /branches/REL1_17/phase3/includes/OutputPage.php (modified) (history) /branches/REL1_17/phase3/includes/SkinTemplate.php (modified) (history) /branches/REL1_17/phase3/includes/User.php (modified) (history) /branches/REL1_17/phase3/includes/installer/CoreInstaller.php (modified) (history) /branches/REL1_17/phase3/includes/installer/MysqlInstaller.php (modified) (history) /branches/REL1_17/phase3/includes/parser/Parser.php (modified) (history) /branches/REL1_17/phase3/includes/parser/ParserCache.php (modified) (history) /branches/REL1_17/phase3/includes/parser/ParserOptions.php (modified) (history) /branches/REL1_17/phase3/includes/parser/ParserOutput.php (modified) (history) /branches/REL1_17/phase3/includes/resourceloader/ResourceLoader.php (modified) (history) /branches/REL1_17/phase3/includes/resourceloader/ResourceLoaderFileModule.php (modified) (history) /branches/REL1_17/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php (modified) (history) /branches/REL1_17/phase3/includes/resourceloader/ResourceLoaderUserOptionsModule.php (modified) (history) /branches/REL1_17/phase3/includes/resourceloader/ResourceLoaderWikiModule.php (modified) (history) /branches/REL1_17/phase3/includes/specials/SpecialBlockip.php (modified) (history) /branches/REL1_17/phase3/includes/specials/SpecialUploadStash.php (modified) (history) /branches/REL1_17/phase3/languages/LanguageConverter.php (modified) (history) /branches/REL1_17/phase3/languages/Names.php (modified) (history) /branches/REL1_17/phase3/languages/messages/MessagesEn.php (modified) (history) /branches/REL1_17/phase3/maintenance/language/messages.inc (modified) (history) /branches/REL1_17/phase3/maintenance/tables.sql (modified) (history) /branches/REL1_17/phase3/resources/Resources.php (modified) (history) /branches/REL1_17/phase3/resources/jquery/jquery.highlightText.js (modified) (history) /branches/REL1_17/phase3/resources/jquery/jquery.suggestions.css (modified) (history) /branches/REL1_17/phase3/skins/Vector.php (modified) (history) /branches/REL1_17/phase3/skins/common/block.js (modified) (history) /branches/REL1_17/phase3/skins/common/changepassword.js (deleted) (history) /branches/REL1_17/phase3/skins/common/images/Arr_d.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/Arr_l.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/Arr_r.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/Arr_u.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/add.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/ar/button_bold.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/ar/button_headline.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/ar/button_italic.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/ar/button_link.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/ar/button_nowiki.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/arrow_disabled_first_25.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/arrow_disabled_last_25.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/arrow_disabled_left_25.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/arrow_disabled_right_25.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/arrow_first_25.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/arrow_last_25.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/arrow_left_25.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/arrow_right_25.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/be-tarask/button_italic.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/be-tarask/button_link.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_bold.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_extlink.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_headline.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_hr.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_image.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_italic.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_link.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_media.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_nowiki.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_sig.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/button_template.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/cc-by-nc-sa.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/cc-by-sa.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/closewindow.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/critical-32.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/cyrl/button_italic.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/de/button_bold.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/de/button_italic.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/download-32.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/fa/button_bold.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/fa/button_headline.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/fa/button_italic.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/fa/button_link.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/fa/button_nowiki.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/gnu-fdl.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-c.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-cpp.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-deb.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-djvu.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-dvi.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-exe.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-h.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-html.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-iso.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-java.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-mid.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-o.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-ogg.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-pdf.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-ps.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-rm.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-rpm.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-svg.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-tar.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-tex.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-ttf.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon-txt.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/icons/fileicon.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/info-32.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/ksh/button_S_italic.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/mediawiki.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/public-domain.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/redirectltr.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/redirectrtl.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/remove.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/tick-32.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/tooltip_icon.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/warning-32.png (modified) (history) /branches/REL1_17/phase3/skins/common/images/wiki.png (modified) (history) /branches/REL1_17/phase3/skins/modern/audio.png (modified) (history) /branches/REL1_17/phase3/skins/modern/document.png (modified) (history) /branches/REL1_17/phase3/skins/modern/external.png (modified) (history) /branches/REL1_17/phase3/skins/modern/footer-grad.png (modified) (history) /branches/REL1_17/phase3/skins/modern/news_icon.png (modified) (history) /branches/REL1_17/phase3/skins/modern/video.png (modified) (history) /branches/REL1_17/phase3/skins/monobook/audio.png (modified) (history) /branches/REL1_17/phase3/skins/monobook/document.png (modified) (history) /branches/REL1_17/phase3/skins/monobook/external-rtl.png (modified) (history) /branches/REL1_17/phase3/skins/monobook/external.png (modified) (history) /branches/REL1_17/phase3/skins/monobook/news_icon.png (modified) (history) /branches/REL1_17/phase3/skins/monobook/wiki-indexed.png (modified) (history) /branches/REL1_17/phase3/skins/monobook/wiki.png (modified) (history) /branches/REL1_17/phase3/skins/simple/external.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/arrow-down-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/audio-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/border.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/bullet-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/document-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/edit-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/external-link-ltr-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/external-link-rtl-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/file-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/link-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/lock-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/mail-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/news-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/page-base.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/page-fade.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/portal-break-ltr.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/portal-break-rtl.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/portal-break.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/preferences-base.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/preferences-edge.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/preferences-fade.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/search-fade.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/tab-break.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/tab-current-fade.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/tab-normal-fade.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/talk-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/user-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/video-icon.png (modified) (history) /branches/REL1_17/phase3/skins/vector/images/watch-icons.png (modified) (history) /branches/REL1_17/phase3/skins/vector/screen.css (modified) (history)

Follow-up revisions

Revision	Commit summary	Author	Date
r79340	Revert changes to skins/Vector.php in r79129, they lead to fatal errors due t...	catrope	15:26, 31 December 2010
r79341	Follow-up r79340: merge r78117, r78170, r78172 and r78506 from trunk into ski...	catrope	15:48, 31 December 2010
r79342	Merge mediawiki.js changes from r78943 that were overlooked in r79129	catrope	15:52, 31 December 2010
r79343	MFT r78161 and r78511, incorrectly stated as merged in r79129....	platonides	15:56, 31 December 2010
r82316	Parser::clearState() is no longer safe in 1.17a (since r79129) if Parser...	juliano	02:05, 17 February 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r74966	First shot at porting Monobook to Vector. The only non-straightforward part i...	catrope	20:35, 18 October 2010
r78011	losslessly compress images with pngout	vyznev	21:04, 7 December 2010
r78014	more lossless PNG compression with pngout	vyznev	21:11, 7 December 2010
r78015	a few more images compressed with pngout	vyznev	21:15, 7 December 2010
r78016	compress images with pngout for a couple more skins	vyznev	21:18, 7 December 2010
r78099	*Follow-up r76275: regexp improvement akin to IP.php...	aaron	22:33, 8 December 2010
r78117	Do not reveal page existence in colour of links in tabs when a user cannot re...	werdna	04:54, 9 December 2010
r78161	*Follow-up r78099,r76275:...	aaron	00:16, 10 December 2010
r78170	Fix regression in r78117 per CR, was causing read, edit and history tabs to d...	catrope	10:55, 10 December 2010
r78172	Followup r78117: information was still leaked through the caption of the Edit...	catrope	11:33, 10 December 2010
r78175	1.17: Back out Monobook-to-ResourceLoader port, has issues on IE6. This rever...	catrope	11:53, 10 December 2010
r78199	(bug 26130) ob_start( 'ob_gzhandler' ) in LocalSettings.php broke gzip output...	catrope	17:06, 10 December 2010
r78393	Do not access to mTouched internals of Article from a different module per r7...	platonides	17:49, 14 December 2010
r78506	Fixed RTL errors for SimpleSearch	tparscal	19:02, 16 December 2010
r78507	Fixed RTL errors for search suggestions	tparscal	19:03, 16 December 2010
r78510	Moved CSS flipping to occur inside a module - this resolves a bug which occur...	tparscal	19:31, 16 December 2010
r78511	Fixed right-to-left issues. This also depends on the patch to ResourceLoader ...	tparscal	19:32, 16 December 2010
r78536	Rm unused javascript added in r47637 (follow up to r47569) and not reverted w...	happy-melon	16:04, 17 December 2010
r78544	Added anonymous function to mediaWiki.user	tparscal	19:18, 17 December 2010
r78565	Follow-up r75476: Windows set command treats everything until the && as part ...	btongminh	15:00, 18 December 2010
r78660	Actually skip invalid titles in XML dumps, don't just say you're going to. Av...	tstarling	02:57, 21 December 2010
r78679	Fix the bug when a math image was contained by an "<a>" tag, there will be ex...	philip	15:27, 21 December 2010
r78774	Rewrite install steps again (cleanup r76390)...	demon	05:21, 22 December 2010
r78808	(bug 26395) Change name of Cornish language to Kernowek	catrope	17:20, 22 December 2010
r78887	Fix JS errors thrown by SimpleSearch: add dependency from jquery.autoEllipsis...	catrope	14:16, 23 December 2010
r78926	(bug 26399) Preload module info for all modules in startup module, to prevent...	catrope	21:01, 23 December 2010
r78943	Really fix bug 26131: just putting the site+user <link> at the bottom of the ...	catrope	01:22, 24 December 2010
r79013	(Bug 26425) Due to r71751, wfTimestamp stopped accepting '' to mean get ...	bawolff	04:38, 26 December 2010
r79018	Store the options used by the parsing in ParserOutput, per r70783 CR.	platonides	19:21, 26 December 2010
r79019	Remove ParserOptions clonations, already cloned in getParserOptions()....	platonides	19:23, 26 December 2010
r79034	Revert r75588 and r77381. Block just the tainted pairs of username/passwords ...	platonides	22:55, 26 December 2010
r79072	(Bug 26434) - Generated password from "Create account by email" does not work....	platonides	17:17, 27 December 2010
r79115	This precondition is no longer needed after r78393	platonides	18:15, 28 December 2010

Comments

#Comment by Dantman (talk | contribs) 15:07, 31 December 2010

This commit re-introduces code which was reverted from REL1_17 in r78017, but breaks the branch because while the code in Vector.php that uses BaseTemplate was re-introduced, the actual BaseTemplate implementation was never re-introduced into SkinTemplate.php...

#Comment by Catrope (talk | contribs) 15:37, 31 December 2010

I'm working on fixing this right now.

Another issue with this commit: it only merges to phase3, not to extensions

#Comment by Catrope (talk | contribs) 15:52, 31 December 2010

Fixed the Vector breakage in r79340 and r79341.

#Comment by Platonides (talk | contribs) 15:57, 31 December 2010

Right. I merged just phase3. That's the reason for doing r79134 separatedly. Reviewing the "merged" revisions, a couple of them had changes in extensions, not taken into account in this merge. Fixed in r79343.

#Comment by Catrope (talk | contribs) 16:04, 31 December 2010

r78544 wasn't merged right, but since it's unneeded and causes conflicts, let's drop it.

#Comment by Catrope (talk | contribs) 16:10, 31 December 2010

I've looked through all the linked revisions, and this merge seems to be complete now.

Status & tagging log

23:02, 29 December 2010 Catrope (talk | contribs) changed the status of r79129 [removed: new added: ok]