r78506 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78505‎ | r78506 | r78507 >
Date:19:02, 16 December 2010
Author:tparscal
Status:ok
Tags:
Comment:
Fixed RTL errors for SimpleSearch
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -702,9 +702,13 @@
703703 <input type='hidden' name="title" value="<?php $this->text( 'searchtitle' ) ?>"/>
704704 <?php if ( $wgVectorUseSimpleSearch && $wgUser->getOption( 'vector-simplesearch' ) ): ?>
705705 <div id="simpleSearch">
 706+ <?php if ( $this->data['rtl'] ): ?>
 707+ <?php echo $this->makeSearchButton("image", array( "id" => "searchButton", "src" => $this->skin->getSkinStylePath('images/search-rtl.png') )); ?>
 708+ <?php endif; ?>
706709 <?php echo $this->makeSearchInput(array( "id" => "searchInput", "type" => "text" )); ?>
707 - <?php echo $this->makeSearchButton("image", array( "id" => "searchButton",
708 - "src" => $this->skin->getSkinStylePath('images/search-' . ( $this->data['rtl'] ? 'rtl' : 'ltr' ) . '.png') )); ?>
 710+ <?php if ( !$this->data['rtl'] ): ?>
 711+ <?php echo $this->makeSearchButton("image", array( "id" => "searchButton", "src" => $this->skin->getSkinStylePath('images/search-ltr.png') )); ?>
 712+ <?php endif; ?>
709713 </div>
710714 <?php else: ?>
711715 <?php echo $this->makeSearchInput(array( "id" => "searchInput" )); ?>
Index: trunk/phase3/skins/vector/screen.css
@@ -388,6 +388,7 @@
389389 font-size: 13px;
390390 width: 14em;
391391 background-color: transparent;
 392+ direction: ltr;
392393 }
393394 /* OVERRIDDEN BY COMPLIANT BROWSERS */
394395 div#simpleSearch button#searchButton {

Follow-up revisions

RevisionCommit summaryAuthorDate
r79129MFT r78011 r78014 r78015 r78016 r78099 r78117 r78161 r78170 r78172 r78199 r78......platonides19:58, 28 December 2010
r79341Follow-up r79340: merge r78117, r78170, r78172 and r78506 from trunk into ski...catrope15:48, 31 December 2010

Status & tagging log