r79342 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79341‎ | r79342 | r79343 >
Date:15:52, 31 December 2010
Author:catrope
Status:ok
Tags:
Comment:
Merge mediawiki.js changes from r78943 that were overlooked in r79129
Modified paths:
  • /branches/REL1_17/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: branches/REL1_17/phase3/resources/mediawiki/mediawiki.js
@@ -323,6 +323,8 @@
324324 var suspended = true;
325325 // Flag inidicating that document ready has occured
326326 var ready = false;
 327+ // Marker element for adding dynamic styles
 328+ var $marker = $( 'head meta[name=ResourceLoaderDynamicStyles]' );
327329
328330 /* Private Methods */
329331
@@ -480,16 +482,15 @@
481483 }
482484 // Add style sheet to document
483485 if ( typeof registry[module].style === 'string' && registry[module].style.length ) {
484 - $( 'head' )
485 - .append( mediaWiki.html.element( 'style',
486 - { type: "text/css" },
 486+ $marker.before( mediaWiki.html.element( 'style',
 487+ { type: 'text/css' },
487488 new mediaWiki.html.Cdata( registry[module].style )
488489 ) );
489490 } else if ( typeof registry[module].style === 'object'
490491 && !( registry[module].style instanceof Array ) )
491492 {
492493 for ( var media in registry[module].style ) {
493 - $( 'head' ).append( mediaWiki.html.element( 'style',
 494+ $marker.before( mediaWiki.html.element( 'style',
494495 { type: 'text/css', media: media },
495496 new mediaWiki.html.Cdata( registry[module].style[media] )
496497 ) );
Property changes on: branches/REL1_17/phase3/resources/mediawiki/mediawiki.js
___________________________________________________________________
Added: svn:mergeinfo
497498 Merged /branches/sqlite/resources/mediawiki/mediawiki.js:r58211-58321
498499 Merged /trunk/phase3/resources/mediawiki/mediawiki.js:r78943
499500 Merged /branches/new-installer/phase3/resources/mediawiki/mediawiki.js:r43664-66004
500501 Merged /branches/REL1_15/phase3/resources/mediawiki/mediawiki.js:r51646

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78943Really fix bug 26131: just putting the site+user <link> at the bottom of the ...catrope01:22, 24 December 2010
r79129MFT r78011 r78014 r78015 r78016 r78099 r78117 r78161 r78170 r78172 r78199 r78......platonides19:58, 28 December 2010

Status & tagging log