r82316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r82315‎ | r82316 | r82317 >
Date:02:05, 17 February 2011
Author:juliano
Status:deferred
Tags:
Comment:
Parser::clearState() is no longer safe in 1.17a (since r79129) if Parser
doesn't contain a ParserOptions object.
Modified paths:
  • /trunk/extensions/Wikilog/WikilogCommentPager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikilog/WikilogCommentPager.php
——@@ -85,11 +85,6 @@
8686 # This is too expensive, limit listing.
8787 if ( $this->mLimit > $wgWikilogExpensiveLimit )
8888 $this->mLimit = $wgWikilogExpensiveLimit;
89 -
90 - # We will need a clean parser if not including.
91 - if ( !$this->mIncluding ) {
92 - $wgParser->clearState();
93 - }
9489 }
9590
9691 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r83228Get rid of another Parser::clearState() (followup r82316).juliano18:40, 4 March 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79129MFT r78011 r78014 r78015 r78016 r78099 r78117 r78161 r78170 r78172 r78199 r78......platonides19:58, 28 December 2010

Status & tagging log