r78660 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78659‎ | r78660 | r78661 >
Date:02:57, 21 December 2010
Author:tstarling
Status:ok
Tags:
Comment:
Actually skip invalid titles in XML dumps, don't just say you're going to. Avoids fatal error.
Modified paths:
  • /trunk/phase3/includes/ImportXMLReader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImportXMLReader.php
@@ -619,9 +619,10 @@
620620 if( is_null( $title ) ) {
621621 // Invalid page title? Ignore the page
622622 $this->notice( "Skipping invalid page title '$workTitle'" );
 623+ return false;
623624 } elseif( $title->getInterwiki() != '' ) {
624625 $this->notice( "Skipping interwiki page title '$workTitle'" );
625 - $title = null;
 626+ return false;
626627 }
627628
628629 return array( $origTitle, $title );

Follow-up revisions

RevisionCommit summaryAuthorDate
r79129MFT r78011 r78014 r78015 r78016 r78099 r78117 r78161 r78170 r78172 r78199 r78......platonides19:58, 28 December 2010

Status & tagging log