r79019 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r79018‎ | r79019 | r79020 >
Date:19:23, 26 December 2010
Author:platonides
Status:ok
Tags:
Comment:
Remove ParserOptions clonations, already cloned in getParserOptions().
Ref r70783
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -1499,7 +1499,7 @@
15001500 public function tryDirtyCache() {
15011501 global $wgOut;
15021502 $parserCache = ParserCache::singleton();
1503 - $options = clone $this->getParserOptions();
 1503+ $options = $this->getParserOptions();
15041504
15051505 if ( $wgOut->isPrintable() ) {
15061506 $options->setIsPrintable( true );
@@ -3597,7 +3597,7 @@
35983598 $edit->revid = $revid;
35993599 $edit->newText = $text;
36003600 $edit->pst = $this->preSaveTransform( $text );
3601 - $edit->popts = clone $this->getParserOptions();
 3601+ $edit->popts = $this->getParserOptions();
36023602 $edit->output = $wgParser->parse( $edit->pst, $this->mTitle, $edit->popts, true, true, $revid );
36033603 $edit->oldText = $this->getContent();
36043604
@@ -4405,7 +4405,7 @@
44064406 global $wgParser, $wgEnableParserCache, $wgUseFileCache;
44074407
44084408 if ( !$parserOptions ) {
4409 - $parserOptions = clone $this->getParserOptions();
 4409+ $parserOptions = $this->getParserOptions();
44104410 }
44114411
44124412 $time = - wfTime();

Follow-up revisions

RevisionCommit summaryAuthorDate
r79129MFT r78011 r78014 r78015 r78016 r78099 r78117 r78161 r78170 r78172 r78199 r78......platonides19:58, 28 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70783Use only the page relevant pieces in the parser cache key. Eg. two users with...platonides21:53, 9 August 2010

Status & tagging log