r78511 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78510‎ | r78511 | r78512 >
Date:19:32, 16 December 2010
Author:tparscal
Status:ok
Tags:
Comment:
Fixed right-to-left issues. This also depends on the patch to ResourceLoader made in r78510
Modified paths:
  • /trunk/extensions/Vector/modules/ext.vector.collapsibleNav.css (modified) (history)
  • /trunk/extensions/Vector/modules/images/arrow-down.png (deleted) (history)
  • /trunk/extensions/Vector/modules/images/arrow-left.png (deleted) (history)
  • /trunk/extensions/Vector/modules/images/arrow-right.png (deleted) (history)
  • /trunk/extensions/Vector/modules/images/closed-ltr.png (added) (history)
  • /trunk/extensions/Vector/modules/images/closed-rtl.png (added) (history)
  • /trunk/extensions/Vector/modules/images/open.png (added) (history)

Diff [purge]

Index: trunk/extensions/Vector/modules/ext.vector.collapsibleNav.css
@@ -1,39 +1,26 @@
22 /* Prototype code to show collapsing left nav options */
33 #mw-panel.collapsible-nav div.portal {
44 /* @embed */
5 - background-image:url(images/portal-break.png?1);
 5+ background-image:url(images/portal-break.png);
66 background-position:left top;
77 background-repeat:no-repeat;
88 padding: 0.25em 0 !important;
99 margin: -11px 9px 10px 11px;
1010 }
11 -body.rtl #mw-panel.collapsible-nav div.portal {
12 - background-position: right top;
13 - margin: -11px 11px 10px 9px;
14 -}
1511 #mw-panel.collapsible-nav div.portal h5 {
1612 color: #4D4D4D;
1713 font-weight: normal;
1814 /* @embed */
19 - background: url(images/arrow-down.png?1) 0 50% no-repeat;
 15+ background: url(images/open.png) left center no-repeat;
2016 padding: 4px 0 3px 1.5em;
2117 margin-bottom: 0px;
2218 }
23 -body.rtl #mw-panel.collapsible-nav div.portal h5 {
24 - /* @embed */
25 - background: url(images/arrow-down.png?1) 100% 50% no-repeat;
26 - padding: 4px 1.5em 3px 0;
27 -}
2819 #mw-panel.collapsible-nav div.collapsed h5 {
2920 color: #0645AD;
3021 /* @embed */
31 - background: url(images/arrow-right.png?1) 0 50% no-repeat;
 22+ background: url(images/closed-ltr.png) left center no-repeat;
3223 margin-bottom: 0px;
3324 }
34 -body.rtl #mw-panel.collapsible-nav div.collapsed h5 {
35 - /* @embed */
36 - background: url(images/arrow-left.png?1) 100% 50% no-repeat;
37 -}
3825 #mw-panel.collapsible-nav div h5:hover {
3926 cursor: pointer;
4027 text-decoration: none;
@@ -66,8 +53,4 @@
6754 }
6855 #mw-panel.collapsible-nav div.persistent div.body {
6956 margin-left: 0.5em;
70 -}
71 -body.rtl #mw-panel.collapsible-nav div.persistent div.body {
72 - margin-left: 0;
73 - margin-right: 0.5em;
74 -}
 57+}
\ No newline at end of file
Index: trunk/extensions/Vector/modules/images/arrow-down.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Vector/modules/images/arrow-left.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Vector/modules/images/arrow-right.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Index: trunk/extensions/Vector/modules/images/open.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/Vector/modules/images/open.png
___________________________________________________________________
Added: svn:mime-type
7558 + image/png
Index: trunk/extensions/Vector/modules/images/closed-ltr.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/Vector/modules/images/closed-ltr.png
___________________________________________________________________
Added: svn:mime-type
7659 + image/png
Index: trunk/extensions/Vector/modules/images/closed-rtl.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/extensions/Vector/modules/images/closed-rtl.png
___________________________________________________________________
Added: svn:mime-type
7760 + image/png

Follow-up revisions

RevisionCommit summaryAuthorDate
r79129MFT r78011 r78014 r78015 r78016 r78099 r78117 r78161 r78170 r78172 r78199 r78......platonides19:58, 28 December 2010
r79343MFT r78161 and r78511, incorrectly stated as merged in r79129....platonides15:56, 31 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r78510Moved CSS flipping to occur inside a module - this resolves a bug which occur...tparscal19:31, 16 December 2010

Status & tagging log