r78536 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r78535‎ | r78536 | r78537 >
Date:16:04, 17 December 2010
Author:happy-melon
Status:ok (Comments)
Tags:
Comment:
Rm unused javascript added in r47637 (follow up to r47569) and not reverted with the rest of it in r48780.
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/skins/common/changepassword.js (deleted) (history)

Diff [purge]

Index: trunk/phase3/skins/common/changepassword.js
@@ -1,16 +0,0 @@
2 -
3 -window.onNameChange = function() {
4 - if ( wgUserName == document.getElementById('wpName').value ) {
5 - document.getElementById('wpPassword').disabled = false;
6 - document.getElementById('wpComment').disabled = true;
7 - } else {
8 - document.getElementById('wpPassword').disabled = true;
9 - document.getElementById('wpComment').disabled = false;
10 - }
11 -};
12 -
13 -window.onNameChangeHook = function() {
14 - document.getElementById( 'wpName' ).onblur = onNameChange;
15 -};
16 -
17 -addOnloadHook( onNameChangeHook );
Index: trunk/phase3/resources/Resources.php
@@ -416,10 +416,6 @@
417417 'scripts' => 'skins/common/block.js',
418418 'dependencies' => 'mediawiki.legacy.wikibits',
419419 ),
420 - 'mediawiki.legacy.changepassword' => array(
421 - 'scripts' => 'skins/common/changepassword.js',
422 - 'dependencies' => 'mediawiki.legacy.wikibits',
423 - ),
424420 'mediawiki.legacy.commonPrint' => array(
425421 'styles' => array( 'skins/common/commonPrint.css' => array( 'media' => 'print' ) ),
426422 ),

Follow-up revisions

RevisionCommit summaryAuthorDate
r79129MFT r78011 r78014 r78015 r78016 r78099 r78117 r78161 r78170 r78172 r78199 r78......platonides19:58, 28 December 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r47569ChangePassword fixes:...demon18:35, 20 February 2009
r47637Add logging to password resets per request on code review. Also a little java...demon22:27, 21 February 2009
r48780Revert r47569 and subsequent related revisions. These still break logging in ...werdna02:27, 25 March 2009

Comments

#Comment by 😂 (talk | contribs)   16:09, 17 December 2010

lol whoops

Status & tagging log