r103693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r103692‎ | r103693 | r103694 >
Date:17:21, 19 November 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r103685

Not sure why I reinvented the wheel. Oh well, doing it properly now
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/MysqlUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/OracleUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/SqliteUpdater.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -666,18 +666,4 @@
667667 $cl->execute();
668668 $this->output( "Rebuilding localisation cache done.\n" );
669669 }
670 -
671 - /**
672 - * Increases the length of the user_group field
673 - */
674 - protected function doIncreaseUserGroupLength() {
675 - $this->output( 'Increasing the length of the user_group...' );
676 - if ( $this->updateRowExists( 'user_groups_length' ) ) {
677 - $this->output( "...user_groups field is already long enough.\n" );
678 - return;
679 - }
680 - $this->applyPatch( 'patch-ug_group-length-increase.sql' );
681 - $this->insertUpdateRow( 'user_groups_length' );
682 - $this->output( "done.\n" );
683 - }
684670 }
Index: trunk/phase3/includes/installer/MysqlUpdater.php
@@ -190,7 +190,7 @@
191191 array( 'addField', 'revision', 'rev_sha1', 'patch-rev_sha1.sql' ),
192192 array( 'addField', 'archive', 'ar_sha1', 'patch-ar_sha1.sql' ),
193193 array( 'addIndex', 'page', 'page_redirect_namespace_len', 'patch-page_redirect_namespace_len.sql' ),
194 - array( 'doIncreaseUserGroupLength' ),
 194+ array( 'modifyField', 'user', 'ug_group', 'patch-ug_group-length-increase.sql' ),
195195 );
196196 }
197197
Index: trunk/phase3/includes/installer/OracleUpdater.php
@@ -47,7 +47,7 @@
4848 array( 'addField', 'archive', 'ar_sha1', 'patch-ar_sha1_field.sql' ),
4949 array( 'doRemoveNotNullEmptyDefaults2' ),
5050 array( 'addIndex', 'page', 'i03', 'patch-page_redirect_namespace_len.sql' ),
51 - array( 'doIncreaseUserGroupLength' ),
 51+ array( 'modifyField', 'user', 'ug_group', 'patch-ug_group-length-increase.sql' ),
5252
5353 // till 2.0 i guess
5454 array( 'doRebuildDuplicateFunction' ),
Index: trunk/phase3/includes/installer/SqliteUpdater.php
@@ -68,7 +68,7 @@
6969 array( 'addField', 'revision', 'rev_sha1', 'patch-rev_sha1.sql' ),
7070 array( 'addField', 'archive', 'ar_sha1', 'patch-ar_sha1.sql' ),
7171 array( 'addIndex', 'page', 'page_redirect_namespace_len', 'patch-page_redirect_namespace_len.sql' ),
72 - array( 'doIncreaseUserGroupLength' ),
 72+ array( 'modifyField', 'user', 'ug_group', 'patch-ug_group-length-increase.sql' ),
7373
7474 );
7575 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103685* (bug 32470) Increase the length of ug_group...reedy16:26, 19 November 2011

Status & tagging log