r103696 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r103695‎ | r103696 | r103697 >
Date:17:34, 19 November 2011
Author:hashar
Status:ok
Tags:
Comment:
MFT in REL1_18 r103694

(bug 32228) Special:Search doesn't conserve profile when new search terms
are entered.

It is a 1.18 regression
Modified paths:
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
——@@ -11,6 +11,9 @@
1212 know what you think of it. Beta releases are not recommended for use in
1313 production.
1414
 15+=== Changes since 1.18 RC1 ===
 16+* (bug 32228) regression in Special:Search which did not conserve profile on new search
 17+
1518 === Changes since 1.18 beta 1 ===
1619 * (bug 31886) Wrong titles redirecting to Special:Badtitle in the 1.18 deployment.
1720 * (bug 32051) Fix description for wlprop=sizes.
Index: branches/REL1_18/phase3/includes/specials/SpecialSearch.php
——@@ -1020,7 +1020,8 @@
10211021 }
10221022
10231023 protected function shortDialog( $term ) {
1024 - $out = Html::hidden( 'title', $this->getTitle()->getPrefixedText() ) . "\n";
 1024+ $out = Html::hidden( 'title', $this->getTitle()->getPrefixedText() );
 1025+ $out .= Html::hidden( 'profile', $this->profile ) . "\n";
10251026 // Term box
10261027 $out .= Html::input( 'search', $term, 'search', array(
10271028 'id' => $this->profile === 'advanced' ? 'powerSearchText' : 'searchText',
Property changes on: branches/REL1_18/phase3/includes/specials/SpecialSearch.php
___________________________________________________________________
Added: svn:mergeinfo
10281029 Merged /branches/wmf-deployment/includes/specials/SpecialSearch.php:r53381,56967
10291030 Merged /branches/REL1_15/phase3/includes/specials/SpecialSearch.php:r51646
10301031 Merged /branches/wmf/1.18wmf1/includes/specials/SpecialSearch.php:r99004,99065
10311032 Merged /branches/sqlite/includes/specials/SpecialSearch.php:r58211-58321
10321033 Merged /trunk/phase3/includes/specials/SpecialSearch.php:r92580,92634,92713,92762,92765,92791,92854,92884,92886-92887,92894,92898,92907,92932,92958,93141,93149,93151,93233-93234,93258,93266,93303,93516-93518,93726,93818-93822,93847,93858,93891,93935-93936,94058,94062,94068,94107,94155,94199,94235,94346,94372,94422,94425,94444,94448,94456,94498,94601,94630,94728,94825,94862,94995-94997,95042,95155,95332,95410,95442,95468,95601,95812,96437-96438,97175,97806,97895,98193-98194,98235,98237,98298,98374,98502,98610,98656,98707,98713,98716,98718-98720,98774,98812,98927,98975,98990,99081-99082,99102,99104,99126,99135-99136,99138,99172,99250,99252,99254,99318,99323,99349,99630,99700,99914,99931,99952,100239,100242,100347,100510,100572,100592,101470,101476,101666,101860,101990,102334-102335,103694

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r103694(bug 32228) Special:Search doesn't conserve profile when new search terms are...catrope17:27, 19 November 2011

Status & tagging log