r99721 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99720‎ | r99721 | r99722 >
Date:19:33, 13 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Bug 31050 - Cleanup duplicate CSS for mobile devices

Move table[style] and table.navbox td.navbox-group

So far, about 35 KB saved by refactoring out all the complete duplicate blocks of CSS
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/kindle.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
——@@ -38,12 +38,6 @@
3939 padding: 3px;
4040 }
4141
42 -table.navbox td.navbox-group {
43 - background: #ddddff;
44 - width: 25%;
45 - padding: 3px;
46 -}
47 -
4842 table.navbox td.navbox-group + td {
4943 padding: 3px;
5044 }
——@@ -73,12 +67,6 @@
7468 background: #f3f3f3;
7569 }
7670
77 -table[style] {
78 - width: 100% !important;
79 - float: none !important;
80 - margin-left: 0 !important;
81 -}
82 -
8371 table.infobox {
8472 background: #f9f9f9;
8573 }
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
——@@ -72,3 +72,14 @@
7373 border-bottom: 1px solid #cccccc;
7474 }
7575
 76+table[style] {
 77+ width: 100% !important;
 78+ float: none !important;
 79+ margin-left: 0 !important;
 80+}
 81+
 82+table.navbox td.navbox-group {
 83+ background: #ddddff;
 84+ width: 25%;
 85+ padding: 3px;
 86+}
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/kindle.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
——@@ -33,12 +33,6 @@
3434 padding: 3px;
3535 }
3636
37 -table.navbox td.navbox-group {
38 - background: #ddddff;
39 - width: 25%;
40 - padding: 3px;
41 -}
42 -
4337 table.navbox td.navbox-group + td {
4438 padding: 3px;
4539 }
——@@ -68,12 +62,6 @@
6963 background: #f3f3f3;
7064 }
7165
72 -table[style] {
73 - width: 100% !important;
74 - float: none !important;
75 - margin-left: 0 !important;
76 -}
77 -
7866 table.infobox {
7967 background: #f9f9f9;
8068 }
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
——@@ -29,12 +29,6 @@
3030 padding: 3px;
3131 }
3232
33 -table.navbox td.navbox-group {
34 - background: #ddddff;
35 - width: 25%;
36 - padding: 3px;
37 -}
38 -
3933 table.navbox td.navbox-group + td {
4034 padding: 3px;
4135 }
——@@ -64,12 +58,6 @@
6559 background: #f3f3f3;
6660 }
6761
68 -table[style] {
69 - width: 100% !important;
70 - float: none !important;
71 - margin-left: 0 !important;
72 -}
73 -
7462 table.infobox {
7563 background: #f9f9f9;
7664 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r99723Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:51, 13 October 2011
r99758Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy08:00, 14 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99656Add common.css...reedy23:27, 12 October 2011
r99657Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:32, 12 October 2011
r99658Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:36, 12 October 2011
r99659Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:43, 12 October 2011
r99660Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:50, 12 October 2011
r99661Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:59, 12 October 2011
r99719Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:18, 13 October 2011

Status & tagging log