r99659 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99658‎ | r99659 | r99660 >
Date:23:43, 12 October 2011
Author:reedy
Status:reverted
Tags:
Comment:
Part of Bug 31050 - Cleanup duplicate CSS for mobile devices

Moved .divclearable and table
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/kindle.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -263,14 +256,3 @@
264257 #search:focus {
265258 outline: none;
266259 }
267 -
268 -.divclearable {
269 - border: 1px solid #888;
270 - display: -moz-inline-stack;
271 - display: inline-block;
272 - zoom:1;
273 - *display:inline;
274 - vertical-align:middle;
275 - height: 1.5em;
276 - position: relative;
277 -}
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
——@@ -1,28 +1,48 @@
22 #search {
3 - -webkit-appearance: none;
4 - border-top-width: 0px;
5 - border-right-width: 0px;
6 - border-bottom-width: 0px;
7 - border-left-width: 0px;
8 - outline-style: none;
9 - outline-width: initial;
10 - outline-color: initial;
11 - height: 1.4em;
 3+ -webkit-appearance: none;
 4+ border-top-width: 0px;
 5+ border-right-width: 0px;
 6+ border-bottom-width: 0px;
 7+ border-left-width: 0px;
 8+ outline-style: none;
 9+ outline-width: initial;
 10+ outline-color: initial;
 11+ height: 1.4em;
1212 }
1313
1414 .clearlink {
15 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
16 - background-position: center center;
17 - cursor: pointer;
18 - zoom:1;
19 - position: absolute;
20 - right: 0.25em;
21 - top: 50%;
22 - margin: 1px;
23 - height: 12px;
24 - width: 12px;
25 - margin-top: -6px;
26 - z-index: 2;
27 - border: 0px solid;
28 - display: none;
 15+ background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
 16+ background-position: center center;
 17+ cursor: pointer;
 18+ zoom:1;
 19+ position: absolute;
 20+ right: 0.25em;
 21+ top: 50%;
 22+ margin: 1px;
 23+ height: 12px;
 24+ width: 12px;
 25+ margin-top: -6px;
 26+ z-index: 2;
 27+ border: 0px solid;
 28+ display: none;
 29+}
 30+
 31+.divclearable {
 32+ border: 1px solid #888;
 33+ display: -moz-inline-stack;
 34+ display: inline-block;
 35+ zoom:1;
 36+ *display:inline;
 37+ vertical-align:middle;
 38+ height: 1.5em;
 39+ position: relative;
 40+}
 41+
 42+table {
 43+ border-spacing: 0 !important;
 44+ width: 100%;
 45+ border-collapse: collapse !important;
 46+ border: 1px solid #cccccc;
 47+ padding: 3px;
 48+ margin-bottom: 15px;
2949 }
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -304,13 +297,3 @@
305298 outline: none;
306299 }
307300
308 -.divclearable {
309 - border: 1px solid #888;
310 - display: -moz-inline-stack;
311 - display: inline-block;
312 - zoom:1;
313 - *display:inline;
314 - vertical-align:middle;
315 - height: 1.5em;
316 - position: relative;
317 -}
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -292,13 +285,3 @@
293286 outline: none;
294287 }
295288
296 -.divclearable {
297 - border: 1px solid #888;
298 - display: -moz-inline-stack;
299 - display: inline-block;
300 - zoom:1;
301 - *display:inline;
302 - vertical-align:middle;
303 - height: 1.5em;
304 - position: relative;
305 -}
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -281,13 +274,3 @@
282275 outline: none;
283276 }
284277
285 -.divclearable {
286 - border: 1px solid #888;
287 - display: -moz-inline-stack;
288 - display: inline-block;
289 - zoom:1;
290 - *display:inline;
291 - vertical-align:middle;
292 - height: 1.5em;
293 - position: relative;
294 -}
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -281,13 +274,3 @@
282275 outline: none;
283276 }
284277
285 -.divclearable {
286 - border: 1px solid #888;
287 - display: -moz-inline-stack;
288 - display: inline-block;
289 - zoom:1;
290 - *display:inline;
291 - vertical-align:middle;
292 - height: 1.5em;
293 - position: relative;
294 -}
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -334,13 +327,3 @@
335328 outline: none;
336329 }
337330
338 -.divclearable {
339 - border: 1px solid #888;
340 - display: -moz-inline-stack;
341 - display: inline-block;
342 - zoom:1;
343 - *display:inline;
344 - vertical-align:middle;
345 - height: 1.5em;
346 - position: relative;
347 -}
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -280,14 +273,3 @@
281274 #search:focus {
282275 outline: none;
283276 }
284 -
285 -.divclearable {
286 - border: 1px solid #888;
287 - display: -moz-inline-stack;
288 - display: inline-block;
289 - zoom:1;
290 - *display:inline;
291 - vertical-align:middle;
292 - height: 1.5em;
293 - position: relative;
294 -}
Index: trunk/extensions/MobileFrontend/stylesheets/kindle.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -97,13 +90,3 @@
9891 outline: none;
9992 }
10093
101 -.divclearable {
102 - border: 1px solid #888;
103 - display: -moz-inline-stack;
104 - display: inline-block;
105 - zoom:1;
106 - *display:inline;
107 - vertical-align:middle;
108 - height: 1.5em;
109 - position: relative;
110 -}
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -278,13 +271,3 @@
279272 outline: none;
280273 }
281274
282 -.divclearable {
283 - border: 1px solid #888;
284 - display: -moz-inline-stack;
285 - display: inline-block;
286 - zoom:1;
287 - *display:inline;
288 - vertical-align:middle;
289 - height: 1.5em;
290 - position: relative;
291 -}
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
——@@ -1,13 +1,6 @@
22 #blackberry {
33 test: 1; }
44
5 -table {
6 - border-spacing: 0 !important;
7 - width: 100%;
8 - border-collapse: collapse !important;
9 - border: 1px solid #cccccc;
10 - padding: 3px;
11 - margin-bottom: 15px; }
125 table td, table th {
136 border: 1px solid #cccccc;
147 padding: 3px; }
——@@ -281,13 +274,3 @@
282275 outline: none;
283276 }
284277
285 -.divclearable {
286 - border: 1px solid #888;
287 - display: -moz-inline-stack;
288 - display: inline-block;
289 - zoom:1;
290 - *display:inline;
291 - vertical-align:middle;
292 - height: 1.5em;
293 - position: relative;
294 -}
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -307,13 +300,3 @@
308301 outline: none;
309302 }
310303
311 -.divclearable {
312 - border: 1px solid #888;
313 - display: -moz-inline-stack;
314 - display: inline-block;
315 - zoom:1;
316 - *display:inline;
317 - vertical-align:middle;
318 - height: 1.5em;
319 - position: relative;
320 -}
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -307,13 +300,3 @@
308301 outline: none;
309302 }
310303
311 -.divclearable {
312 - border: 1px solid #888;
313 - display: -moz-inline-stack;
314 - display: inline-block;
315 - zoom:1;
316 - *display:inline;
317 - vertical-align:middle;
318 - height: 1.5em;
319 - position: relative;
320 -}
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -289,13 +282,3 @@
290283 outline: none;
291284 }
292285
293 -.divclearable {
294 - border: 1px solid #888;
295 - display: -moz-inline-stack;
296 - display: inline-block;
297 - zoom:1;
298 - *display:inline;
299 - vertical-align:middle;
300 - height: 1.5em;
301 - position: relative;
302 -}
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -265,14 +258,3 @@
266259 #search:focus {
267260 outline: none;
268261 }
269 -
270 -.divclearable {
271 - border: 1px solid #888;
272 - display: -moz-inline-stack;
273 - display: inline-block;
274 - zoom:1;
275 - *display:inline;
276 - vertical-align:middle;
277 - height: 1.5em;
278 - position: relative;
279 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
——@@ -1,10 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px; }
92 table td, table th {
103 border: 1px solid #cccccc;
114 padding: 3px; }
——@@ -278,13 +271,3 @@
279272 outline: none;
280273 }
281274
282 -.divclearable {
283 - border: 1px solid #888;
284 - display: -moz-inline-stack;
285 - display: inline-block;
286 - zoom:1;
287 - *display:inline;
288 - vertical-align:middle;
289 - height: 1.5em;
290 - position: relative;
291 -}

Follow-up revisions

RevisionCommit summaryAuthorDate
r99660Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:50, 12 October 2011
r99661Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:59, 12 October 2011
r99719Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:18, 13 October 2011
r99721Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:33, 13 October 2011
r99723Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:51, 13 October 2011
r99758Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy08:00, 14 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99656Add common.css...reedy23:27, 12 October 2011
r99657Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:32, 12 October 2011
r99658Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:36, 12 October 2011

Status & tagging log