r99661 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99660‎ | r99661 | r99662 >
Date:23:59, 12 October 2011
Author:reedy
Status:reverted
Tags:
Comment:
Part of Bug 31050 - Cleanup duplicate CSS for mobile devices

Moved table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"], table[style] and table.gallery th, table.gallery td
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/kindle.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
@@ -64,4 +64,22 @@
6565 border: 0;
6666 padding: 0;
6767 margin-top: 5px;
 68+}
 69+
 70+table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
 71+ text-align: left !important;
 72+ margin-left: 0 !important;
 73+ margin-right: 0 !important;
 74+}
 75+
 76+table[style] {
 77+ width: 100% !important;
 78+ float: none !important;
 79+ margin-left: 0 !important;
 80+}
 81+
 82+table.gallery th, table.gallery td {
 83+ display: block;
 84+ border: 0;
 85+ border-bottom: 1px solid #cccccc;
6886 }
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
@@ -31,10 +31,6 @@
3232 margin-bottom: 0; }
3333 table.wikitable th {
3434 background: #f3f3f3; }
35 - table[style] {
36 - width: 100% !important;
37 - float: none !important;
38 - margin-left: 0 !important; }
3935 table.infobox {
4036 background: #f9f9f9; }
4137 table.infobox th, table.infobox td {
@@ -44,10 +40,6 @@
4541 table.gallery {
4642 background: #f9f9f9;
4743 border-bottom: 0; }
48 - table.gallery th, table.gallery td {
49 - display: block;
50 - border: 0;
51 - border-bottom: 1px solid #cccccc; }
5244 table.gallery .gallerybox[style] {
5345 width: auto !important;
5446 margin-bottom: -16px; }
@@ -56,10 +48,6 @@
5749 text-align: center; }
5850 table.geography[style] th {
5951 text-align: left; }
60 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
61 - text-align: left !important;
62 - margin-left: 0 !important;
63 - margin-right: 0 !important; }
6452 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6553 text-align: left !important; }
6654
Index: trunk/extensions/MobileFrontend/stylesheets/kindle.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
@@ -33,10 +33,6 @@
3434 margin-bottom: 0; }
3535 table.wikitable th {
3636 background: #f3f3f3; }
37 - table[style] {
38 - width: 100% !important;
39 - float: none !important;
40 - margin-left: 0 !important; }
4137 table.infobox {
4238 background: #f9f9f9; }
4339 table.infobox th, table.infobox td {
@@ -46,10 +42,6 @@
4743 table.gallery {
4844 background: #f9f9f9;
4945 border-bottom: 0; }
50 - table.gallery th, table.gallery td {
51 - display: block;
52 - border: 0;
53 - border-bottom: 1px solid #cccccc; }
5446 table.gallery .gallerybox[style] {
5547 width: auto !important;
5648 margin-bottom: -16px; }
@@ -58,10 +50,6 @@
5951 text-align: center; }
6052 table.geography[style] th {
6153 text-align: left; }
62 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
63 - text-align: left !important;
64 - margin-left: 0 !important;
65 - margin-right: 0 !important; }
6654 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6755 text-align: left !important; }
6856
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
@@ -30,10 +30,7 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
 34+
3835 table.infobox {
3936 background: #f9f9f9; }
4037 table.infobox th, table.infobox td {
@@ -43,10 +40,6 @@
4441 table.gallery {
4542 background: #f9f9f9;
4643 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5144 table.gallery .gallerybox[style] {
5245 width: auto !important;
5346 margin-bottom: -16px; }
@@ -55,10 +48,6 @@
5649 text-align: center; }
5750 table.geography[style] th {
5851 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6352 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6453 text-align: left !important; }
6554
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
@@ -30,10 +30,6 @@
3131 margin-bottom: 0; }
3232 table.wikitable th {
3333 background: #f3f3f3; }
34 - table[style] {
35 - width: 100% !important;
36 - float: none !important;
37 - margin-left: 0 !important; }
3834 table.infobox {
3935 background: #f9f9f9; }
4036 table.infobox th, table.infobox td {
@@ -43,10 +39,6 @@
4440 table.gallery {
4541 background: #f9f9f9;
4642 border-bottom: 0; }
47 - table.gallery th, table.gallery td {
48 - display: block;
49 - border: 0;
50 - border-bottom: 1px solid #cccccc; }
5143 table.gallery .gallerybox[style] {
5244 width: auto !important;
5345 margin-bottom: -16px; }
@@ -55,10 +47,6 @@
5648 text-align: center; }
5749 table.geography[style] th {
5850 text-align: left; }
59 - table.geography[style] td[style*="text-align"], table.geography[style] td[colspan="2"] {
60 - text-align: left !important;
61 - margin-left: 0 !important;
62 - margin-right: 0 !important; }
6351 table.geography[style] td[style*="text-align"] div[style], table.geography[style] td[colspan="2"] div[style] {
6452 text-align: left !important; }
6553

Follow-up revisions

RevisionCommit summaryAuthorDate
r99719Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:18, 13 October 2011
r99721Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:33, 13 October 2011
r99723Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:51, 13 October 2011
r99758Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy08:00, 14 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99656Add common.css...reedy23:27, 12 October 2011
r99657Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:32, 12 October 2011
r99658Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:36, 12 October 2011
r99659Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:43, 12 October 2011
r99660Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:50, 12 October 2011

Status & tagging log