r99660 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r99659‎ \| r99660 \| r99661 >
Date:	23:50, 12 October 2011
Author:	reedy
Status:	reverted
Tags:
Comment:	Part of Bug 31050 - Cleanup duplicate CSS for mobile devices Moved table.gallery .thumb[style], table.navbox td.navbox-group and table.toc h2
Modified paths:	/trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/kindle.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history) /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
—	—	@@ -45,4 +45,23 @@
46	46	border: 1px solid #cccccc;
47	47	padding: 3px;
48	48	margin-bottom: 15px;
	49	+}
	50	+
	51	+table.gallery .thumb[style] {
	52	+ border: 0;
	53	+ padding: 0 !important;
	54	+ width: auto !important;
	55	+ margin: 0 auto;
	56	+}
	57	+
	58	+table.navbox td.navbox-group {
	59	+ background: #ddddff;
	60	+ width: 25%;
	61	+ padding: 3px;
	62	+}
	63	+
	64	+table.toc h2 {
	65	+ border: 0;
	66	+ padding: 0;
	67	+ margin-top: 5px;
49	68	}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
—	—	@@ -7,10 +7,7 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
	11	+
15	12	table.navbox {
16	13	font-size: 0.9em;
17	14	width: 100% !important; }
—	—	@@ -19,10 +16,6 @@
20	17	padding: 5px; }
21	18	table.navbox td.navbox-abovebelow {
22	19	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	20	table.navbox td.navbox-group + td {
28	21	padding: 3px; }
29	22	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +51,6 @@
59	52	table.gallery .gallerybox[style] {
60	53	width: auto !important;
61	54	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	55	table.gallery .gallerytext {
68	56	margin-top: -12px;
69	57	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/kindle.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
—	—	@@ -10,10 +10,6 @@
11	11	border: 0; }
12	12	table.toc {
13	13	background: #f9f9f9; }
14		~~- table.toc h2 {~~
15		~~- border: 0;~~
16		~~- padding: 0;~~
17		~~- margin-top: 5px; }~~
18	14	table.navbox {
19	15	font-size: 0.9em;
20	16	width: 100% !important; }
—	—	@@ -22,10 +18,6 @@
23	19	padding: 5px; }
24	20	table.navbox td.navbox-abovebelow {
25	21	padding: 3px; }
26		~~- table.navbox td.navbox-group {~~
27		~~- background: #ddddff;~~
28		~~- width: 25%;~~
29		~~- padding: 3px; }~~
30	22	table.navbox td.navbox-group + td {
31	23	padding: 3px; }
32	24	table.navbox div[style*="padding"] {
—	—	@@ -61,11 +53,6 @@
62	54	table.gallery .gallerybox[style] {
63	55	width: auto !important;
64	56	margin-bottom: -16px; }
65		~~- table.gallery .thumb[style] {~~
66		~~- border: 0;~~
67		~~- padding: 0 !important;~~
68		~~- width: auto !important;~~
69		~~- margin: 0 auto; }~~
70	57	table.gallery .gallerytext {
71	58	margin-top: -12px;
72	59	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
—	—	@@ -7,10 +7,6 @@
8	8	border: 0; }
9	9	table.toc {
10	10	background: #f9f9f9; }
11		~~- table.toc h2 {~~
12		~~- border: 0;~~
13		~~- padding: 0;~~
14		~~- margin-top: 5px; }~~
15	11	table.navbox {
16	12	font-size: 0.9em;
17	13	width: 100% !important; }
—	—	@@ -19,10 +15,6 @@
20	16	padding: 5px; }
21	17	table.navbox td.navbox-abovebelow {
22	18	padding: 3px; }
23		~~- table.navbox td.navbox-group {~~
24		~~- background: #ddddff;~~
25		~~- width: 25%;~~
26		~~- padding: 3px; }~~
27	19	table.navbox td.navbox-group + td {
28	20	padding: 3px; }
29	21	table.navbox div[style*="padding"] {
—	—	@@ -58,11 +50,6 @@
59	51	table.gallery .gallerybox[style] {
60	52	width: auto !important;
61	53	margin-bottom: -16px; }
62		~~- table.gallery .thumb[style] {~~
63		~~- border: 0;~~
64		~~- padding: 0 !important;~~
65		~~- width: auto !important;~~
66		~~- margin: 0 auto; }~~
67	54	table.gallery .gallerytext {
68	55	margin-top: -12px;
69	56	text-align: center; }

Follow-up revisions

Revision	Commit summary	Author	Date
r99661	Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...	reedy	23:59, 12 October 2011
r99719	Bug 31050 - Cleanup duplicate CSS for mobile devices...	reedy	19:18, 13 October 2011
r99721	Bug 31050 - Cleanup duplicate CSS for mobile devices...	reedy	19:33, 13 October 2011
r99723	Bug 31050 - Cleanup duplicate CSS for mobile devices...	reedy	19:51, 13 October 2011
r99758	Bug 31050 - Cleanup duplicate CSS for mobile devices...	reedy	08:00, 14 October 2011

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r99656	Add common.css...	reedy	23:27, 12 October 2011
r99657	Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...	reedy	23:32, 12 October 2011
r99658	Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...	reedy	23:36, 12 October 2011
r99659	Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...	reedy	23:43, 12 October 2011

Status & tagging log

17:42, 13 October 2011 Reedy (talk | contribs) changed the status of r99660 [removed: new added: reverted]