r99657 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99656‎ | r99657 | r99658 >
Date:23:32, 12 October 2011
Author:reedy
Status:reverted
Tags:
Comment:
Part of Bug 31050 - Cleanup duplicate CSS for mobile devices

Moved 16 lines of CSS from .clearlink to common.css

Set svn:eol-style native to common.css
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/kindle.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
——@@ -286,20 +286,3 @@
287287 height: 1.5em;
288288 position: relative;
289289 }
290 -
291 -.clearlink {
292 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
293 - background-position: center center;
294 - cursor: pointer;
295 - zoom:1;
296 - position: absolute;
297 - right: 0.25em;
298 - top: 50%;
299 - margin: 1px;
300 - height: 12px;
301 - width: 12px;
302 - margin-top: -6px;
303 - z-index: 2;
304 - border: 0px solid;
305 - display: none;
306 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
——@@ -0,0 +1,16 @@
 2+.clearlink {
 3+ background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
 4+ background-position: center center;
 5+ cursor: pointer;
 6+ zoom:1;
 7+ position: absolute;
 8+ right: 0.25em;
 9+ top: 50%;
 10+ margin: 1px;
 11+ height: 12px;
 12+ width: 12px;
 13+ margin-top: -6px;
 14+ z-index: 2;
 15+ border: 0px solid;
 16+ display: none;
 17+}
\ No newline at end of file
Property changes on: trunk/extensions/MobileFrontend/stylesheets/common.css
___________________________________________________________________
Added: svn:eol-style
118 + native
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
——@@ -326,20 +326,3 @@
327327 height: 1.5em;
328328 position: relative;
329329 }
330 -
331 -.clearlink {
332 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
333 - background-position: center center;
334 - cursor: pointer;
335 - zoom:1;
336 - position: absolute;
337 - right: 0.25em;
338 - top: 50%;
339 - margin: 1px;
340 - height: 12px;
341 - width: 12px;
342 - margin-top: -6px;
343 - z-index: 2;
344 - border: 0px solid;
345 - display: none;
346 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
——@@ -314,20 +314,3 @@
315315 height: 1.5em;
316316 position: relative;
317317 }
318 -
319 -.clearlink {
320 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
321 - background-position: center center;
322 - cursor: pointer;
323 - zoom:1;
324 - position: absolute;
325 - right: 0.25em;
326 - top: 50%;
327 - margin: 1px;
328 - height: 12px;
329 - width: 12px;
330 - margin-top: -6px;
331 - z-index: 2;
332 - border: 0px solid;
333 - display: none;
334 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
——@@ -303,20 +303,3 @@
304304 height: 1.5em;
305305 position: relative;
306306 }
307 -
308 -.clearlink {
309 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
310 - background-position: center center;
311 - cursor: pointer;
312 - zoom:1;
313 - position: absolute;
314 - right: 0.25em;
315 - top: 50%;
316 - margin: 1px;
317 - height: 12px;
318 - width: 12px;
319 - margin-top: -6px;
320 - z-index: 2;
321 - border: 0px solid;
322 - display: none;
323 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
——@@ -303,20 +303,3 @@
304304 height: 1.5em;
305305 position: relative;
306306 }
307 -
308 -.clearlink {
309 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
310 - background-position: center center;
311 - cursor: pointer;
312 - zoom:1;
313 - position: absolute;
314 - right: 0.25em;
315 - top: 50%;
316 - margin: 1px;
317 - height: 12px;
318 - width: 12px;
319 - margin-top: -6px;
320 - z-index: 2;
321 - border: 0px solid;
322 - display: none;
323 -}
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
——@@ -356,20 +356,3 @@
357357 height: 1.5em;
358358 position: relative;
359359 }
360 -
361 -.clearlink {
362 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
363 - background-position: center center;
364 - cursor: pointer;
365 - zoom:1;
366 - position: absolute;
367 - right: 0.25em;
368 - top: 50%;
369 - margin: 1px;
370 - height: 12px;
371 - width: 12px;
372 - margin-top: -6px;
373 - z-index: 2;
374 - border: 0px solid;
375 - display: none;
376 -}
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
——@@ -303,20 +303,3 @@
304304 height: 1.5em;
305305 position: relative;
306306 }
307 -
308 -.clearlink {
309 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
310 - background-position: center center;
311 - cursor: pointer;
312 - zoom:1;
313 - position: absolute;
314 - right: 0.25em;
315 - top: 50%;
316 - margin: 1px;
317 - height: 12px;
318 - width: 12px;
319 - margin-top: -6px;
320 - z-index: 2;
321 - border: 0px solid;
322 - display: none;
323 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/kindle.css
——@@ -119,20 +119,3 @@
120120 height: 1.5em;
121121 position: relative;
122122 }
123 -
124 -.clearlink {
125 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
126 - background-position: center center;
127 - cursor: pointer;
128 - zoom:1;
129 - position: absolute;
130 - right: 0.25em;
131 - top: 50%;
132 - margin: 1px;
133 - height: 12px;
134 - width: 12px;
135 - margin-top: -6px;
136 - z-index: 2;
137 - border: 0px solid;
138 - display: none;
139 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
——@@ -300,20 +300,3 @@
301301 height: 1.5em;
302302 position: relative;
303303 }
304 -
305 -.clearlink {
306 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
307 - background-position: center center;
308 - cursor: pointer;
309 - zoom:1;
310 - position: absolute;
311 - right: 0.25em;
312 - top: 50%;
313 - margin: 1px;
314 - height: 12px;
315 - width: 12px;
316 - margin-top: -6px;
317 - z-index: 2;
318 - border: 0px solid;
319 - display: none;
320 -}
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
——@@ -303,20 +303,3 @@
304304 height: 1.5em;
305305 position: relative;
306306 }
307 -
308 -.clearlink {
309 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
310 - background-position: center center;
311 - cursor: pointer;
312 - zoom:1;
313 - position: absolute;
314 - right: 0.25em;
315 - top: 50%;
316 - margin: 1px;
317 - height: 12px;
318 - width: 12px;
319 - margin-top: -6px;
320 - z-index: 2;
321 - border: 0px solid;
322 - display: none;
323 -}
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
——@@ -329,20 +329,3 @@
330330 height: 1.5em;
331331 position: relative;
332332 }
333 -
334 -.clearlink {
335 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
336 - background-position: center center;
337 - cursor: pointer;
338 - zoom:1;
339 - position: absolute;
340 - right: 0.25em;
341 - top: 50%;
342 - margin: 1px;
343 - height: 12px;
344 - width: 12px;
345 - margin-top: -6px;
346 - z-index: 2;
347 - border: 0px solid;
348 - display: none;
349 -}
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
——@@ -329,20 +329,3 @@
330330 height: 1.5em;
331331 position: relative;
332332 }
333 -
334 -.clearlink {
335 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
336 - background-position: center center;
337 - cursor: pointer;
338 - zoom:1;
339 - position: absolute;
340 - right: 0.25em;
341 - top: 50%;
342 - margin: 1px;
343 - height: 12px;
344 - width: 12px;
345 - margin-top: -6px;
346 - z-index: 2;
347 - border: 0px solid;
348 - display: none;
349 -}
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
——@@ -311,20 +311,3 @@
312312 height: 1.5em;
313313 position: relative;
314314 }
315 -
316 -.clearlink {
317 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
318 - background-position: center center;
319 - cursor: pointer;
320 - zoom:1;
321 - position: absolute;
322 - right: 0.25em;
323 - top: 50%;
324 - margin: 1px;
325 - height: 12px;
326 - width: 12px;
327 - margin-top: -6px;
328 - z-index: 2;
329 - border: 0px solid;
330 - display: none;
331 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
——@@ -287,21 +287,4 @@
288288 vertical-align:middle;
289289 height: 1.5em;
290290 position: relative;
291 -}
292 -
293 -.clearlink {
294 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
295 - background-position: center center;
296 - cursor: pointer;
297 - zoom:1;
298 - position: absolute;
299 - right: 0.25em;
300 - top: 50%;
301 - margin: 1px;
302 - height: 12px;
303 - width: 12px;
304 - margin-top: -6px;
305 - z-index: 2;
306 - border: 0px solid;
307 - display: none;
308291 }
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
——@@ -300,20 +300,3 @@
301301 height: 1.5em;
302302 position: relative;
303303 }
304 -
305 -.clearlink {
306 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
307 - background-position: center center;
308 - cursor: pointer;
309 - zoom:1;
310 - position: absolute;
311 - right: 0.25em;
312 - top: 50%;
313 - margin: 1px;
314 - height: 12px;
315 - width: 12px;
316 - margin-top: -6px;
317 - z-index: 2;
318 - border: 0px solid;
319 - display: none;
320 -}

Follow-up revisions

RevisionCommit summaryAuthorDate
r99658Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:36, 12 October 2011
r99659Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:43, 12 October 2011
r99660Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:50, 12 October 2011
r99661Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:59, 12 October 2011
r99719Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:18, 13 October 2011
r99721Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:33, 13 October 2011
r99723Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:51, 13 October 2011
r99758Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy08:00, 14 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99656Add common.css...reedy23:27, 12 October 2011

Status & tagging log