r99723 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99722‎ | r99723 | r99724 >
Date:19:51, 13 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Bug 31050 - Cleanup duplicate CSS for mobile devices

Move table.gallery and table.navbox

Remove some already refactored code from wii
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/kindle.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
——@@ -1,12 +1,3 @@
2 -table {
3 - border-spacing: 0 !important;
4 - width: 100%;
5 - border-collapse: collapse !important;
6 - border: 1px solid #cccccc;
7 - padding: 3px;
8 - margin-bottom: 15px;
9 -}
10 -
112 table td, table th {
123 border: 1px solid #cccccc;
134 padding: 3px;
——@@ -24,11 +15,6 @@
2516 background: #f9f9f9;
2617 }
2718
28 -table.navbox {
29 - font-size: 0.9em;
30 - width: 100% !important;
31 -}
32 -
3319 table.navbox th.navbox-title {
3420 background: #ccccff;
3521 padding: 5px;
——@@ -79,11 +65,6 @@
8066 border: 1px solid #cccccc;
8167 }
8268
83 -table.gallery {
84 - background: #f9f9f9;
85 - border-bottom: 0;
86 -}
87 -
8869 table.gallery .gallerybox[style] {
8970 width: auto !important;
9071 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
——@@ -83,3 +83,13 @@
8484 width: 25%;
8585 padding: 3px;
8686 }
 87+
 88+table.gallery {
 89+ background: #f9f9f9;
 90+ border-bottom: 0;
 91+}
 92+
 93+table.navbox {
 94+ font-size: 0.9em;
 95+ width: 100% !important;
 96+}
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/kindle.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
——@@ -19,11 +19,6 @@
2020 background: #f9f9f9;
2121 }
2222
23 -table.navbox {
24 - font-size: 0.9em;
25 - width: 100% !important;
26 -}
27 -
2823 table.navbox th.navbox-title {
2924 background: #ccccff;
3025 padding: 5px;
——@@ -74,11 +69,6 @@
7570 border: 1px solid #cccccc;
7671 }
7772
78 -table.gallery {
79 - background: #f9f9f9;
80 - border-bottom: 0;
81 -}
82 -
8373 table.gallery .gallerybox[style] {
8474 width: auto !important;
8575 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
——@@ -15,11 +15,6 @@
1616 background: #f9f9f9;
1717 }
1818
19 -table.navbox {
20 - font-size: 0.9em;
21 - width: 100% !important;
22 -}
23 -
2419 table.navbox th.navbox-title {
2520 background: #ccccff;
2621 padding: 5px;
——@@ -70,11 +65,6 @@
7166 border: 1px solid #cccccc;
7267 }
7368
74 -table.gallery {
75 - background: #f9f9f9;
76 - border-bottom: 0;
77 -}
78 -
7969 table.gallery .gallerybox[style] {
8070 width: auto !important;
8171 margin-bottom: -16px;

Follow-up revisions

RevisionCommit summaryAuthorDate
r99758Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy08:00, 14 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99656Add common.css...reedy23:27, 12 October 2011
r99657Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:32, 12 October 2011
r99658Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:36, 12 October 2011
r99659Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:43, 12 October 2011
r99660Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:50, 12 October 2011
r99661Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:59, 12 October 2011
r99719Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:18, 13 October 2011
r99721Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:33, 13 October 2011

Status & tagging log