r99719 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99718‎ | r99719 | r99720 >
Date:19:18, 13 October 2011
Author:reedy
Status:ok
Tags:
Comment:
Bug 31050 - Cleanup duplicate CSS for mobile devices

Move .clearlink, #search, .divclearable
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/kindle.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
@@ -380,43 +380,3 @@
381381 #search:focus {
382382 outline: none;
383383 }
384 -
385 -#search {
386 - -webkit-appearance: none;
387 - border-top-width: 0px;
388 - border-right-width: 0px;
389 - border-bottom-width: 0px;
390 - border-left-width: 0px;
391 - outline-style: none;
392 - outline-width: initial;
393 - outline-color: initial;
394 - height: 1.4em;
395 -}
396 -
397 -.divclearable {
398 - border: 1px solid #888;
399 - display: -moz-inline-stack;
400 - display: inline-block;
401 - zoom: 1;
402 - *display: inline;
403 - vertical-align: middle;
404 - height: 1.5em;
405 - position: relative;
406 -}
407 -
408 -.clearlink {
409 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
410 - background-position: center center;
411 - cursor: pointer;
412 - zoom: 1;
413 - position: absolute;
414 - right: 0.25em;
415 - top: 50%;
416 - margin: 1px;
417 - height: 12px;
418 - width: 12px;
419 - margin-top: -6px;
420 - z-index: 2;
421 - border: 0px solid;
422 - display: none;
423 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
@@ -0,0 +1,39 @@
 2+.clearlink {
 3+ background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
 4+ background-position: center center;
 5+ cursor: pointer;
 6+ zoom: 1;
 7+ position: absolute;
 8+ right: 0.25em;
 9+ top: 50%;
 10+ margin: 1px;
 11+ height: 12px;
 12+ width: 12px;
 13+ margin-top: -6px;
 14+ z-index: 2;
 15+ border: 0px solid;
 16+ display: none;
 17+}
 18+
 19+#search {
 20+ -webkit-appearance: none;
 21+ border-top-width: 0px;
 22+ border-right-width: 0px;
 23+ border-bottom-width: 0px;
 24+ border-left-width: 0px;
 25+ outline-style: none;
 26+ outline-width: initial;
 27+ outline-color: initial;
 28+ height: 1.4em;
 29+}
 30+
 31+.divclearable {
 32+ border: 1px solid #888;
 33+ display: -moz-inline-stack;
 34+ display: inline-block;
 35+ zoom: 1;
 36+ *display: inline;
 37+ vertical-align: middle;
 38+ height: 1.5em;
 39+ position: relative;
 40+}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
@@ -438,43 +438,3 @@
439439 #search:focus {
440440 outline: none;
441441 }
442 -
443 -#search {
444 - -webkit-appearance: none;
445 - border-top-width: 0px;
446 - border-right-width: 0px;
447 - border-bottom-width: 0px;
448 - border-left-width: 0px;
449 - outline-style: none;
450 - outline-width: initial;
451 - outline-color: initial;
452 - height: 1.4em;
453 -}
454 -
455 -.divclearable {
456 - border: 1px solid #888;
457 - display: -moz-inline-stack;
458 - display: inline-block;
459 - zoom: 1;
460 - *display: inline;
461 - vertical-align: middle;
462 - height: 1.5em;
463 - position: relative;
464 -}
465 -
466 -.clearlink {
467 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
468 - background-position: center center;
469 - cursor: pointer;
470 - zoom: 1;
471 - position: absolute;
472 - right: 0.25em;
473 - top: 50%;
474 - margin: 1px;
475 - height: 12px;
476 - width: 12px;
477 - margin-top: -6px;
478 - z-index: 2;
479 - border: 0px solid;
480 - display: none;
481 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
@@ -421,42 +421,3 @@
422422 outline: none;
423423 }
424424
425 -#search {
426 - -webkit-appearance: none;
427 - border-top-width: 0px;
428 - border-right-width: 0px;
429 - border-bottom-width: 0px;
430 - border-left-width: 0px;
431 - outline-style: none;
432 - outline-width: initial;
433 - outline-color: initial;
434 - height: 1.4em;
435 -}
436 -
437 -.divclearable {
438 - border: 1px solid #888;
439 - display: -moz-inline-stack;
440 - display: inline-block;
441 - zoom: 1;
442 - *display: inline;
443 - vertical-align: middle;
444 - height: 1.5em;
445 - position: relative;
446 -}
447 -
448 -.clearlink {
449 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
450 - background-position: center center;
451 - cursor: pointer;
452 - zoom: 1;
453 - position: absolute;
454 - right: 0.25em;
455 - top: 50%;
456 - margin: 1px;
457 - height: 12px;
458 - width: 12px;
459 - margin-top: -6px;
460 - z-index: 2;
461 - border: 0px solid;
462 - display: none;
463 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
@@ -403,43 +403,3 @@
404404 #search:focus {
405405 outline: none;
406406 }
407 -
408 -#search {
409 - -webkit-appearance: none;
410 - border-top-width: 0px;
411 - border-right-width: 0px;
412 - border-bottom-width: 0px;
413 - border-left-width: 0px;
414 - outline-style: none;
415 - outline-width: initial;
416 - outline-color: initial;
417 - height: 1.4em;
418 -}
419 -
420 -.divclearable {
421 - border: 1px solid #888;
422 - display: -moz-inline-stack;
423 - display: inline-block;
424 - zoom: 1;
425 - *display: inline;
426 - vertical-align: middle;
427 - height: 1.5em;
428 - position: relative;
429 -}
430 -
431 -.clearlink {
432 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
433 - background-position: center center;
434 - cursor: pointer;
435 - zoom: 1;
436 - position: absolute;
437 - right: 0.25em;
438 - top: 50%;
439 - margin: 1px;
440 - height: 12px;
441 - width: 12px;
442 - margin-top: -6px;
443 - z-index: 2;
444 - border: 0px solid;
445 - display: none;
446 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
@@ -404,42 +404,3 @@
405405 outline: none;
406406 }
407407
408 -#search {
409 - -webkit-appearance: none;
410 - border-top-width: 0px;
411 - border-right-width: 0px;
412 - border-bottom-width: 0px;
413 - border-left-width: 0px;
414 - outline-style: none;
415 - outline-width: initial;
416 - outline-color: initial;
417 - height: 1.4em;
418 -}
419 -
420 -.divclearable {
421 - border: 1px solid #888;
422 - display: -moz-inline-stack;
423 - display: inline-block;
424 - zoom: 1;
425 - *display: inline;
426 - vertical-align: middle;
427 - height: 1.5em;
428 - position: relative;
429 -}
430 -
431 -.clearlink {
432 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
433 - background-position: center center;
434 - cursor: pointer;
435 - zoom: 1;
436 - position: absolute;
437 - right: 0.25em;
438 - top: 50%;
439 - margin: 1px;
440 - height: 12px;
441 - width: 12px;
442 - margin-top: -6px;
443 - z-index: 2;
444 - border: 0px solid;
445 - display: none;
446 -}
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
@@ -476,42 +476,3 @@
477477 outline: none;
478478 }
479479
480 -#search {
481 - -webkit-appearance: none;
482 - border-top-width: 0px;
483 - border-right-width: 0px;
484 - border-bottom-width: 0px;
485 - border-left-width: 0px;
486 - outline-style: none;
487 - outline-width: initial;
488 - outline-color: initial;
489 - height: 1.4em;
490 -}
491 -
492 -.divclearable {
493 - border: 1px solid #888;
494 - display: -moz-inline-stack;
495 - display: inline-block;
496 - zoom: 1;
497 - *display: inline;
498 - vertical-align: middle;
499 - height: 1.5em;
500 - position: relative;
501 -}
502 -
503 -.clearlink {
504 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
505 - background-position: center center;
506 - cursor: pointer;
507 - zoom: 1;
508 - position: absolute;
509 - right: 0.25em;
510 - top: 50%;
511 - margin: 1px;
512 - height: 12px;
513 - width: 12px;
514 - margin-top: -6px;
515 - z-index: 2;
516 - border: 0px solid;
517 - display: none;
518 -}
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
@@ -405,41 +405,5 @@
406406 }
407407
408408 #search {
409 - -webkit-appearance: none;
410 - border-top-width: 0px;
411 - border-right-width: 0px;
412 - border-bottom-width: 0px;
413 - border-left-width: 0px;
414 - outline-style: none;
415 - outline-width: initial;
416 - outline-color: initial;
417409 height: 1.3em;
418410 }
419 -
420 -.divclearable {
421 - border: 1px solid #888;
422 - display: -moz-inline-stack;
423 - display: inline-block;
424 - zoom: 1;
425 - *display: inline;
426 - vertical-align: middle;
427 - height: 1.5em;
428 - position: relative;
429 -}
430 -
431 -.clearlink {
432 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
433 - background-position: center center;
434 - cursor: pointer;
435 - zoom: 1;
436 - position: absolute;
437 - right: 0.25em;
438 - top: 50%;
439 - margin: 1px;
440 - height: 12px;
441 - width: 12px;
442 - margin-top: -6px;
443 - z-index: 2;
444 - border: 0px solid;
445 - display: none;
446 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/kindle.css
@@ -158,43 +158,3 @@
159159 #search:focus {
160160 outline: none;
161161 }
162 -
163 -#search {
164 - -webkit-appearance: none;
165 - border-top-width: 0px;
166 - border-right-width: 0px;
167 - border-bottom-width: 0px;
168 - border-left-width: 0px;
169 - outline-style: none;
170 - outline-width: initial;
171 - outline-color: initial;
172 - height: 1.4em;
173 -}
174 -
175 -.divclearable {
176 - border: 1px solid #888;
177 - display: -moz-inline-stack;
178 - display: inline-block;
179 - zoom: 1;
180 - *display: inline;
181 - vertical-align: middle;
182 - height: 1.5em;
183 - position: relative;
184 -}
185 -
186 -.clearlink {
187 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
188 - background-position: center center;
189 - cursor: pointer;
190 - zoom: 1;
191 - position: absolute;
192 - right: 0.25em;
193 - top: 50%;
194 - margin: 1px;
195 - height: 12px;
196 - width: 12px;
197 - margin-top: -6px;
198 - z-index: 2;
199 - border: 0px solid;
200 - display: none;
201 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
@@ -400,42 +400,3 @@
401401 outline: none;
402402 }
403403
404 -#search {
405 - -webkit-appearance: none;
406 - border-top-width: 0px;
407 - border-right-width: 0px;
408 - border-bottom-width: 0px;
409 - border-left-width: 0px;
410 - outline-style: none;
411 - outline-width: initial;
412 - outline-color: initial;
413 - height: 1.4em;
414 -}
415 -
416 -.divclearable {
417 - border: 1px solid #888;
418 - display: -moz-inline-stack;
419 - display: inline-block;
420 - zoom: 1;
421 - *display: inline;
422 - vertical-align: middle;
423 - height: 1.5em;
424 - position: relative;
425 -}
426 -
427 -.clearlink {
428 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
429 - background-position: center center;
430 - cursor: pointer;
431 - zoom: 1;
432 - position: absolute;
433 - right: 0.25em;
434 - top: 50%;
435 - margin: 1px;
436 - height: 12px;
437 - width: 12px;
438 - margin-top: -6px;
439 - z-index: 2;
440 - border: 0px solid;
441 - display: none;
442 -}
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
@@ -403,43 +403,3 @@
404404 #search:focus {
405405 outline: none;
406406 }
407 -
408 -#search {
409 - -webkit-appearance: none;
410 - border-top-width: 0px;
411 - border-right-width: 0px;
412 - border-bottom-width: 0px;
413 - border-left-width: 0px;
414 - outline-style: none;
415 - outline-width: initial;
416 - outline-color: initial;
417 - height: 1.4em;
418 -}
419 -
420 -.divclearable {
421 - border: 1px solid #888;
422 - display: -moz-inline-stack;
423 - display: inline-block;
424 - zoom: 1;
425 - *display: inline;
426 - vertical-align: middle;
427 - height: 1.5em;
428 - position: relative;
429 -}
430 -
431 -.clearlink {
432 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
433 - background-position: center center;
434 - cursor: pointer;
435 - zoom: 1;
436 - position: absolute;
437 - right: 0.25em;
438 - top: 50%;
439 - margin: 1px;
440 - height: 12px;
441 - width: 12px;
442 - margin-top: -6px;
443 - z-index: 2;
444 - border: 0px solid;
445 - display: none;
446 -}
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
@@ -443,41 +443,6 @@
444444 }
445445
446446 #search {
447 - -webkit-appearance: none;
448 - border-top-width: 0px;
449 - border-right-width: 0px;
450 - border-bottom-width: 0px;
451 - border-left-width: 0px;
452 - outline-style: none;
453 - outline-width: initial;
454 - outline-color: initial;
455447 height: 1.3em;
456448 }
457449
458 -.divclearable {
459 - border: 1px solid #888;
460 - display: -moz-inline-stack;
461 - display: inline-block;
462 - zoom: 1;
463 - *display: inline;
464 - vertical-align: middle;
465 - height: 1.5em;
466 - position: relative;
467 -}
468 -
469 -.clearlink {
470 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
471 - background-position: center center;
472 - cursor: pointer;
473 - zoom: 1;
474 - position: absolute;
475 - right: 0.25em;
476 - top: 50%;
477 - margin: 1px;
478 - height: 12px;
479 - width: 12px;
480 - margin-top: -6px;
481 - z-index: 2;
482 - border: 0px solid;
483 - display: none;
484 -}
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
@@ -443,42 +443,3 @@
444444 outline: none;
445445 }
446446
447 -#search {
448 - -webkit-appearance: none;
449 - border-top-width: 0px;
450 - border-right-width: 0px;
451 - border-bottom-width: 0px;
452 - border-left-width: 0px;
453 - outline-style: none;
454 - outline-width: initial;
455 - outline-color: initial;
456 - height: 1.4em;
457 -}
458 -
459 -.divclearable {
460 - border: 1px solid #888;
461 - display: -moz-inline-stack;
462 - display: inline-block;
463 - zoom: 1;
464 - *display: inline;
465 - vertical-align: middle;
466 - height: 1.5em;
467 - position: relative;
468 -}
469 -
470 -.clearlink {
471 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
472 - background-position: center center;
473 - cursor: pointer;
474 - zoom: 1;
475 - position: absolute;
476 - right: 0.25em;
477 - top: 50%;
478 - margin: 1px;
479 - height: 12px;
480 - width: 12px;
481 - margin-top: -6px;
482 - z-index: 2;
483 - border: 0px solid;
484 - display: none;
485 -}
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
@@ -416,43 +416,3 @@
417417 #search:focus {
418418 outline: none;
419419 }
420 -
421 -#search {
422 - -webkit-appearance: none;
423 - border-top-width: 0px;
424 - border-right-width: 0px;
425 - border-bottom-width: 0px;
426 - border-left-width: 0px;
427 - outline-style: none;
428 - outline-width: initial;
429 - outline-color: initial;
430 - height: 1.4em;
431 -}
432 -
433 -.divclearable {
434 - border: 1px solid #888;
435 - display: -moz-inline-stack;
436 - display: inline-block;
437 - zoom: 1;
438 - *display: inline;
439 - vertical-align: middle;
440 - height: 1.5em;
441 - position: relative;
442 -}
443 -
444 -.clearlink {
445 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
446 - background-position: center center;
447 - cursor: pointer;
448 - zoom: 1;
449 - position: absolute;
450 - right: 0.25em;
451 - top: 50%;
452 - margin: 1px;
453 - height: 12px;
454 - width: 12px;
455 - margin-top: -6px;
456 - z-index: 2;
457 - border: 0px solid;
458 - display: none;
459 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
@@ -386,42 +386,3 @@
387387 outline: none;
388388 }
389389
390 -#search {
391 - -webkit-appearance: none;
392 - border-top-width: 0px;
393 - border-right-width: 0px;
394 - border-bottom-width: 0px;
395 - border-left-width: 0px;
396 - outline-style: none;
397 - outline-width: initial;
398 - outline-color: initial;
399 - height: 1.4em;
400 -}
401 -
402 -.divclearable {
403 - border: 1px solid #888;
404 - display: -moz-inline-stack;
405 - display: inline-block;
406 - zoom: 1;
407 - *display: inline;
408 - vertical-align: middle;
409 - height: 1.5em;
410 - position: relative;
411 -}
412 -
413 -.clearlink {
414 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
415 - background-position: center center;
416 - cursor: pointer;
417 - zoom: 1;
418 - position: absolute;
419 - right: 0.25em;
420 - top: 50%;
421 - margin: 1px;
422 - height: 12px;
423 - width: 12px;
424 - margin-top: -6px;
425 - z-index: 2;
426 - border: 0px solid;
427 - display: none;
428 -}
\ No newline at end of file
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
@@ -399,43 +399,3 @@
400400 #search:focus {
401401 outline: none;
402402 }
403 -
404 -#search {
405 - -webkit-appearance: none;
406 - border-top-width: 0px;
407 - border-right-width: 0px;
408 - border-bottom-width: 0px;
409 - border-left-width: 0px;
410 - outline-style: none;
411 - outline-width: initial;
412 - outline-color: initial;
413 - height: 1.4em;
414 -}
415 -
416 -.divclearable {
417 - border: 1px solid #888;
418 - display: -moz-inline-stack;
419 - display: inline-block;
420 - zoom: 1;
421 - *display: inline;
422 - vertical-align: middle;
423 - height: 1.5em;
424 - position: relative;
425 -}
426 -
427 -.clearlink {
428 - background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
429 - background-position: center center;
430 - cursor: pointer;
431 - zoom: 1;
432 - position: absolute;
433 - right: 0.25em;
434 - top: 50%;
435 - margin: 1px;
436 - height: 12px;
437 - width: 12px;
438 - margin-top: -6px;
439 - z-index: 2;
440 - border: 0px solid;
441 - display: none;
442 -}

Follow-up revisions

RevisionCommit summaryAuthorDate
r99721Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:33, 13 October 2011
r99723Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:51, 13 October 2011
r99758Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy08:00, 14 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99656Add common.css...reedy23:27, 12 October 2011
r99657Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:32, 12 October 2011
r99658Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:36, 12 October 2011
r99659Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:43, 12 October 2011
r99660Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:50, 12 October 2011
r99661Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:59, 12 October 2011

Status & tagging log