r99658 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r99657‎ | r99658 | r99659 >
Date:23:36, 12 October 2011
Author:reedy
Status:reverted
Tags:
Comment:
Part of Bug 31050 - Cleanup duplicate CSS for mobile devices

Moved 11 lines of CSS from #search to common.css
Modified paths:
  • /trunk/extensions/MobileFrontend/stylesheets/android.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/blackberry.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/common.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/default.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/firefox.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/iphone2.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/kindle.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/nokia.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/operamini.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/palm_pre.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/psp.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/simple.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/webkit_old.css (modified) (history)
  • /trunk/extensions/MobileFrontend/stylesheets/wii.css (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/stylesheets/wii.css
——@@ -264,18 +264,6 @@
265265 outline: none;
266266 }
267267
268 -#search {
269 - -webkit-appearance: none;
270 - border-top-width: 0px;
271 - border-right-width: 0px;
272 - border-bottom-width: 0px;
273 - border-left-width: 0px;
274 - outline-style: none;
275 - outline-width: initial;
276 - outline-color: initial;
277 - height: 1.4em;
278 -}
279 -
280268 .divclearable {
281269 border: 1px solid #888;
282270 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/common.css
——@@ -1,3 +1,15 @@
 2+#search {
 3+ -webkit-appearance: none;
 4+ border-top-width: 0px;
 5+ border-right-width: 0px;
 6+ border-bottom-width: 0px;
 7+ border-left-width: 0px;
 8+ outline-style: none;
 9+ outline-width: initial;
 10+ outline-color: initial;
 11+ height: 1.4em;
 12+}
 13+
214 .clearlink {
315 background: url(images/close-button.png) no-repeat scroll 0 0 transparent;
416 background-position: center center;
Index: trunk/extensions/MobileFrontend/stylesheets/simple.css
——@@ -304,18 +304,6 @@
305305 outline: none;
306306 }
307307
308 -#search {
309 - -webkit-appearance: none;
310 - border-top-width: 0px;
311 - border-right-width: 0px;
312 - border-bottom-width: 0px;
313 - border-left-width: 0px;
314 - outline-style: none;
315 - outline-width: initial;
316 - outline-color: initial;
317 - height: 1.4em;
318 -}
319 -
320308 .divclearable {
321309 border: 1px solid #888;
322310 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/palm_pre.css
——@@ -292,18 +292,6 @@
293293 outline: none;
294294 }
295295
296 -#search {
297 - -webkit-appearance: none;
298 - border-top-width: 0px;
299 - border-right-width: 0px;
300 - border-bottom-width: 0px;
301 - border-left-width: 0px;
302 - outline-style: none;
303 - outline-width: initial;
304 - outline-color: initial;
305 - height: 1.4em;
306 -}
307 -
308296 .divclearable {
309297 border: 1px solid #888;
310298 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/nokia.css
——@@ -281,18 +281,6 @@
282282 outline: none;
283283 }
284284
285 -#search {
286 - -webkit-appearance: none;
287 - border-top-width: 0px;
288 - border-right-width: 0px;
289 - border-bottom-width: 0px;
290 - border-left-width: 0px;
291 - outline-style: none;
292 - outline-width: initial;
293 - outline-color: initial;
294 - height: 1.4em;
295 -}
296 -
297285 .divclearable {
298286 border: 1px solid #888;
299287 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/firefox.css
——@@ -281,18 +281,6 @@
282282 outline: none;
283283 }
284284
285 -#search {
286 - -webkit-appearance: none;
287 - border-top-width: 0px;
288 - border-right-width: 0px;
289 - border-bottom-width: 0px;
290 - border-left-width: 0px;
291 - outline-style: none;
292 - outline-width: initial;
293 - outline-color: initial;
294 - height: 1.4em;
295 -}
296 -
297285 .divclearable {
298286 border: 1px solid #888;
299287 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/psp.css
——@@ -334,18 +334,6 @@
335335 outline: none;
336336 }
337337
338 -#search {
339 - -webkit-appearance: none;
340 - border-top-width: 0px;
341 - border-right-width: 0px;
342 - border-bottom-width: 0px;
343 - border-left-width: 0px;
344 - outline-style: none;
345 - outline-width: initial;
346 - outline-color: initial;
347 - height: 1.4em;
348 -}
349 -
350338 .divclearable {
351339 border: 1px solid #888;
352340 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/iphone2.css
——@@ -281,18 +281,6 @@
282282 outline: none;
283283 }
284284
285 -#search {
286 - -webkit-appearance: none;
287 - border-top-width: 0px;
288 - border-right-width: 0px;
289 - border-bottom-width: 0px;
290 - border-left-width: 0px;
291 - outline-style: none;
292 - outline-width: initial;
293 - outline-color: initial;
294 - height: 1.3em;
295 -}
296 -
297285 .divclearable {
298286 border: 1px solid #888;
299287 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/kindle.css
——@@ -97,18 +97,6 @@
9898 outline: none;
9999 }
100100
101 -#search {
102 - -webkit-appearance: none;
103 - border-top-width: 0px;
104 - border-right-width: 0px;
105 - border-bottom-width: 0px;
106 - border-left-width: 0px;
107 - outline-style: none;
108 - outline-width: initial;
109 - outline-color: initial;
110 - height: 1.4em;
111 -}
112 -
113101 .divclearable {
114102 border: 1px solid #888;
115103 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/android.css
——@@ -278,18 +278,6 @@
279279 outline: none;
280280 }
281281
282 -#search {
283 - -webkit-appearance: none;
284 - border-top-width: 0px;
285 - border-right-width: 0px;
286 - border-bottom-width: 0px;
287 - border-left-width: 0px;
288 - outline-style: none;
289 - outline-width: initial;
290 - outline-color: initial;
291 - height: 1.4em;
292 -}
293 -
294282 .divclearable {
295283 border: 1px solid #888;
296284 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/blackberry.css
——@@ -281,18 +281,6 @@
282282 outline: none;
283283 }
284284
285 -#search {
286 - -webkit-appearance: none;
287 - border-top-width: 0px;
288 - border-right-width: 0px;
289 - border-bottom-width: 0px;
290 - border-left-width: 0px;
291 - outline-style: none;
292 - outline-width: initial;
293 - outline-color: initial;
294 - height: 1.4em;
295 -}
296 -
297285 .divclearable {
298286 border: 1px solid #888;
299287 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/iphone.css
——@@ -307,18 +307,6 @@
308308 outline: none;
309309 }
310310
311 -#search {
312 - -webkit-appearance: none;
313 - border-top-width: 0px;
314 - border-right-width: 0px;
315 - border-bottom-width: 0px;
316 - border-left-width: 0px;
317 - outline-style: none;
318 - outline-width: initial;
319 - outline-color: initial;
320 - height: 1.3em;
321 -}
322 -
323311 .divclearable {
324312 border: 1px solid #888;
325313 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/operamini.css
——@@ -307,18 +307,6 @@
308308 outline: none;
309309 }
310310
311 -#search {
312 - -webkit-appearance: none;
313 - border-top-width: 0px;
314 - border-right-width: 0px;
315 - border-bottom-width: 0px;
316 - border-left-width: 0px;
317 - outline-style: none;
318 - outline-width: initial;
319 - outline-color: initial;
320 - height: 1.4em;
321 -}
322 -
323311 .divclearable {
324312 border: 1px solid #888;
325313 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/webkit_old.css
——@@ -289,18 +289,6 @@
290290 outline: none;
291291 }
292292
293 -#search {
294 - -webkit-appearance: none;
295 - border-top-width: 0px;
296 - border-right-width: 0px;
297 - border-bottom-width: 0px;
298 - border-left-width: 0px;
299 - outline-style: none;
300 - outline-width: initial;
301 - outline-color: initial;
302 - height: 1.4em;
303 -}
304 -
305293 .divclearable {
306294 border: 1px solid #888;
307295 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/default.css
——@@ -266,18 +266,6 @@
267267 outline: none;
268268 }
269269
270 -#search {
271 - -webkit-appearance: none;
272 - border-top-width: 0px;
273 - border-right-width: 0px;
274 - border-bottom-width: 0px;
275 - border-left-width: 0px;
276 - outline-style: none;
277 - outline-width: initial;
278 - outline-color: initial;
279 - height: 1.4em;
280 -}
281 -
282270 .divclearable {
283271 border: 1px solid #888;
284272 display: -moz-inline-stack;
Index: trunk/extensions/MobileFrontend/stylesheets/webkit.css
——@@ -278,18 +278,6 @@
279279 outline: none;
280280 }
281281
282 -#search {
283 - -webkit-appearance: none;
284 - border-top-width: 0px;
285 - border-right-width: 0px;
286 - border-bottom-width: 0px;
287 - border-left-width: 0px;
288 - outline-style: none;
289 - outline-width: initial;
290 - outline-color: initial;
291 - height: 1.4em;
292 -}
293 -
294282 .divclearable {
295283 border: 1px solid #888;
296284 display: -moz-inline-stack;

Follow-up revisions

RevisionCommit summaryAuthorDate
r99659Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:43, 12 October 2011
r99660Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:50, 12 October 2011
r99661Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:59, 12 October 2011
r99719Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:18, 13 October 2011
r99721Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:33, 13 October 2011
r99723Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy19:51, 13 October 2011
r99758Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy08:00, 14 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r99656Add common.css...reedy23:27, 12 October 2011
r99657Part of Bug 31050 - Cleanup duplicate CSS for mobile devices...reedy23:32, 12 October 2011

Status & tagging log