r99094 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99093‎ | r99094 | r99095 >
Date:13:01, 6 October 2011
Author:catrope
Status:ok
Tags:
Comment:
Modified paths:
  • /branches/wmf/1.18wmf1/includes/QueryPage.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/SpecialPageFactory.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/api/ApiQueryQueryPage.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/media/Tiff.php (modified) (history)
  • /branches/wmf/1.18wmf1/includes/specials/SpecialBlockList.php (modified) (history)
  • /branches/wmf/1.18wmf1/languages/Language.php (modified) (history)
  • /branches/wmf/1.18wmf1/resources/Resources.php (modified) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/images (added) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/images/sort_both.gif (added) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/images/sort_down.gif (added) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/images/sort_none.gif (added) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/images/sort_up.gif (added) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/jquery.tablesorter.css (added) (history)
  • /branches/wmf/1.18wmf1/resources/jquery/jquery.tablesorter.js (modified) (history)
  • /branches/wmf/1.18wmf1/skins/common/images/sort_both.gif (deleted) (history)
  • /branches/wmf/1.18wmf1/skins/common/images/sort_down.gif (deleted) (history)
  • /branches/wmf/1.18wmf1/skins/common/images/sort_none.gif (deleted) (history)
  • /branches/wmf/1.18wmf1/skins/common/images/sort_up.gif (deleted) (history)
  • /branches/wmf/1.18wmf1/skins/common/shared.css (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/skins/common/shared.css
@@ -794,20 +794,6 @@
795795 right: 10px;
796796 background-position: 0% 100%;
797797 }
798 -/* Table Sorting */
799 -th.headerSort {
800 - background-image: url(images/sort_both.gif);
801 - cursor: pointer;
802 - background-repeat: no-repeat;
803 - background-position: center right;
804 - padding-right: 21px;
805 -}
806 -th.headerSortUp {
807 - background-image: url(images/sort_up.gif);
808 -}
809 -th.headerSortDown {
810 - background-image: url(images/sort_down.gif);
811 -}
812798
813799 /* LTR content in RTL layout */
814800 .ltr {
Index: branches/wmf/1.18wmf1/skins/common/images/sort_up.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Index: branches/wmf/1.18wmf1/skins/common/images/sort_down.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Index: branches/wmf/1.18wmf1/skins/common/images/sort_none.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Index: branches/wmf/1.18wmf1/skins/common/images/sort_both.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Index: branches/wmf/1.18wmf1/includes/SpecialPageFactory.php
@@ -444,7 +444,7 @@
445445 wfProfileOut( __METHOD__ );
446446 return $title;
447447 } else {
448 - $context->setTitle( $page->getTitle() );
 448+ $context->setTitle( $page->getTitle( $par ) );
449449 }
450450
451451 } elseif ( !$page->isIncludable() ) {
Property changes on: branches/wmf/1.18wmf1/includes/SpecialPageFactory.php
___________________________________________________________________
Modified: svn:mergeinfo
452452 Merged /trunk/phase3/includes/SpecialPageFactory.php:r98235,98411,98665,98676,98678,98773,98812,99082,99091-99092
Index: branches/wmf/1.18wmf1/includes/api/ApiQueryQueryPage.php
@@ -104,7 +104,7 @@
105105 return;
106106 }
107107
108 - $res = $qp->doQuery( $params['limit'] + 1, $params['offset'] );
 108+ $res = $qp->doQuery( $params['offset'], $params['limit'] + 1 );
109109 $count = 0;
110110 $titles = array();
111111 foreach ( $res as $row ) {
Index: branches/wmf/1.18wmf1/includes/media/Tiff.php
@@ -17,13 +17,18 @@
1818 * Conversion to PNG for inline display can be disabled here...
1919 * Note scaling should work with ImageMagick, but may not with GD scaling.
2020 *
 21+ * Files pulled from an another MediaWiki instance via ForeignAPIRepo /
 22+ * InstantCommons will have thumbnails managed from the remote instance,
 23+ * so we can skip this check.
 24+ *
2125 * @param $file
2226 *
2327 * @return bool
2428 */
2529 function canRender( $file ) {
2630 global $wgTiffThumbnailType;
27 - return (bool)$wgTiffThumbnailType;
 31+ return (bool)$wgTiffThumbnailType
 32+ || ($file->getRepo() instanceof ForeignAPIRepo);
2833 }
2934
3035 /**
Index: branches/wmf/1.18wmf1/includes/specials/SpecialBlockList.php
@@ -245,7 +245,7 @@
246246
247247 switch( $name ) {
248248 case 'ipb_timestamp':
249 - $formatted = $wgLang->timeanddate( $value );
 249+ $formatted = $wgLang->timeanddate( $value, /* User preference timezome */ true );
250250 break;
251251
252252 case 'ipb_target':
@@ -271,7 +271,7 @@
272272 break;
273273
274274 case 'ipb_expiry':
275 - $formatted = $wgLang->formatExpiry( $value );
 275+ $formatted = $wgLang->formatExpiry( $value, /* User preference timezome */ true );
276276 if( $wgUser->isAllowed( 'block' ) ){
277277 if( $row->ipb_auto ){
278278 $links[] = $sk->linkKnown(
Property changes on: branches/wmf/1.18wmf1/includes/specials/SpecialBlockList.php
___________________________________________________________________
Modified: svn:mergeinfo
279279 Merged /trunk/phase3/includes/specials/SpecialBlockList.php:r98235,98411,98665,98676,98678,98773,98812,99082,99091-99092
Index: branches/wmf/1.18wmf1/includes/QueryPage.php
@@ -423,7 +423,7 @@
424424 }
425425
426426 public function getCachedTimestamp() {
427 - if ( !is_null( $this->cachedTimestamp ) ) {
 427+ if ( is_null( $this->cachedTimestamp ) ) {
428428 $dbr = wfGetDB( DB_SLAVE );
429429 $fname = get_class( $this ) . '::getCachedTimestamp';
430430 $this->cachedTimestamp = $dbr->selectField( 'querycache_info', 'qci_timestamp',
Index: branches/wmf/1.18wmf1/languages/Language.php
@@ -3463,7 +3463,7 @@
34643464 : $infinity;
34653465 } else {
34663466 return $format === true
3467 - ? $this->timeanddate( $expiry )
 3467+ ? $this->timeanddate( $expiry, /* User preference timezome */ true )
34683468 : wfTimestamp( $format, $expiry );
34693469 }
34703470 }
Index: branches/wmf/1.18wmf1/resources/jquery/jquery.tablesorter.css
@@ -0,0 +1,17 @@
 2+/* Table Sorting */
 3+table.jquery-tablesorter th.headerSort {
 4+ /* @embed */
 5+ background-image: url(images/sort_both.gif);
 6+ cursor: pointer;
 7+ background-repeat: no-repeat;
 8+ background-position: center right;
 9+ padding-right: 21px;
 10+}
 11+table.jquery-tablesorter th.headerSortUp {
 12+ /* @embed */
 13+ background-image: url(images/sort_up.gif);
 14+}
 15+table.jquery-tablesorter th.headerSortDown {
 16+ /* @embed */
 17+ background-image: url(images/sort_down.gif);
 18+}
Property changes on: branches/wmf/1.18wmf1/resources/jquery/jquery.tablesorter.css
___________________________________________________________________
Added: svn:eol-style
119 + native
Index: branches/wmf/1.18wmf1/resources/jquery/images/sort_up.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: branches/wmf/1.18wmf1/resources/jquery/images/sort_up.gif
___________________________________________________________________
Added: svn:mime-type
220 + image/gif
Index: branches/wmf/1.18wmf1/resources/jquery/images/sort_down.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: branches/wmf/1.18wmf1/resources/jquery/images/sort_down.gif
___________________________________________________________________
Added: svn:mime-type
321 + image/gif
Index: branches/wmf/1.18wmf1/resources/jquery/images/sort_both.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: branches/wmf/1.18wmf1/resources/jquery/images/sort_both.gif
___________________________________________________________________
Added: svn:mime-type
422 + image/gif
Index: branches/wmf/1.18wmf1/resources/jquery/images/sort_none.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: branches/wmf/1.18wmf1/resources/jquery/images/sort_none.gif
___________________________________________________________________
Added: svn:mime-type
523 + image/gif
Property changes on: branches/wmf/1.18wmf1/resources/jquery/images
___________________________________________________________________
Added: svn:mergeinfo
624 Merged /trunk/phase3/resources/jquery/images:r98665
Index: branches/wmf/1.18wmf1/resources/jquery/jquery.tablesorter.js
@@ -424,7 +424,7 @@
425425
426426 function explodeRowspans( $table ) {
427427 // Split multi row cells into multiple cells with the same content
428 - $table.find( '[rowspan]' ).each(function() {
 428+ $table.find( 'tbody [rowspan]' ).each(function() {
429429 var rowSpan = this.rowSpan;
430430 this.rowSpan = 1;
431431 var cell = $( this );
@@ -539,6 +539,7 @@
540540 return;
541541 }
542542 }
 543+ $table.addClass( "jquery-tablesorter" );
543544
544545 // New config object.
545546 table.config = {};
Index: branches/wmf/1.18wmf1/resources/Resources.php
@@ -161,6 +161,7 @@
162162 ),
163163 'jquery.tablesorter' => array(
164164 'scripts' => 'resources/jquery/jquery.tablesorter.js',
 165+ 'styles' => 'resources/jquery/jquery.tablesorter.css',
165166 'messages' => array( 'sort-descending', 'sort-ascending' ),
166167 ),
167168 'jquery.textSelection' => array(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98235(bug 31088) [Regression] "Create account/log in" should use the current title...aaron18:55, 27 September 2011
r98411Fix handling of qplimit/qpoffset and cachedtimestamp in QueryPage api module...bawolff15:16, 29 September 2011
r98665Add the class jquery-tablesorter to all tables that are made sortable....hartman11:08, 2 October 2011
r98676Follow up to r98665....hartman16:06, 2 October 2011
r98678Follow up r98665. And remove the old css of course.hartman16:10, 2 October 2011
r98773fix Bug #31317 - LiquidThreads arrow icon disappears upon collapsing a thread...mah16:20, 3 October 2011
r98812* (bug 31282) Fix use of ForeignAPIRepo/InstantCommons TIFF images when $wgTi...brion22:04, 3 October 2011
r99082Fix a regression from 1.17: Show date/times in user preference timezone....raymond09:52, 6 October 2011
r99091Followup r98676: add @embedcatrope12:51, 6 October 2011
r99092(bug 31420) Fix weird tablesorter bug where headers spanning multiple rows wo...catrope12:52, 6 October 2011

Status & tagging log