r98665 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r98664‎ | r98665 | r98666 >
Date:11:08, 2 October 2011
Author:hartman
Status:resolved (Comments)
Tags:
Comment:
Add the class jquery-tablesorter to all tables that are made sortable.
Use this classname to raise the specificity of the sortHeader, so that it is more difficult to accidently override with local css. Followup to r98069

Move the css into a seperate file and move the images for it to the jquery directory.
Modified paths:
  • /trunk/phase3/resources/Resources.php (modified) (history)
  • /trunk/phase3/resources/jquery/images/sort_both.gif (added) (history)
  • /trunk/phase3/resources/jquery/images/sort_down.gif (added) (history)
  • /trunk/phase3/resources/jquery/images/sort_none.gif (added) (history)
  • /trunk/phase3/resources/jquery/images/sort_up.gif (added) (history)
  • /trunk/phase3/resources/jquery/jquery.tablesorter.js (modified) (history)
  • /trunk/phase3/skins/common/images/sort_both.gif (deleted) (history)
  • /trunk/phase3/skins/common/images/sort_down.gif (deleted) (history)
  • /trunk/phase3/skins/common/images/sort_none.gif (deleted) (history)
  • /trunk/phase3/skins/common/images/sort_up.gif (deleted) (history)

Diff [purge]

Index: trunk/phase3/skins/common/images/sort_up.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Index: trunk/phase3/skins/common/images/sort_down.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Index: trunk/phase3/skins/common/images/sort_none.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Index: trunk/phase3/skins/common/images/sort_both.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Index: trunk/phase3/resources/jquery/images/sort_up.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: trunk/phase3/resources/jquery/images/sort_up.gif
___________________________________________________________________
Added: svn:mime-type
11 + image/gif
Index: trunk/phase3/resources/jquery/images/sort_down.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: trunk/phase3/resources/jquery/images/sort_down.gif
___________________________________________________________________
Added: svn:mime-type
22 + image/gif
Index: trunk/phase3/resources/jquery/images/sort_both.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: trunk/phase3/resources/jquery/images/sort_both.gif
___________________________________________________________________
Added: svn:mime-type
33 + image/gif
Index: trunk/phase3/resources/jquery/images/sort_none.gif
Cannot display: file marked as a binary type.
svn:mime-type = image/gif
Property changes on: trunk/phase3/resources/jquery/images/sort_none.gif
___________________________________________________________________
Added: svn:mime-type
44 + image/gif
Index: trunk/phase3/resources/jquery/jquery.tablesorter.js
@@ -540,6 +540,7 @@
541541 return;
542542 }
543543 }
 544+ $table.addClass( "jquery-tablesorter" );
544545
545546 // New config object.
546547 table.config = {};
Index: trunk/phase3/resources/Resources.php
@@ -183,6 +183,7 @@
184184 ),
185185 'jquery.tablesorter' => array(
186186 'scripts' => 'resources/jquery/jquery.tablesorter.js',
 187+ 'styles' => 'resources/jquery/jquery.tablesorter.css',
187188 'messages' => array( 'sort-descending', 'sort-ascending' ),
188189 ),
189190 'jquery.textSelection' => array(

Follow-up revisions

RevisionCommit summaryAuthorDate
r98676Follow up to r98665....hartman16:06, 2 October 2011
r98678Follow up r98665. And remove the old css of course.hartman16:10, 2 October 2011
r990941.18wmf1: MFT r98235, r98411, r98665, r98676, r98678, r98773, r98812, r99082,...catrope13:01, 6 October 2011
r99307Add !important to the tablesorter indicator....hartman12:59, 8 October 2011
r99989REL1_18:...reedy22:24, 16 October 2011
r100736REL1_18 MFT r98665reedy20:11, 25 October 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r98069Raise the specificity of the sortable header....hartman17:26, 25 September 2011

Comments

#Comment by Krinkle (talk | contribs)   14:42, 2 October 2011

The css file appears to be missing.

#Comment by TheDJ (talk | contribs)   16:06, 2 October 2011

Thx Krinkle, r98676

#Comment by TheDJ (talk | contribs)   19:46, 4 October 2011

I think this and followups should be merged into 1.18.

Status & tagging log